From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54C0D25A357; Wed, 25 Feb 2026 01:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983482; cv=none; b=XXeoUFtYYXBzHf0i7gIxaGY5lKHs7BOWPVAxbSubtQu9jifp9RrivfpasunYcviI0gw98H6M4I2dwNM/HzaXWNas5FOMpNHmxDY8EdlOS/x6ZvX1PBEZvytn557i6oIaQ3qRb3FI+ECWDFybZnbzs+mZ3QW0BwIfVf/lugAOk1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983482; c=relaxed/simple; bh=y3uRc6ln9l1Xny1cAIAjV4G4nrKgqTmgXPlIgg1jpvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mj/6tgrTSuVS9+EKPKIUXURvfOFM98W9GOz9mtFhDMjFVl+w4KtMEuoZss4qJvcHiP9PYCZjHhmmvuB2FRDRh60z+Z+3iXY2Xe6kkcYZbmSb922HGWbGZBrkW3pADGCwxs8mkRxFUmEVTMGWEfaU/RKSIeHYrI0rbowEzO2fyns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YM7AyrQG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YM7AyrQG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19CB5C116D0; Wed, 25 Feb 2026 01:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983482; bh=y3uRc6ln9l1Xny1cAIAjV4G4nrKgqTmgXPlIgg1jpvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YM7AyrQGp9YLZqfVCOJIZryQtODovM2Khh4cqnfbev2yQiD3ZNWUhFsKCfFQUKsYX y5WwHIYPttvi3DnOW85LLfScbX2pe/oyhB2ot8goQnccTOVxxEh16VBj8Eg+t15agK 6VtP2PFUbuCv4r7iZiHjAKhQ5L/vZfE0ybhu4p7A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jose Javier Rodriguez Barbarin , Johannes Thumshirn , Sasha Levin Subject: [PATCH 6.19 595/781] mcb: fix incorrect sanity check Date: Tue, 24 Feb 2026 17:21:44 -0800 Message-ID: <20260225012414.391695228@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jose Javier Rodriguez Barbarin [ Upstream commit bc2e4bc952e26dd93b978588219044bd8b24237b ] __mcb_register_driver() makes some sanity checks over mcb_driver to check if .probe and .remove callbacks are set. However, since commit 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") removed the .remove callback from menz127-gpio.c, not all mcb device drivers implement .remove callback. Remove .remove check to ensure all mcb device drivers can be loaded. Signed-off-by: Jose Javier Rodriguez Barbarin Fixes: 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") [ jth: added statement about menz127-gpio.c ] Signed-off-by: Johannes Thumshirn Link: https://patch.msgid.link/16fb55bd59d9c1d2ce2443f41d4dec2048f9a8ec.1768562302.git.jth@kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/mcb/mcb-core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c index c1367223e71a0..3d487d75c483d 100644 --- a/drivers/mcb/mcb-core.c +++ b/drivers/mcb/mcb-core.c @@ -85,7 +85,8 @@ static void mcb_remove(struct device *dev) struct mcb_device *mdev = to_mcb_device(dev); struct module *carrier_mod; - mdrv->remove(mdev); + if (mdrv->remove) + mdrv->remove(mdev); carrier_mod = mdev->dev.parent->driver->owner; module_put(carrier_mod); @@ -176,13 +177,13 @@ static const struct device_type mcb_carrier_device_type = { * @owner: The @mcb_driver's module * @mod_name: The name of the @mcb_driver's module * - * Register a @mcb_driver at the system. Perform some sanity checks, if - * the .probe and .remove methods are provided by the driver. + * Register a @mcb_driver at the system. Perform a sanity check, if + * .probe method is provided by the driver. */ int __mcb_register_driver(struct mcb_driver *drv, struct module *owner, const char *mod_name) { - if (!drv->probe || !drv->remove) + if (!drv->probe) return -EINVAL; drv->driver.owner = owner; -- 2.51.0