From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84996256C84; Wed, 25 Feb 2026 01:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983494; cv=none; b=ENQ3kUxwICewiIXPQd2Abw++Lwfni9wFs/mwGR4KcjsFArA9xmj6wEMW4xbi6os1OZREslh5gxZXJq3yjdWWqyWgOBnWHijev3N1l0s2KXZC03hIzNBDl61Tj7RD91IS2ZtyVZRxwMnuAJFjdsttvTwz/XRkl0AnN3pTse3YDX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983494; c=relaxed/simple; bh=vaKDAJu5PM5zh3RadBJJyWcrCK9Nw11HZ1mnboSRufI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UqbRkPjSWQy95VHYdrd9jd4dScCgo9hNHUcxm5wHhCgSTpGf8NC/12rih31WTGhP98HHyaeiHGve6nIfb28Mg57qHLoElTX/YuLTC/HuQ/dC8PYHwAiGPeF7ib8dBSKesubqYOI+83Y+K8q0NZzXwCtbC0dE40rlr7DDOJM4hpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uUJvbG74; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uUJvbG74" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36543C116D0; Wed, 25 Feb 2026 01:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983494; bh=vaKDAJu5PM5zh3RadBJJyWcrCK9Nw11HZ1mnboSRufI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uUJvbG746XRtq703pkK7xtfFwgaZXbZu328nCBoar5D/eeIY8HYNx+oyST6MqOl2O 96GXqfyPgFLbclPNHnlv6Gn9sNyMs0V6BmmEcaqQMxQjCGLT/Hl5dVzptpPJ0frOjH xSdvPn99tTdcX5ZjlpRJF+oVomU66ySm+vgT9uHM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wei Li , Linus Walleij , Sasha Levin Subject: [PATCH 6.19 604/781] pinctrl: single: fix refcount leak in pcs_add_gpio_func() Date: Tue, 24 Feb 2026 17:21:53 -0800 Message-ID: <20260225012414.609666179@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Li [ Upstream commit 353353309b0f7afa407df29e455f9d15b5acc296 ] of_parse_phandle_with_args() returns a device_node pointer with refcount incremented in gpiospec.np. The loop iterates through all phandles but never releases the reference, causing a refcount leak on each iteration. Add of_node_put() calls to release the reference after extracting the needed arguments and on the error path when devm_kzalloc() fails. This bug was detected by our static analysis tool and verified by my code review. Fixes: a1a277eb76b3 ("pinctrl: single: create new gpio function range") Signed-off-by: Wei Li Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-single.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 998f23d6c3179..d85e6c1f63218 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1359,6 +1359,7 @@ static int pcs_add_gpio_func(struct device_node *node, struct pcs_device *pcs) } range = devm_kzalloc(pcs->dev, sizeof(*range), GFP_KERNEL); if (!range) { + of_node_put(gpiospec.np); ret = -ENOMEM; break; } @@ -1368,6 +1369,7 @@ static int pcs_add_gpio_func(struct device_node *node, struct pcs_device *pcs) mutex_lock(&pcs->mutex); list_add_tail(&range->node, &pcs->gpiofuncs); mutex_unlock(&pcs->mutex); + of_node_put(gpiospec.np); } return ret; } -- 2.51.0