From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A89B92550D7 for ; Wed, 25 Feb 2026 01:49:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771984187; cv=none; b=J5ftHHUZnqUDpG3vRo5cTvHYi5TzTtaDQaWj/kNNYQeMADBi+mGbebLw2mZ/mK0Q0wiKMNc/ncW6NYJu52a0Bdwl3d9Fdi/AQ7LpTqieib1hTd3pPrWDOAg8eRPZUVs6IocG5PFkp3rT+gpatYlXWG1L5hRgTA375TsLmZ4pLno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771984187; c=relaxed/simple; bh=s+ff8zgDMFPdWeyBpjoEmN2k6OPPbZuKWYjmY9mcSME=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XXJ23KDFimBXeJ8jL2AaGZxRtDYNfCvMDgma7ThGYLSjWzZNo8N1/8YJnGa/rwLDLTbculgGWvmLjOqp2ntGYthBAzRcw88zpL+1YRp77PGU16fkvJA+YM6lR20FOjzsCgEpGArulEZHtX6F32HYaOmBZdN9VPDHvLLSO4hiU6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=igZ1IjNM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="igZ1IjNM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4E78C19423; Wed, 25 Feb 2026 01:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771984187; bh=s+ff8zgDMFPdWeyBpjoEmN2k6OPPbZuKWYjmY9mcSME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=igZ1IjNM0LXK0SJMswLZ5yEjYUzJ2xoX3Z0Dm671xg3efbh/hs/NucQ8Q4gsB1YCX bqmMPwL2lrEqKS2KEoGe0cgTsDqg9C8TBx3dmtmr5VvjoH4u5wX9hBGNyzuw4Ix3ga 0w0xuSi4+POwYUUnisYs0QyrteSWTWWbU0D1f5cKH7Dbm5aPL7BtTy2oaaD79C9UTx eL2Z4tTBHwrMST5kanmEw2CVnZ7GMQcgJ13mha9jw2ihCK/g/xu9Qh3SvGB9rs429K A/4cbef0wCpS2IuJYYmfJa7oRy40Qlczph6MVNygAn82BS8yj+b3BzPHBbd7hUnYae yVzMrcxQ8wK2w== From: Sasha Levin To: stable@vger.kernel.org Cc: Fedor Pchelkin , Namjae Jeon , Steve French , Sasha Levin Subject: [PATCH 6.18.y] ksmbd: call ksmbd_vfs_kern_path_end_removing() on some error paths Date: Tue, 24 Feb 2026 20:49:44 -0500 Message-ID: <20260225014944.3768468-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026022440-hypnosis-wriggle-2ec2@gregkh> References: <2026022440-hypnosis-wriggle-2ec2@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Fedor Pchelkin [ Upstream commit a09dc10d1353f0e92c21eae2a79af1c2b1ddcde8 ] There are two places where ksmbd_vfs_kern_path_end_removing() needs to be called in order to balance what the corresponding successful call to ksmbd_vfs_kern_path_start_removing() has done, i.e. drop inode locks and put the taken references. Otherwise there might be potential deadlocks and unbalanced locks which are caught like: BUG: workqueue leaked lock or atomic: kworker/5:21/0x00000000/7596 last function: handle_ksmbd_work 2 locks held by kworker/5:21/7596: #0: ffff8881051ae448 (sb_writers#3){.+.+}-{0:0}, at: ksmbd_vfs_kern_path_locked+0x142/0x660 #1: ffff888130e966c0 (&type->i_mutex_dir_key#3/1){+.+.}-{4:4}, at: ksmbd_vfs_kern_path_locked+0x17d/0x660 CPU: 5 PID: 7596 Comm: kworker/5:21 Not tainted 6.1.162-00456-gc29b353f383b #138 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.17.0-debian-1.17.0-1 04/01/2014 Workqueue: ksmbd-io handle_ksmbd_work Call Trace: dump_stack_lvl+0x44/0x5b process_one_work.cold+0x57/0x5c worker_thread+0x82/0x600 kthread+0x153/0x190 ret_from_fork+0x22/0x30 Found by Linux Verification Center (linuxtesting.org). Fixes: d5fc1400a34b ("smb/server: avoid deadlock when linking with ReplaceIfExists") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin Acked-by: Namjae Jeon Signed-off-by: Steve French [ ksmbd_vfs_kern_path_end_removing() -> ksmbd_vfs_kern_path_unlock() ] Signed-off-by: Sasha Levin --- fs/smb/server/smb2pdu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index bf8c480594367..e52b9136abbff 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -6117,14 +6117,14 @@ static int smb2_create_link(struct ksmbd_work *work, rc = -EINVAL; ksmbd_debug(SMB, "cannot delete %s\n", link_name); - goto out; } } else { rc = -EEXIST; ksmbd_debug(SMB, "link already exists\n"); - goto out; } ksmbd_vfs_kern_path_unlock(&path); + if (rc) + goto out; } rc = ksmbd_vfs_link(work, target_name, link_name); if (rc) -- 2.51.0