From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8616B274B39 for ; Wed, 25 Feb 2026 02:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771986017; cv=none; b=muuOvacoDcoSosSCUmG17XZy8JGU88A7lSakZUt4T8NIin5XtFwPBjThhv8dXPRZsvcY0+Brhh93ud1cZDmc61k9HeWcDRGY98dZlB0jikn6yQL+fijF0/HL9Dg5CP52YD+7SASMiQUedIRRxKUGMpvCkteHNlj+8tVU0OePmCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771986017; c=relaxed/simple; bh=I6LRcaCQL7v5qqltX67Ebt3X2iKK/60mIRiUOGf2VnM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HSMCLj8zfLWWaCzlvzQiDXW1zpUOSP5vtDzBYIoGkjpp5Nn9TJ10urU6rk9a3ukRGb5d3LKmSY7Bjx/aMpQ4oQiZSi2aGFSTlQWlR0sVM98fIyovOAVn3z+lsUpzu/7BOtmC209cUZ+vDRQcoTB5vh2dbfeYAw68rVXk9ibsD84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OmkcaAtJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OmkcaAtJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C93DEC2BC9E; Wed, 25 Feb 2026 02:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771986017; bh=I6LRcaCQL7v5qqltX67Ebt3X2iKK/60mIRiUOGf2VnM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OmkcaAtJTQR2miM0IwCiXxtZKzy5CC0C67dQpRgUn+f21ysxYgHeXoYIWMjRMUP4H osBhs3br1bzBLS9aJVkrLFRlYSdcYcIYoYovdMm3b6d4ROPJ8fbOQVEUJ+BvrbU6sG qXe9/92HSm0iphDId1K3Ugvesb3T3OlIGF91gAGX5qpYA8HBjKXYPRxuxzv89CfGxA dTLqZ6DoiPxLLm+Y+gxix+L8PqYwxagmNCCAoAttiGYNcveBzYjrCgnylQ0MHQmk46 jVnLIQ72/gC5RBmHI0QcfM7Tswkog8inE2O/bElLAsWUqU0eNoR8Q8nWSIC4Flh54A Gl8uZ9Uc1oQnA== From: Sasha Levin To: stable@vger.kernel.org Cc: =?UTF-8?q?Th=C3=A9o=20Lebrun?= , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 5.15.y 2/3] usb: cdns3: call cdns_power_is_lost() only once in cdns_resume() Date: Tue, 24 Feb 2026 21:20:13 -0500 Message-ID: <20260225022014.3800129-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260225022014.3800129-1-sashal@kernel.org> References: <2026022424-backshift-doily-d162@gregkh> <20260225022014.3800129-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Théo Lebrun [ Upstream commit 17c6526b333cfd89a4c888a6f7c876c8c326e5ae ] cdns_power_is_lost() does a register read. Call it only once rather than twice. Signed-off-by: Théo Lebrun Link: https://lore.kernel.org/r/20250205-s2r-cdns-v7-4-13658a271c3c@bootlin.com Signed-off-by: Greg Kroah-Hartman Stable-dep-of: 87e4b043b98a ("usb: cdns3: fix role switching during resume") Signed-off-by: Sasha Levin --- drivers/usb/cdns3/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index d272d7b82bec1..8e46fd36b0e56 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -523,11 +523,12 @@ EXPORT_SYMBOL_GPL(cdns_suspend); int cdns_resume(struct cdns *cdns) { + bool power_lost = cdns_power_is_lost(cdns); enum usb_role real_role; bool role_changed = false; int ret = 0; - if (cdns_power_is_lost(cdns)) { + if (power_lost) { if (!cdns->role_sw) { real_role = cdns_hw_role_state_machine(cdns); if (real_role != cdns->role) { @@ -550,7 +551,7 @@ int cdns_resume(struct cdns *cdns) } if (cdns->roles[cdns->role]->resume) - cdns->roles[cdns->role]->resume(cdns, cdns_power_is_lost(cdns)); + cdns->roles[cdns->role]->resume(cdns, power_lost); return 0; } -- 2.51.0