From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B163679CD for ; Wed, 25 Feb 2026 03:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771990951; cv=none; b=AMtGpyo9BMdXLdk3DOSlUiasiOyeGDWMCHbiKqSkAbV9NlNiCY6eDNpK8kLXniiKMOyPxmPcgJ/gAnzIzMcsVrLzxyvKFab5xttV816CfXUfovMHKSiTff4gTVXFSzYOjZaJlKWoGa0nt0j33RUzzH4sL/dJcqGs9mO4z1wNTdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771990951; c=relaxed/simple; bh=yoCdl3qpm1PFgWeIaqGnf1vCImyZ1XG3QqJKWtXvecU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FkibhwB0eMcsXKkrqEOfEkkFFW5mWn9CjfduFnuyaA7dMzj5YMZNsLmAHAsAbOu7QPLNAuwsnMyGsXA7OcY18XwMYp7R260rFWrlJCUa1Wcnyr6R1BZoJ/VZcLmN1jZW6dpUpBeohgXo3nHrA8ntMfozFLVo3/VfjD85SkZtZaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rH3Y5Ak+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rH3Y5Ak+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6FF8C19421; Wed, 25 Feb 2026 03:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771990951; bh=yoCdl3qpm1PFgWeIaqGnf1vCImyZ1XG3QqJKWtXvecU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rH3Y5Ak+fGna2MHDdlKgxRkXxZL4GCsroDBrQPSjjzcnOd9iDDJcUIT5UA4CueCVw trrMwqvv9qjGPSzGcm771wi2sUzXmS/NcRN9V87TJ18k9nMrAvvFKDliF496y/2h3l uOD0Y7n3f9VYqYMHONeZrp7OvFGd4I+W07ZBna0eRJOyyoiHC2j4+RIyvFY4m7nhqR f9WYW44ANHWWOdNii/Bh9HAQC10+3ytYHIljqZJFtT5Ny0mvc85gLJlS9rVUxmuTI0 KCag+Z6z/oxCL+WZAhI6+gffi6B9zBh/gUr50ySsPBm0jZZQPEWKJDbZ18vivWHfOC EJB4ThShHiuEA== From: Sasha Levin To: stable@vger.kernel.org Cc: Zhang Yi , Baokun Li , stable@kernel.org, Ojaswin Mujoo , Theodore Ts'o , Sasha Levin Subject: [PATCH 6.6.y 5/5] ext4: drop extent cache when splitting extent fails Date: Tue, 24 Feb 2026 22:42:25 -0500 Message-ID: <20260225034225.3893579-5-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260225034225.3893579-1-sashal@kernel.org> References: <2026022428-ranged-scrabble-b28b@gregkh> <20260225034225.3893579-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhang Yi [ Upstream commit 79b592e8f1b435796cbc2722190368e3e8ffd7a1 ] When the split extent fails, we might leave some extents still being processed and return an error directly, which will result in stale extent entries remaining in the extent status tree. So drop all of the remaining potentially stale extents if the splitting fails. Signed-off-by: Zhang Yi Reviewed-by: Baokun Li Cc: stable@kernel.org Reviewed-by: Ojaswin Mujoo Message-ID: <20251129103247.686136-8-yi.zhang@huaweicloud.com> Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/extents.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 3fd5d4c500f56..3230f5c1207be 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -3241,7 +3241,7 @@ static struct ext4_ext_path *ext4_split_extent_at(handle_t *handle, err = PTR_ERR(path); if (err != -ENOSPC && err != -EDQUOT && err != -ENOMEM) - return path; + goto out_path; /* * Get a new path to try to zeroout or fix the extent length. @@ -3255,7 +3255,7 @@ static struct ext4_ext_path *ext4_split_extent_at(handle_t *handle, if (IS_ERR(path)) { EXT4_ERROR_INODE(inode, "Failed split extent on %u, err %ld", split, PTR_ERR(path)); - return path; + goto out_path; } depth = ext_depth(inode); ex = path[depth].p_ext; @@ -3315,6 +3315,10 @@ static struct ext4_ext_path *ext4_split_extent_at(handle_t *handle, ext4_free_ext_path(path); path = ERR_PTR(err); } +out_path: + if (IS_ERR(path)) + /* Remove all remaining potentially stale extents. */ + ext4_es_remove_extent(inode, ee_block, ee_len); ext4_ext_show_leaf(inode, path); return path; } -- 2.51.0