From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4EFD395D94 for ; Wed, 25 Feb 2026 19:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772048415; cv=none; b=m8BPSL67rBt+/plhL4CJY+B19Q8mDkUWjtqAdYljs5dxJfLNrJ2r9ng7iVUkCyo0HYj209vAJGbSc5IwzbycrrhOE0zVdtU4bLLhFvevgbHmLBlqeByIQwfgE48WLxuNIFvEgHap/qhryb8J1iG8Qg5iBSUHFJcABnY6tK8yslA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772048415; c=relaxed/simple; bh=QjJey1tsBt78uqBnAnUSLeZkRgeCV0mERaGdMseQhd8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GAJUAwf4ACdgfioIftNMbgiGJ53KLcejR+mW50aCAY7mtLW/FSFbtZ0afU6Izueab0T1wmAInjUKtEchpj4rGHBXg7oodT15Iu4wYuVIWuSD8fLBNkfzIt++moJWpg06UANq+NEd5BzfFqy+kSbxtcBzrTaStPmddEqfkFAMVXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sIAsJgas; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sIAsJgas" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AFDDC19421; Wed, 25 Feb 2026 19:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772048414; bh=QjJey1tsBt78uqBnAnUSLeZkRgeCV0mERaGdMseQhd8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sIAsJgasNdwejmEDAmWumCZ1zadjEeXkIidfI3fGjfu01uqII7vZyKD4jD5d3yseQ 5rVZDx/GOm6N7Q7yzqBK5ob95kFo30VO18g8/1KgRdui2O9vNTV85ZbG5ubTbvVVlo 6zO2dIeWoarwdSJuMsA34qfP3HMdu62Lb5/wLVqmpFFt4Fdbde/F8tYF6ERSxHPmPg tgX18EsI0BDuV1LhIq+6ciNk2N3lAtWwEfgcTgfGpomoXXdAflFuPY5qhoB5pVlbJ0 RFFP7ua1pfElOvowRc+L0FiEFEVDVw4Zamy/HHFVjGUmS2vVmhvdR3txIL+UIYORvw 2eqPh4CkiGflA== From: Sasha Levin To: stable@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , "Martin K. Petersen" , John Garry , Igor Pylypiv , Sasha Levin Subject: [PATCH 5.10.y 2/2] ata: libata-scsi: refactor ata_scsi_translate() Date: Wed, 25 Feb 2026 14:40:11 -0500 Message-ID: <20260225194011.1015550-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260225194011.1015550-1-sashal@kernel.org> References: <2026022431-quote-freefall-2523@gregkh> <20260225194011.1015550-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Damien Le Moal [ Upstream commit bb3a8154b1a1dc2c86d037482c0a2cf9186829ed ] Factor out of ata_scsi_translate() the code handling queued command deferral using the port qc_defer callback and issuing the queued command with ata_qc_issue() into the new function ata_scsi_qc_issue(), and simplify the goto used in ata_scsi_translate(). While at it, also add a lockdep annotation to check that the port lock is held when ata_scsi_translate() is called. No functional changes. Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal Reviewed-by: Niklas Cassel Reviewed-by: Martin K. Petersen Reviewed-by: John Garry Reviewed-by: Igor Pylypiv [ scsi_done(cmd) => cmd->scsi_done(cmd) + DPRINTK ] Signed-off-by: Sasha Levin --- drivers/ata/libata-scsi.c | 83 +++++++++++++++++++++++---------------- 1 file changed, 50 insertions(+), 33 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index d6b83614d798f..ae89d6fd32c0b 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1668,6 +1668,42 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc) ata_qc_done(qc); } +static int ata_scsi_qc_issue(struct ata_port *ap, struct ata_queued_cmd *qc) +{ + int ret; + + if (!ap->ops->qc_defer) + goto issue; + + /* Check if the command needs to be deferred. */ + ret = ap->ops->qc_defer(qc); + switch (ret) { + case 0: + break; + case ATA_DEFER_LINK: + ret = SCSI_MLQUEUE_DEVICE_BUSY; + break; + case ATA_DEFER_PORT: + ret = SCSI_MLQUEUE_HOST_BUSY; + break; + default: + WARN_ON_ONCE(1); + ret = SCSI_MLQUEUE_HOST_BUSY; + break; + } + + if (ret) { + /* Force a requeue of the command to defer its execution. */ + ata_qc_free(qc); + return ret; + } + +issue: + ata_qc_issue(qc); + + return 0; +} + /** * ata_scsi_translate - Translate then issue SCSI command to ATA device * @dev: ATA device to which the command is addressed @@ -1691,69 +1727,50 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc) * spin_lock_irqsave(host lock) * * RETURNS: - * 0 on success, SCSI_ML_QUEUE_DEVICE_BUSY if the command - * needs to be deferred. + * 0 on success, SCSI_ML_QUEUE_DEVICE_BUSY or SCSI_MLQUEUE_HOST_BUSY if the + * command needs to be deferred. */ static int ata_scsi_translate(struct ata_device *dev, struct scsi_cmnd *cmd, ata_xlat_func_t xlat_func) { struct ata_port *ap = dev->link->ap; struct ata_queued_cmd *qc; - int rc; + lockdep_assert_held(ap->lock); + + /* + * ata_scsi_qc_new() calls scsi_done(cmd) in case of failure. So we + * have nothing further to do when allocating a qc fails. + */ qc = ata_scsi_qc_new(dev, cmd); if (!qc) - goto err_mem; + return 0; /* data is present; dma-map it */ if (cmd->sc_data_direction == DMA_FROM_DEVICE || cmd->sc_data_direction == DMA_TO_DEVICE) { if (unlikely(scsi_bufflen(cmd) < 1)) { ata_dev_warn(dev, "WARNING: zero len r/w req\n"); - goto err_did; + cmd->result = (DID_ERROR << 16); + goto done; } ata_sg_init(qc, scsi_sglist(cmd), scsi_sg_count(cmd)); - qc->dma_dir = cmd->sc_data_direction; } qc->complete_fn = ata_scsi_qc_complete; if (xlat_func(qc)) - goto early_finish; - - if (ap->ops->qc_defer) { - if ((rc = ap->ops->qc_defer(qc))) - goto defer; - } - - /* select device, send command to hardware */ - ata_qc_issue(qc); + goto done; - return 0; + return ata_scsi_qc_issue(ap, qc); -early_finish: +done: ata_qc_free(qc); cmd->scsi_done(cmd); DPRINTK("EXIT - early finish (good or error)\n"); return 0; - -err_did: - ata_qc_free(qc); - cmd->result = (DID_ERROR << 16); - cmd->scsi_done(cmd); -err_mem: - DPRINTK("EXIT - internal\n"); - return 0; - -defer: - ata_qc_free(qc); - DPRINTK("EXIT - defer\n"); - if (rc == ATA_DEFER_LINK) - return SCSI_MLQUEUE_DEVICE_BUSY; - else - return SCSI_MLQUEUE_HOST_BUSY; } struct ata_scsi_args { -- 2.51.0