From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC6D4384520; Sat, 28 Feb 2026 17:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300185; cv=none; b=J3eAlEK+pNi/O2hzG39iBkmW4dSPmuiB28Ledpa2T6UumO++3CK8e7PVs3aBx91JK5kH+rlIwW4MIAY4Qn0ThULoym16J7CipeqfYIxOm24FNQ2DQkN05TvQtYjgg9nL9SKYcZanMjrN71NORD1VfhlCi+8sxFOMgO9tydV+KMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300185; c=relaxed/simple; bh=pUC00dQjKHBTt5nZppW0FFDjlsWQZo9tD2+ybHrc3VU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JRjZFyhVZ+89GWy7SuXtzRsiqZZh8L2UW7JWbHqe6T7N1kVar7IHOX/woUBodr5EE0KDU31NHb6J1WGO0jyf/roxdpDZJk+DLTUBQQ8/cMhTY6ulBKbcp3o9SBg7UpIxaw35jwjkcXyoeH3GyhgEATc1+skUS6b2VtpHkfeI428= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z4i4WcSM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z4i4WcSM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABC63C19423; Sat, 28 Feb 2026 17:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300185; bh=pUC00dQjKHBTt5nZppW0FFDjlsWQZo9tD2+ybHrc3VU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z4i4WcSMd1Rsb0XNJlQhRcFbpFGO4g4kZematVi4t9QiK1FDKvD4SwKXB3NP4EEgV Ue69EfDyolqitDRiZBJ2mXKFCK5nSZgOG9R8fl6ufY0dzBCtrgJLTMSKIKjTF602Ux 31tHrLAdi6sQPTAHh05//XC7Aq41izaJmqnEWfObL/ede8P9HfQdlX238oVuNyp/SD KCLzcyj1WrGwsbhWisQKUWV2CQTmWY1tkb/tXoyA3zdNR762tMy66F1ZlIxtOyQ0vs lkSx6dzSuTxZ26wy+l10ThrhupLyISLzY8w/zHA70JtwPKz1j2yGfdJmaCePahCFJs KTLQLaA7zb51g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ovidiu Bunea , Karen Chen , Matthew Stewart , Dan Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 6.19 203/844] drm/amd/display: Disable FEC when powering down encoders Date: Sat, 28 Feb 2026 12:21:56 -0500 Message-ID: <20260228173244.1509663-204-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Ovidiu Bunea [ Upstream commit 8cee62904caf95e5698fa0f2d420f5f22b4dea15 ] [why & how] VBIOS DMCUB FW can enable FEC for capable eDPs, but S/W DC state is only updated for link0 when transitioning into OS with driver loaded. This causes issues when the eDP is immediately hidden and DIG0 is assigned to another link that does not support FEC. Driver will attempt to disable FEC but FEC enablement occurs based on the link state, which does not have fec_state updated since it is a different link. Thus, FEC disablement on DIG0 will get skipped and cause no light up. Reviewed-by: Karen Chen Signed-off-by: Ovidiu Bunea Signed-off-by: Matthew Stewart Tested-by: Dan Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c index 9f7087ac41f21..3d2673a22759a 100644 --- a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c @@ -59,6 +59,7 @@ #include "dc_state_priv.h" #include "dpcd_defs.h" #include "dsc.h" +#include "dc_dp_types.h" /* include DCE11 register header files */ #include "dce/dce_11_0_d.h" #include "dce/dce_11_0_sh_mask.h" @@ -1736,20 +1737,25 @@ static void power_down_encoders(struct dc *dc) int i; for (i = 0; i < dc->link_count; i++) { - enum signal_type signal = dc->links[i]->connector_signal; - - dc->link_srv->blank_dp_stream(dc->links[i], false); + struct dc_link *link = dc->links[i]; + struct link_encoder *link_enc = link->link_enc; + enum signal_type signal = link->connector_signal; + dc->link_srv->blank_dp_stream(link, false); if (signal != SIGNAL_TYPE_EDP) signal = SIGNAL_TYPE_NONE; - if (dc->links[i]->ep_type == DISPLAY_ENDPOINT_PHY) - dc->links[i]->link_enc->funcs->disable_output( - dc->links[i]->link_enc, signal); + if (link->ep_type == DISPLAY_ENDPOINT_PHY) + link_enc->funcs->disable_output(link_enc, signal); + + if (link->fec_state == dc_link_fec_enabled) { + link_enc->funcs->fec_set_enable(link_enc, false); + link_enc->funcs->fec_set_ready(link_enc, false); + link->fec_state = dc_link_fec_not_ready; + } - dc->links[i]->link_status.link_active = false; - memset(&dc->links[i]->cur_link_settings, 0, - sizeof(dc->links[i]->cur_link_settings)); + link->link_status.link_active = false; + memset(&link->cur_link_settings, 0, sizeof(link->cur_link_settings)); } } -- 2.51.0