From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DCC233A9D1; Sat, 28 Feb 2026 17:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300028; cv=none; b=G0DFRerakwKgrVD4IaJGkjqjoZcqoonVQC3X+Chd3dHO5oQXU1KkHzPjCC+nZtFtJhHb0epu72TdqW1daLI+dDS9qVBbR/VhiTsSSHTS4NP7zlyry+6cPx65FBlFNXOgpF73psUJH2jdxpMUQ/XzCIR4m5+tuo6PGe6/5WJ0i2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300028; c=relaxed/simple; bh=OuM3R714gkSYXJVa0MHO55s0U6lgQYUyrnpXyQvuiPc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LVHxdu4WN3oWS3Cr/BKbHJnUu6GlSDKxdPbRPdiXEA+9O09AkjC9G41coW/mnGExCC+8uGp9ZgpkDgKafjD/rWR1OEQG8FtgzVYXgQd8yyUu+mnTt5/JL418EbNxAltWK0l0laMgc6KUAaTOPR70hZ0WRXU/rvU1rvn11Vhn9Mw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lUkIuBlh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lUkIuBlh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41525C19423; Sat, 28 Feb 2026 17:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300027; bh=OuM3R714gkSYXJVa0MHO55s0U6lgQYUyrnpXyQvuiPc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lUkIuBlhp0Mzxet/p4bMXjAfkqVwqPx9S9f2c+NYI4p1doDuxaHTwlw5mqc7f6/oD jIyfKoS8kE0ASgejnx7yQXhnne8ECU1sj5EMfhXZhyprAAfk1TwpLPmOiqFt4pRTea JcVyJjSkZrxjyeJ0qdeaATXAvOCTgDVhj+x1Nkh0VtQWDnEIFt74gCkuc3whPoWr0J zfKfcxLuntLiXz9CYwRUgbSv80c2mbYQXTKrYLYB4NJbjBvQx5BlVet9ZMJjq0kOjI Pz10RisqBHKljcMDYSDtjt+trgQtLZJ89RZxCqj81mOJz1ExRQieA6HLVN4Y+OiTjF esgRhwqO8gWyA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Clint George , Ming Lei , Shuah Khan , Sasha Levin Subject: [PATCH 6.19 039/844] kselftest/kublk: include message in _Static_assert for C11 compatibility Date: Sat, 28 Feb 2026 12:19:12 -0500 Message-ID: <20260228173244.1509663-40-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Clint George [ Upstream commit 3e6ad272bb8b3199bad952e7b077102af2d8df03 ] Add descriptive message in the _Static_assert to comply with the C11 standard requirement to prevent compiler from throwing out error. The compiler throws an error when _Static_assert is used without a message as that is a C23 extension. [] Testing: The diff between before and after of running the kselftest test of the module shows no regression on system with x86 architecture [] Error log: ~/Desktop/kernel-dev/linux-v1/tools/testing/selftests/ublk$ make LLVM=1 W=1 CC kublk In file included from kublk.c:6: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extension [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7); | ^ | , "" 1 error generated. In file included from null.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extension [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7); | ^ | , "" 1 error generated. In file included from file_backed.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extension [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7); | ^ | , "" 1 error generated. In file included from common.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extension [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7); | ^ | , "" 1 error generated. In file included from stripe.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extension [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7); | ^ | , "" 1 error generated. In file included from fault_inject.c:11: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extension [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7); | ^ | , "" 1 error generated. make: *** [../lib.mk:225: ~/Desktop/kernel-dev/linux-v1/tools/testing/selftests/ublk/kublk] Error 1 Link: https://lore.kernel.org/r/20251215085022.7642-1-clintbgeorge@gmail.com Signed-off-by: Clint George Reviewed-by: Ming Lei Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/ublk/kublk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ublk/kublk.h b/tools/testing/selftests/ublk/kublk.h index 8a83b90ec603a..cae2e30f0cdd5 100644 --- a/tools/testing/selftests/ublk/kublk.h +++ b/tools/testing/selftests/ublk/kublk.h @@ -223,7 +223,7 @@ static inline __u64 build_user_data(unsigned tag, unsigned op, unsigned tgt_data, unsigned q_id, unsigned is_target_io) { /* we only have 7 bits to encode q_id */ - _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7); + _Static_assert(UBLK_MAX_QUEUES_SHIFT <= 7, "UBLK_MAX_QUEUES_SHIFT must be <= 7"); assert(!(tag >> 16) && !(op >> 8) && !(tgt_data >> 16) && !(q_id >> 7)); return tag | (op << 16) | (tgt_data << 24) | -- 2.51.0