From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CD8A481A9B; Sat, 28 Feb 2026 17:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300399; cv=none; b=NPKh+rM4+Sep5p2+ROAc5kAEC5mRwk9r9pk3DGjXQAUtSL546BBnh6QZHeOhahlsSZTzoQvt4Bu0vhnJlHePSq/V7xynLZWWuOEnQZ6YC2S3LvXgs2w3OXg267Xi+mRiIzX8rbbYiiVZdb4MZLtXUY5DS01JE5Dl4pStVIgpAtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300399; c=relaxed/simple; bh=wBsxPKeSjbR8ckgdKfACUaRlX2AI0xFolBu/BvXXt5A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WzvxjxypB1JOyeDSeSHDcKTswUjRENGhF85tYI245A3lw3qsLVpHcbnCwRPIGPIHsvYSC5Qf7ysg0SapD96uqS36A+dimtVMEqpnGAKUJcjVtFBzu5ZUao4VjDDdQfOXzgBoaIUXtKnUpWWhyjngtqM0p4Cvxia9i5ZvPz97iks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FbzQT4Ji; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FbzQT4Ji" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D542C19423; Sat, 28 Feb 2026 17:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300398; bh=wBsxPKeSjbR8ckgdKfACUaRlX2AI0xFolBu/BvXXt5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FbzQT4JiFSCKGUZW0YsdHAJYKz3HD0agIYc0VBkCrYrx2+peVnwA6KEyealEXu6Ra hcNsUh7HG4DK/kyKH0I/Mb3P+74Ys7+kZl4XhqHW4Ranyxag+mK99CcUqQXUW1bWgt BJH49mHILIGhZYWMS3dI/AZ3ymxAKilGuNid6X5hDzlU55/mbOD83rIHEU0xtag/a4 ZIOmszdZKCK01e5k96Bio0XJ3MXKwckePdDPY8h8oQepIRF2fCJn8P8v7uSNhflhQW cSFqqZHD85vnIAQ0Y+KpEyjSwKf2S2nvKvJ5bzyabkekrie3FYH488WXcSk+YAGCdf LeJn5cngExH1w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Adarsh Das , Qu Wenruo , David Sterba , Sasha Levin Subject: [PATCH 6.19 436/844] btrfs: replace BUG() with error handling in __btrfs_balance() Date: Sat, 28 Feb 2026 12:25:49 -0500 Message-ID: <20260228173244.1509663-437-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Adarsh Das [ Upstream commit be6324a809dbda76d5fdb23720ad9b20e5c1905c ] We search with offset (u64)-1 which should never match exactly. Previously this was handled with BUG(). Now logs an error and return -EUCLEAN. Reviewed-by: Qu Wenruo Signed-off-by: Adarsh Das Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/volumes.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 99e167a697ba8..1cbe7c6a2889c 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -4234,8 +4234,14 @@ static int __btrfs_balance(struct btrfs_fs_info *fs_info) * this shouldn't happen, it means the last relocate * failed */ - if (ret == 0) - BUG(); /* FIXME break ? */ + if (unlikely(ret == 0)) { + btrfs_err(fs_info, + "unexpected exact match of CHUNK_ITEM in chunk tree, offset 0x%llx", + key.offset); + mutex_unlock(&fs_info->reclaim_bgs_lock); + ret = -EUCLEAN; + goto error; + } ret = btrfs_previous_item(chunk_root, path, 0, BTRFS_CHUNK_ITEM_KEY); -- 2.51.0