From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F3BE3D16CC; Sat, 28 Feb 2026 17:40:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300424; cv=none; b=Dg0DkkAINfAkbk5MpWG7U3QLwZ5DixtYiV+XNHSfEreJ1VrDvxFdnJoEzsIgbGhcosQ47PEDJ1swJ2J51l9u3SD3POZj0n1RVpMqkW2wFnTi0Dtnfw8dFGO/4ksQ0yJv2uqdMp09OSzCHmIiKUhtrzaNdTYDhWGZ//nlytBV1rY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300424; c=relaxed/simple; bh=YsgnVC5mvlJ8X8mgQnsL8yzWbVEER0wnQ52gvS/bdnk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iloUZFWMvZZgbHVrsxlaEARaAG5KnKHDLG5cq1b0ngXg9JP3+r9792HJPOhU4C4niTsia7/du48vYaKiFvdegMZJON0iYoFhsau/r/bmQZTeAD+6fgkRIOdHwPI/LUZbbZlNhYC+J2eOWMWWP0IloOC7X/wCaFeHPVpjxggPIJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c+K4mwOf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c+K4mwOf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6506CC19423; Sat, 28 Feb 2026 17:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300424; bh=YsgnVC5mvlJ8X8mgQnsL8yzWbVEER0wnQ52gvS/bdnk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c+K4mwOfhbxIbDZPpIeGfcBsO5LmoOK1VnZ3A3ragumRvAMZiq8yJGam0IgueAD+X csvfmudBB7cBK6XoXYo9WCN7BjBOoSPDXyFcWRQCSgkZeMegcD/IJpyY98rgp7EFHe DlMh3aNMUhe/Xt9l7Iu0T+AjXrP99dfSSi9gsrNKFMtoxkNXyhTPgNvftOUuaWP6+Z biFLvBv7n1C/qnapypxu0e2diRd+2uEHTETGuQLaEkqU6+F2S7AXmXDztRWfEGL/Ha DGGH5xDgxOY4dEQNVn3dPTsynX2Qd/kvCLgSotN72HfNQ4qJs7MTG2k6Fg5gPciAI7 dRJbq6p8D0IcA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pavan Chebbi , Michael Chan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.19 462/844] bnxt_en: Fix deleting of Ntuple filters Date: Sat, 28 Feb 2026 12:26:15 -0500 Message-ID: <20260228173244.1509663-463-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Pavan Chebbi [ Upstream commit c1bbd9900d65ac65b9fce9f129e3369a04871570 ] Ntuple filters can be deleted when the interface is down. The current code blindly sends the filter delete command to FW. When the interface is down, all the VNICs are deleted in the FW. When the VNIC is freed in the FW, all the associated filters are also freed. We need not send the free command explicitly. Sending such command will generate FW error in the dmesg. In order to fix this, we can safely return from bnxt_hwrm_cfa_ntuple_filter_free() when BNXT_STATE_OPEN is not true which confirms the VNICs have been deleted. Fixes: 8336a974f37d ("bnxt_en: Save user configured filters in a lookup list") Suggested-by: Michael Chan Signed-off-by: Pavan Chebbi Signed-off-by: Michael Chan Link: https://patch.msgid.link/20260219185313.2682148-3-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 64832289e18d0..c4657bb3acc18 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -6212,6 +6212,9 @@ int bnxt_hwrm_cfa_ntuple_filter_free(struct bnxt *bp, int rc; set_bit(BNXT_FLTR_FW_DELETED, &fltr->base.state); + if (!test_bit(BNXT_STATE_OPEN, &bp->state)) + return 0; + rc = hwrm_req_init(bp, req, HWRM_CFA_NTUPLE_FILTER_FREE); if (rc) return rc; -- 2.51.0