From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C66AA3E5F6E; Sat, 28 Feb 2026 17:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300505; cv=none; b=NZWJ7VCJwRxmsl7YK1+tGCouz8h+dzPDRQxTtGdDV6aMfb/BQVelm/HpJnLZER26EoXZaEzYloNWODxlVAPYqh09Rxy3DRBFTZKbGE2ppTlCpBxnPEre0bVIKQJ8Ve1Rmj6/dKldjlvmGFipSg6/t0TPD+aGF5qdpx9q4Dj4s0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300505; c=relaxed/simple; bh=GxDXmstvReh/VpnhcvzNewuHYQd1fFD24YPjiqH04vQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GENavErQfP6IUjp90J62pimw56+JZWj8zxX1+eanXhaZ7tdeMnvyar4gzLWtOQvTSY8Q58EC6aoKnQ9SbzyLXptC+A4MykOd5HhnhZBEkR2f2X2e9r5B4yhr3ymHq6CJO28GQVBfJEymqFCAdQy/eYdqJ9ZZdDebQ509bPwK3Oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZXH0q7ls; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZXH0q7ls" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A730DC19423; Sat, 28 Feb 2026 17:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300505; bh=GxDXmstvReh/VpnhcvzNewuHYQd1fFD24YPjiqH04vQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZXH0q7lsRsigxTkVYDEt97wxSJ42xe2HAdyFMcdFaiv72WiOXSvwb5+JfgACKeTjA rQsF0uMs5jJ6U/QbB22frc+/LP0ustbRIU9xEMCeefeSaSJSDACOUx+vfos6Z/UtNm rToiS68Zc+KOI1+Mpy5EgNgbq3gMh3x2aq3oXWhZrk6bmq62IjS1yrbcaw9vb7XuPY NIlfWjcy7zr37i3cHbO1s1CjKLenNHeWCaXV1pnPO0zRad/zuJT1KwoWST/Ka3DlY7 nLowqfCs4FijE+6BeIuONNYK4yc0lwxsOhu/7IdPVUe18bejR+ARn8av/revftUP3y AEWmiZSwwSNHA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xulin Sun , Nicolas Dufresne , Hans Verkuil , Sasha Levin Subject: [PATCH 6.19 543/844] media: chips-media: wave5: Fix kthread worker destruction in polling mode Date: Sat, 28 Feb 2026 12:27:36 -0500 Message-ID: <20260228173244.1509663-544-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Xulin Sun [ Upstream commit 5a0c122e834b2f7f029526422c71be922960bf03 ] Fix the cleanup order in polling mode (irq < 0) to prevent kernel warnings during module removal. Cancel the hrtimer before destroying the kthread worker to ensure work queues are empty. In polling mode, the driver uses hrtimer to periodically trigger wave5_vpu_timer_callback() which queues work via kthread_queue_work(). The kthread_destroy_worker() function validates that both work queues are empty with WARN_ON(!list_empty(&worker->work_list)) and WARN_ON(!list_empty(&worker->delayed_work_list)). The original code called kthread_destroy_worker() before hrtimer_cancel(), creating a race condition where the timer could fire during worker destruction and queue new work, triggering the WARN_ON. This causes the following warning on every module unload in polling mode: ------------[ cut here ]------------ WARNING: CPU: 2 PID: 1034 at kernel/kthread.c:1430 kthread_destroy_worker+0x84/0x98 Modules linked in: wave5(-) rpmsg_ctrl rpmsg_char ... Call trace: kthread_destroy_worker+0x84/0x98 wave5_vpu_remove+0xc8/0xe0 [wave5] platform_remove+0x30/0x58 ... ---[ end trace 0000000000000000 ]--- Fixes: ed7276ed2fd0 ("media: chips-media: wave5: Add hrtimer based polling support") Cc: stable@vger.kernel.org Signed-off-by: Xulin Sun Reviewed-by: Nicolas Dufresne Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/chips-media/wave5/wave5-vpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c index 23aa3ab51a0ef..0bcd48df49d0f 100644 --- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c @@ -352,8 +352,9 @@ static void wave5_vpu_remove(struct platform_device *pdev) struct vpu_device *dev = dev_get_drvdata(&pdev->dev); if (dev->irq < 0) { - kthread_destroy_worker(dev->worker); hrtimer_cancel(&dev->hrtimer); + kthread_cancel_work_sync(&dev->work); + kthread_destroy_worker(dev->worker); } pm_runtime_dont_use_autosuspend(&pdev->dev); -- 2.51.0