From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 001693EC6C1; Sat, 28 Feb 2026 17:42:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300522; cv=none; b=siv98ES8W6aLBDSt/V/pnTfP45l7Q4dLVOoV4hWzJFCGwD2TRBsT6xsM2KIUf7ZB0pph1Li5So6DYT7Tb2KATNen6wZ7Nty4azEeck6KBJAYXsDqBFUu2vq8xRLwTNYTS7pslGicGvAA3ErIMwge2N7Dcq3KWCFXuWPY8PeHlMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300522; c=relaxed/simple; bh=OssYHVtpqWoKQFKjafrGzXcfF6y3P6GuD0ExBSD0byU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cVbq6G6sLaI3OZjxRx540OTTDq8I4iJgt1J4NQE4dRNUdqkKQlV+t7TnEX8rYCGwKYZmEL0nW8nf5R5V459q8W9wdx1xsn3XOy4FUHaAi4iDmWENP5eYs9XH+78ZqWX4/WV7U599ff7yJdgZqKUxOFJnrjZr3mWFJjumWovpisI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hwGzzLDW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hwGzzLDW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 454FFC116D0; Sat, 28 Feb 2026 17:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300521; bh=OssYHVtpqWoKQFKjafrGzXcfF6y3P6GuD0ExBSD0byU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hwGzzLDWkxrgFJr+xemMJRTqrNv+51x8Kn3wHLeq4Rn2xqv8ZXIlOoC2+vso99xVz Ac5a9KVYKfW7v+pS65tFPZW2MV44Sy0Eyf2x/Sw9rgYDv8t58M0RPYNK7puZ0jPGzy 6O8HEeiVrdPrCRifrVxa4505URb13bAcHwy7ukmdgHyuMPNcJKmkXrGWIRL+dvQX1a gRUpmXJnPpoUC3ivPgd7XriDPy9XokBdrzDZ3ATLAUbhuQUzBUbQhQ7dDThDDGrpYY Am1UtKarOHv6YUGlO/VGCbN75W8o1yG8aQmH2Mw3CDZ+FyYGvp4im7MXglgTPztBQ9 bbgKR/8eT2hCw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Oliver Neukum , Jiri Kosina , Sasha Levin Subject: [PATCH 6.19 560/844] HID: hid-pl: handle probe errors Date: Sat, 28 Feb 2026 12:27:53 -0500 Message-ID: <20260228173244.1509663-561-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Oliver Neukum [ Upstream commit 3756a272d2cf356d2203da8474d173257f5f8521 ] Errors in init must be reported back or we'll follow a NULL pointer the first time FF is used. Fixes: 20eb127906709 ("hid: force feedback driver for PantherLord USB/PS2 2in1 Adapter") Cc: stable@vger.kernel.org Signed-off-by: Oliver Neukum Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-pl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-pl.c b/drivers/hid/hid-pl.c index 3c8827081deae..dc11d5322fc0f 100644 --- a/drivers/hid/hid-pl.c +++ b/drivers/hid/hid-pl.c @@ -194,9 +194,14 @@ static int pl_probe(struct hid_device *hdev, const struct hid_device_id *id) goto err; } - plff_init(hdev); + ret = plff_init(hdev); + if (ret) + goto stop; return 0; + +stop: + hid_hw_stop(hdev); err: return ret; } -- 2.51.0