From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B0483EDF0B; Sat, 28 Feb 2026 17:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300523; cv=none; b=f3KqvE1LCZN6DYzP8EVFuZ/LtvlolPDfKUxE+PE+f+veAC/KFB1OMuMrpN4HQPFUAVv4aLKqz7OHgUgDIgocfhcpkf5ZHxyIwMbvd1k9oTwIjK2o4a9gp9iPRZCxoKBu1+yYscwZiayVAoMtqaoR6XoNwoUy37CgbNWuC8b0WdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300523; c=relaxed/simple; bh=rSjy6sL5hSnkfOLqqG7zQ/p/cFN7Q4rphq2o6bHZHPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hlam2VHmvWBW3Fgu+juD2Ool9nEBP/F3LhBscKFxl1ffr33kKCa2Diythsn+8gUivUy5qC8o7tu3LLvjn5QsJ39qrPLOjcZCItRheQAfcEnMPoDFN+Ys16ny9/HswDiq61yuobCP8AmYUFwbcecOOWlTYJQw+uAyAi9vg1Z8xog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XgaBsUgP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XgaBsUgP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7792C19423; Sat, 28 Feb 2026 17:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300523; bh=rSjy6sL5hSnkfOLqqG7zQ/p/cFN7Q4rphq2o6bHZHPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XgaBsUgPGFEwuUDvdatHwIkt0/zHTkmBnRfGtSSQMmLd36X3eclswQlqCni66cPCx 0pQqqfQBrMv4ZR8LO1OJj0exoMUECymPig6Ax09QJX5ZQZI4uL2iSlMFfQtxwRDRzj nK3Lw6d73X8bXvZ7LUHP5InseIBEwH52nApE6lzRhEbcoezcILVcpgmlVIfPp04YDE +rUw8ZxNJ6OBmVo8xc/U8L3JS2QpuLY2Kmk4jiNCEYxj4xuPxC13CObf8k+oPWr9HZ krM4LzX3g7+Z3XVDStBWVGdEhCqcA+yb2SYDP5Aomx8sUfgZ+aZ551ACzbAhW+/Ci/ hruLwskd0mkNA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?G=C3=BCnther=20Noack?= , Jiri Kosina , Sasha Levin Subject: [PATCH 6.19 562/844] HID: prodikeys: Check presence of pm->input_ep82 Date: Sat, 28 Feb 2026 12:27:55 -0500 Message-ID: <20260228173244.1509663-563-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Günther Noack [ Upstream commit cee8337e1bad168136aecfe6416ecd7d3aa7529a ] Fake USB devices can send their own report descriptors for which the input_mapping() hook does not get called. In this case, pm->input_ep82 stays NULL, which leads to a crash later. This does not happen with the real device, but can be provoked by imposing as one. Cc: stable@vger.kernel.org Signed-off-by: Günther Noack Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-prodikeys.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c index 74bddb2c3e82e..6e413df38358a 100644 --- a/drivers/hid/hid-prodikeys.c +++ b/drivers/hid/hid-prodikeys.c @@ -378,6 +378,10 @@ static int pcmidi_handle_report4(struct pcmidi_snd *pm, u8 *data) bit_mask = (bit_mask << 8) | data[2]; bit_mask = (bit_mask << 8) | data[3]; + /* robustness in case input_mapping hook does not get called */ + if (!pm->input_ep82) + return 0; + /* break keys */ for (bit_index = 0; bit_index < 24; bit_index++) { if (!((0x01 << bit_index) & bit_mask)) { -- 2.51.0