From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64D7C3F1BBF; Sat, 28 Feb 2026 17:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300538; cv=none; b=a637qSEkhdpUiTEO9c889kXwgrUVwR7KYxj2XvEPxsEEUJfs9BtT6Pm6JzQseK28TEx/k6hAzCt7Zfrpk10QDRRzJ3jYWSS33jsdz6UxvhF2Lxj2/vNZczXCq/LPPdFXJgsPVvs+GGkCqciwvtmf7JKcX7ol4etbvEwNVA9Qkt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300538; c=relaxed/simple; bh=W+gTu0H6JhHAnfGgON93jd0Og1WUEHEzknCmsh4qEWo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kj8BD5u66+nVl3XXM5VmOXd5uw6hj3/uy3JRTtH/PpQP0lnxRnkCJh0aCKoemWwMENdHH9JBD3YBP4KfmhmnwTIasGQHutopE1cyvS/3vT5h67h5qkgmogdNwo1VhwCr+2TYW1d4jfEV/KfXIBGmremcgEXT6ROW/O0Zpn2y4o4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tWpa6ZS5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tWpa6ZS5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 831E1C2BC9E; Sat, 28 Feb 2026 17:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300538; bh=W+gTu0H6JhHAnfGgON93jd0Og1WUEHEzknCmsh4qEWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tWpa6ZS5Tla6leVtOQUxJnfx3eFPJjO+Zc9uou2l2z3lopdKpddBAF1XW4p5e56+e TMb04hsmVfg9bQCpS1gHUezc58Se0MBzwJvp5CxHgG8tQ/prKjbkkluTC+zTLSN3// ElXT0nnf+EIEX97spEO71ZZTMcgr88K0Js/lt6mRkdBn2FgB6UaimUK5hijXobuTJa PiKYLVGdwR+buqCcfkXSb80cFg9P2Fu/WHxKSu8Flv4dToxTv6hRRWBar4/fjUWXhI hW2fiMHGyYHzXVj+MAZMQp4IsCgFQxThqCplZjEkS+F4C5nDwNDV2JMus7VXm9OSO6 QIlqbLIaH4igw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans de Goede , Mehdi Djait , Sakari Ailus , Hans Verkuil , Sasha Levin Subject: [PATCH 6.19 578/844] media: i2c: ov01a10: Fix analogue gain range Date: Sat, 28 Feb 2026 12:28:11 -0500 Message-ID: <20260228173244.1509663-579-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Hans de Goede [ Upstream commit 109e0feacaeca5ec2dd71d7d17c73232ce5cbddc ] A analogue maximum gain of 0xffff / 65525 seems unlikely and testing indeed shows that the gain control wraps-around at 16383, so set the maximum gain to 0x3fff / 16383. The minimum gain of 0x100 is correct. Setting bits 8-11 to 0x0 results in the same gain values as setting these bits to 0x1, with bits 0-7 still increasing the gain when going from 0x000 - 0x0ff in the exact same range as when going from 0x100 - 0x1ff. Fixes: 0827b58dabff ("media: i2c: add ov01a10 image sensor driver") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Tested-by: Mehdi Djait # Dell XPS 9315 Reviewed-by: Mehdi Djait [Sakari Ailus: mention analogue gain and update the limit from 4096.] Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/i2c/ov01a10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c index 0b1a1ecfffd0e..834ca46acb75f 100644 --- a/drivers/media/i2c/ov01a10.c +++ b/drivers/media/i2c/ov01a10.c @@ -48,7 +48,7 @@ /* analog gain controls */ #define OV01A10_REG_ANALOG_GAIN 0x3508 #define OV01A10_ANAL_GAIN_MIN 0x100 -#define OV01A10_ANAL_GAIN_MAX 0xffff +#define OV01A10_ANAL_GAIN_MAX 0x3fff #define OV01A10_ANAL_GAIN_STEP 1 /* digital gain controls */ -- 2.51.0