From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 024FB3F26DA; Sat, 28 Feb 2026 17:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300542; cv=none; b=ZzbRTFA7+OG8G5KTddKyRjn9kkMRZo+uAAHI5TRpOiCsPaBYyqvxHv1fwPQ48Jg9UkHqPk390mxz2sIWtSDTn0z2o0xwFbabKjtxSohSzX86uLaWXFU/4YxmM6Y0BAX55fNepr12/WiNwlF8vXTW1rOM1UeHf2Ct7TFbXGPGgWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300542; c=relaxed/simple; bh=ohQ9CucGTQ18a4Fp4lripQpC9sI6uM+kDC8e0VngH0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hRC1m1Rg6bbAHvGi6lP0rDvx7caSM4Klqriy3OUjn3eNLcrqDdnUZO6uE0VmpN8F/lfl0374wnrp/jbsiPZx1XzittVNE6/Optpio2qphB0lSsjF6rW0aSyZZvh9vVEm7MZ/ASR20upt6CRvbnN5Zm2S8ebxt6LJmVufl43alTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m8SzK2KF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m8SzK2KF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B48C5C116D0; Sat, 28 Feb 2026 17:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300541; bh=ohQ9CucGTQ18a4Fp4lripQpC9sI6uM+kDC8e0VngH0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m8SzK2KFbHx1pzmA04KHaaG1hWLwel9OX6UeCjIO5E4r9L6s86ftQkKYWRQVBYsdq ggbzs3tE7rES6IIUKeyh78FDjdODznSOULZeKryRNRU474rstqQuA1Jm3XN4F1pXGY 5nNgASmPf0VkcXIKVxEWkkjek9PUGTOg8qLlIrXeilWub4C8KQh57szk+Zx+D64WgR nBdZQ1QsqlMwViiVwtruImEGgkS8/JHNfB8/D+DSKtC3wkfRwBG+R9eSVyjf5PtI6u Wk0D0hsuuKscFWyVfAca3IPJ5erQSv2mbsfK5cPMGHOgE440E0ScpuqDskPWrpLEAS zYWVvEdC3AGgg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans de Goede , Mehdi Djait , Bingbu Cao , Sakari Ailus , Hans Verkuil , Sasha Levin Subject: [PATCH 6.19 581/844] media: i2c: ov01a10: Fix test-pattern disabling Date: Sat, 28 Feb 2026 12:28:14 -0500 Message-ID: <20260228173244.1509663-582-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Hans de Goede [ Upstream commit 409fb57c1b3deada4b8e153eb6344afb3c2dfb9c ] When the test-pattern control gets set to 0 (Disabled) 0 should be written to the test-pattern register, rather then doing nothing. Fixes: 0827b58dabff ("media: i2c: add ov01a10 image sensor driver") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Tested-by: Mehdi Djait # Dell XPS 9315 Reviewed-by: Mehdi Djait Reviewed-by: Bingbu Cao Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/i2c/ov01a10.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c index dd2b6d381175a..3ad516e4d3698 100644 --- a/drivers/media/i2c/ov01a10.c +++ b/drivers/media/i2c/ov01a10.c @@ -249,9 +249,8 @@ static const struct ov01a10_reg sensor_1280x800_setting[] = { static const char * const ov01a10_test_pattern_menu[] = { "Disabled", "Color Bar", - "Top-Bottom Darker Color Bar", - "Right-Left Darker Color Bar", - "Color Bar type 4", + "Left-Right Darker Color Bar", + "Bottom-Top Darker Color Bar", }; static const s64 link_freq_menu_items[] = { @@ -406,10 +405,8 @@ static int ov01a10_update_digital_gain(struct ov01a10 *ov01a10, u32 d_gain) static int ov01a10_test_pattern(struct ov01a10 *ov01a10, u32 pattern) { - if (!pattern) - return 0; - - pattern = (pattern - 1) | OV01A10_TEST_PATTERN_ENABLE; + if (pattern) + pattern |= OV01A10_TEST_PATTERN_ENABLE; return ov01a10_write_reg(ov01a10, OV01A10_REG_TEST_PATTERN, 1, pattern); } -- 2.51.0