From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B215F48BD45; Sat, 28 Feb 2026 17:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300542; cv=none; b=uP1I4ZQrBDNmXfXV0T2231okAjapcU8p2kL7DkCdZYhotGM6GImp+Qvm99ef0w7Zu8pVN3JNfMzxXVmbS1clgLJiPqJoZpyUYjjphuXwbgWKZ2by8zMvWKAgoaWmyY8vqsaOVMXEG0LDP8zFqZb3yXg6FL/q3KpSM4DlghAQxqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300542; c=relaxed/simple; bh=hk7Vevhy52GiAlAeBIvAyEeQV9/hNyiHwDwMTJV5wwg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u/nkVWCC0KzAn57ODeU4K3cSDKc8FJLHPna0OEEpPksxoeKto+ZK5qeCANJw0sKTW76X+Hj8xjIWDYkxQkgIqoYgbmv9d4YEj605p+MKqs6mA6poUCDqrljAhW58kQvErZWNYTn+msBC42/VcUDZsZ40hha7r8YwmJ5uARgaJew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tZtfb4pn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tZtfb4pn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1604C19424; Sat, 28 Feb 2026 17:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300542; bh=hk7Vevhy52GiAlAeBIvAyEeQV9/hNyiHwDwMTJV5wwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tZtfb4pnX2VqWSomaNrrqNCPWHabGZ0hzKMgdJoYFTQEjGWNHz7kHljwulPP4mS56 qTkcno6L8rJhAoCbizs0OntKJVj3hqmVR5xYoi3r7ATx5WPTApvBJ4CYS9R9AYGHxg tJdjyKndxLEXJVgsCNlEaehfqicjEf69aM7lh5C3nXX0HHjZl6bb2D4/DjayrhQDAS YXwcQZ0s5jedfikwlk2P1/aERuHpcgD9G8+/hdUROQCC1wUyR4UUWYWY8n3hTflGWF ET3KcDa3f9qEFgctPpbai8Y2PQzJFbSAYn2XsyhiQmbBY5afuOM13kLRoZDDgZaPIJ /vDqMPBXHaPNg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alper Ak , Bryan O'Donoghue , Bryan O'Donoghue , Hans Verkuil , Sasha Levin Subject: [PATCH 6.19 582/844] media: qcom: camss: vfe: Fix out-of-bounds access in vfe_isr_reg_update() Date: Sat, 28 Feb 2026 12:28:15 -0500 Message-ID: <20260228173244.1509663-583-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Alper Ak [ Upstream commit d965919af524e68cb2ab1a685872050ad2ee933d ] vfe_isr() iterates using MSM_VFE_IMAGE_MASTERS_NUM(7) as the loop bound and passes the index to vfe_isr_reg_update(). However, vfe->line[] array is defined with VFE_LINE_NUM_MAX(4): struct vfe_line line[VFE_LINE_NUM_MAX]; When index is 4, 5, 6, the access to vfe->line[line_id] exceeds the array bounds and resulting in out-of-bounds memory access. Fix this by using separate loops for output lines and write masters. Fixes: 4edc8eae715c ("media: camss: Add initial support for VFE hardware version Titan 480") Signed-off-by: Alper Ak Cc: stable@vger.kernel.org Reviewed-by: Bryan O'Donoghue Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/qcom/camss/camss-vfe-480.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-480.c b/drivers/media/platform/qcom/camss/camss-vfe-480.c index 4feea590a47bc..d73f733fde045 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-480.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-480.c @@ -202,11 +202,13 @@ static irqreturn_t vfe_isr(int irq, void *dev) writel_relaxed(status, vfe->base + VFE_BUS_IRQ_CLEAR(0)); writel_relaxed(1, vfe->base + VFE_BUS_IRQ_CLEAR_GLOBAL); - /* Loop through all WMs IRQs */ - for (i = 0; i < MSM_VFE_IMAGE_MASTERS_NUM; i++) { + for (i = 0; i < MAX_VFE_OUTPUT_LINES; i++) { if (status & BUS_IRQ_MASK_0_RDI_RUP(vfe, i)) vfe_isr_reg_update(vfe, i); + } + /* Loop through all WMs IRQs */ + for (i = 0; i < MSM_VFE_IMAGE_MASTERS_NUM; i++) { if (status & BUS_IRQ_MASK_0_COMP_DONE(vfe, RDI_COMP_GROUP(i))) vfe_buf_done(vfe, i); } -- 2.51.0