From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCBCF3F3272; Sat, 28 Feb 2026 17:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300544; cv=none; b=EDiKV9qL7m/Z+JkoHd4jf/V08zjZhu/88Jeqna40ubww7BisvFvlYmY2r03rGuPcsahWz/upb8utdhXhjdNrI+W6J1Hg6WggaE64Ee4POznsblTJOI//ZDB++aonqAQOsNikWkTMR+OBRtPIcl/z77J1Syzc3YSJNKEP9zDC3Xo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300544; c=relaxed/simple; bh=MoI6jtW1+tHn1I40ybjJ8CI+qmV3MhZTCStQS/hEr/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IT5E69ETvJrZVCe02EwYCkuJjet3pFltB+UZc2wkzDPRvDNFzPsJV2o0iymOsj77EnWqXtZnUbzgRsx1oq5LwKx8pxNF32clOFhKLUBZSHF7xtR3m9H9qNc+mIjHJnY5abDUbqni9IfcSEr3Y+wFFlsOgWV6NNLlzg352GCH+Pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ofBhoYwt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ofBhoYwt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCAB0C116D0; Sat, 28 Feb 2026 17:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300544; bh=MoI6jtW1+tHn1I40ybjJ8CI+qmV3MhZTCStQS/hEr/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ofBhoYwtPWWARYFiw9AtgUbhSh2ind272HvbzR/5wwoKkCSfipndWgllz2nv22B+V mrF9/W69LH6hSPtKNgKLm6cMfF4ovT5R89s904kmo2uEDGdxdJDug3l0zC12voQirH w8R3aNeb+JfuxFnBLbMYAPuM+TuRbwDTy3nevEQNojRMucAZf9fEV97P39x3HP7YLY ZstjMwESpRSLEkLiUlcrQw7biN/nwtVMUbNuQcWheZaqmSw9TxuwsbGIwKwonNzD68 mJWvLJGf21iQEhywMcYtzlVf8bwl/oxDP4EVYB1Q0/famp1K+RwEa6SwVUrywZ2qg2 Ie1F61PHtwfHw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jai Luthra , Jacopo Mondi , Sakari Ailus , Hans Verkuil , Sasha Levin Subject: [PATCH 6.19 584/844] media: i2c: ov5647: Initialize subdev before controls Date: Sat, 28 Feb 2026 12:28:17 -0500 Message-ID: <20260228173244.1509663-585-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jai Luthra [ Upstream commit eee13cbccacb6d0a3120c126b8544030905b069d ] In ov5647_init_controls() we call v4l2_get_subdevdata, but it is initialized by v4l2_i2c_subdev_init() in the probe, which currently happens after init_controls(). This can result in a segfault if the error condition is hit, and we try to access i2c_client, so fix the order. Fixes: 4974c2f19fd8 ("media: ov5647: Support gain, exposure and AWB controls") Cc: stable@vger.kernel.org Suggested-by: Jacopo Mondi Signed-off-by: Jai Luthra Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/i2c/ov5647.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c index e193fef4fcedf..f9fac858dc7ba 100644 --- a/drivers/media/i2c/ov5647.c +++ b/drivers/media/i2c/ov5647.c @@ -1420,15 +1420,15 @@ static int ov5647_probe(struct i2c_client *client) sensor->mode = OV5647_DEFAULT_MODE; - ret = ov5647_init_controls(sensor); - if (ret) - goto mutex_destroy; - sd = &sensor->sd; v4l2_i2c_subdev_init(sd, client, &ov5647_subdev_ops); sd->internal_ops = &ov5647_subdev_internal_ops; sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; + ret = ov5647_init_controls(sensor); + if (ret) + goto mutex_destroy; + sensor->pad.flags = MEDIA_PAD_FL_SOURCE; sd->entity.function = MEDIA_ENT_F_CAM_SENSOR; ret = media_entity_pads_init(&sd->entity, 1, &sensor->pad); -- 2.51.0