From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE631492195; Sat, 28 Feb 2026 17:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300622; cv=none; b=jor7D2ylwh27SKLzSDFNDZGxZe6zsbLiM6mOSC1CzMEL9t+wHYKKiWhLge71ZnInrcTTwqIbY2fu1RlOhi2d7dfkNwlbj124VKQaegGX52b6rdtmXnjuq/LP7iQ6iZF0m8mRQYb1/DFqA2mvtHpAJRd68d8ZoblhC8PYc+V6tqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300622; c=relaxed/simple; bh=Gyu1YR+zMuhecVW92199mZE4m5Eie57u1ZQCuNNabPQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HUrBYb/8xTG08vn/3cgh2N7Z9js4NjCX2JUEL/iV9NlRdPvZs8U0KFmS6hVOYlU8QNelIyRKfIYqWY6qJ1LONvk79OJzXkFBWYd+Y9eEu3aauXBnoyLGs9gEPU4z5uxccSTEnVjBOFdEEmQnEvOGywbLEi9/wfHo8Tt/MXizU2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CKnq4Q+P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CKnq4Q+P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCEA3C2BC87; Sat, 28 Feb 2026 17:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300622; bh=Gyu1YR+zMuhecVW92199mZE4m5Eie57u1ZQCuNNabPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CKnq4Q+PWaIKAx02K8DiFn52SLmQtCB5B7QpZ+vJTOAn4iHoZY8xD0HI22Bjou+EW +/JP0hoLUY/YsXYZgrAhr+PscL0kKTaw0PrcBA/iGtndTLFPHMoblgSfOt60wOgqa1 FiJIbKzzJstZQpgU+sihIheDo4OvbvWCsCzKOkGWFTGg88NBMNbGjZYVpMAdTwfXab chAXQHQsut42C7HKtRJ0IN3IIHZHMb9aMMrmcX1ZGIDt5hhN8MBxghlxIBE+AVqTAF cceP1rPFonNHHvRZ27yUHWIZ4XosrZtYvT/XhwLhbSavRz+8f+QPxsfXVLzEc6Vv5O brVd/9ei+shyg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Janne Grunau , Sven Peter , Neal Gompa , Lee Jones , Sasha Levin Subject: [PATCH 6.19 663/844] mfd: macsmc: Initialize mutex Date: Sat, 28 Feb 2026 12:29:36 -0500 Message-ID: <20260228173244.1509663-664-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Janne Grunau [ Upstream commit 414f65d6736342c77d4ec5e7373039f4a09250dd ] Initialize struct apple_smc's mutex in apple_smc_probe(). Using the mutex uninitialized surprisingly resulted only in occasional NULL pointer dereferences in apple_smc_read() calls from the probe() functions of sub devices. Cc: stable@vger.kernel.org Fixes: e038d985c9823 ("mfd: Add Apple Silicon System Management Controller") Signed-off-by: Janne Grunau Reviewed-by: Sven Peter Reviewed-by: Neal Gompa Link: https://patch.msgid.link/20251231-macsmc-mutex_init-v2-1-5818c9dc9b29@jannau.net Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/macsmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/macsmc.c b/drivers/mfd/macsmc.c index e3893e255ce5e..3015e8d36d6e5 100644 --- a/drivers/mfd/macsmc.c +++ b/drivers/mfd/macsmc.c @@ -413,6 +413,7 @@ static int apple_smc_probe(struct platform_device *pdev) if (!smc) return -ENOMEM; + mutex_init(&smc->mutex); smc->dev = &pdev->dev; smc->sram_base = devm_platform_get_and_ioremap_resource(pdev, 1, &smc->sram); if (IS_ERR(smc->sram_base)) -- 2.51.0