From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C3E403DD6; Sat, 28 Feb 2026 17:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300632; cv=none; b=qsi9lJfvWJ8Lu22yddEVIKk0Y196JfBsh/7C9so5y+W0MMvxMA0z7/lQaADcuykrAXEalCRb7HFN0D+uvuXxo7UX+SJQwhdTnjJTPrvNcCBh2NaSti5DB+Oy0hvhIF1drmAd0xaNMk1toWDQIvTF6dQX4zkG0pe3avjdbd+JAE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300632; c=relaxed/simple; bh=0MEsXN5AH0lIkGP598z4YSPXisf20/DS+OzSmpQsEhc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qAS6ol4GL9nGeFQ79ZAYZ6Irx9mw70XBzRafB+IsKyZvTQmcR0WaUR7rRdH59abCjZpgPhfZtckuvBfMzgIQvjVm/NVdkqqCSMx58Gpl0uxgiSbCPjMgN2bqr0zmagDAHDGPt1EnLuz8thU58hr/gkcbRI5Sze8/58wcqMa2Fg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iAksRyvw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iAksRyvw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEA04C19423; Sat, 28 Feb 2026 17:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300632; bh=0MEsXN5AH0lIkGP598z4YSPXisf20/DS+OzSmpQsEhc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iAksRyvwMwKttINUd7CfTZXGcZLNoOm8IhJJRWtFfo3x9uQglDyGpcR/DUCR4+One DuEsx7MEel9CivDAdh7KHHwfW4ZW6RyZeJVbhHvXTmRjMUB505BOtO71ogPvbnItim Wrg0Kood+fB1hV14quYryoDSqqdtoFNPMpcaZIZZGh+ag8gAfy+tfJWycy6cM1KMlj 2REzXapawqd0nJBpKQzoutntboGWxhIIdI+m/6Fr9A0sisxk7d/NuaIIO5thb/2Md4 7/+cEKuyHKZNcqa84wey9P/lCpyR1PRpAy4Eu0g4H5MUl594nMgMpIHfiGB3wvrQBa FvTcPZRTP0VDw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Johan Hovold , Mikko Perttunen , Miaoqian Lin , Stephen Boyd , Sasha Levin Subject: [PATCH 6.19 673/844] clk: tegra: tegra124-emc: fix device leak on set_rate() Date: Sat, 28 Feb 2026 12:29:46 -0500 Message-ID: <20260228173244.1509663-674-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit da61439c63d34ae6503d080a847f144d587e3a48 ] Make sure to drop the reference taken when looking up the EMC device and its driver data on first set_rate(). Note that holding a reference to a device does not prevent its driver data from going away so there is no point in keeping the reference. Fixes: 2db04f16b589 ("clk: tegra: Add EMC clock driver") Fixes: 6d6ef58c2470 ("clk: tegra: tegra124-emc: Fix missing put_device() call in emc_ensure_emc_driver") Cc: stable@vger.kernel.org # 4.2: 6d6ef58c2470 Cc: Mikko Perttunen Cc: Miaoqian Lin Signed-off-by: Johan Hovold Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/tegra/clk-tegra124-emc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra124-emc.c b/drivers/clk/tegra/clk-tegra124-emc.c index 0f6fb776b2298..5f1af6dfe7154 100644 --- a/drivers/clk/tegra/clk-tegra124-emc.c +++ b/drivers/clk/tegra/clk-tegra124-emc.c @@ -197,8 +197,8 @@ static struct tegra_emc *emc_ensure_emc_driver(struct tegra_clk_emc *tegra) tegra->emc_node = NULL; tegra->emc = platform_get_drvdata(pdev); + put_device(&pdev->dev); if (!tegra->emc) { - put_device(&pdev->dev); pr_err("%s: cannot find EMC driver\n", __func__); return NULL; } -- 2.51.0