From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F3A405994; Sat, 28 Feb 2026 17:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300641; cv=none; b=VT7bwNPRNrGKK2PdO1zDp9qBuraWME5IzMgI8N0K3dV+2HvGegVepp9DQgHytgeshsbhP3UcGKitLXCAjRisCVKWviTKMcOjxfVVZCBJR+HF1Z5V4kdUC/eX7t1U38ojqLJCAiwCiI86o0aBOMYpxxFDMxA/lRwe8EYZcd0NY3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300641; c=relaxed/simple; bh=lMjFxD+80hL9B3iCB39/KHPwCwDV9RytnNQRPLnUyDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ODKrAmyHwNSEXXTJYv8J6uS6DJoqdYTln8lakWtMIsJhh2SyZ7vSKFPDx7gmEx88pi+9uiCS968yhwT1mHwRc2nBSFT0shcW4vmjVs8MHxsjM6/JwoNhmlUQVD+bMZalc1VY5IEbwbYFVa/morswnvnmWcbeWNTybw++YVlt87M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=buFKmVpK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="buFKmVpK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B67C6C116D0; Sat, 28 Feb 2026 17:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300641; bh=lMjFxD+80hL9B3iCB39/KHPwCwDV9RytnNQRPLnUyDo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=buFKmVpKlTEyDMScUNBjjRVdx9eYtVBp2ujfSZ/n4dKuCInrCJcLt3qIn4oXze92b 8XJ0SJGoOlkLUVtYxkVTGv1QGJ2gh+HlQvOyAFM1Ww9unE37jTkstMOJeVsxYNjuLI THCysuly/g7UT2hKtEsBkZq/GsSLWth5PjNCuifvtQbIy6TsEMpnyPcrxyiHnskh8r iCehAXnBVo7e+Fg1R7UrMRW+IqLOhcuao4pJvg6NrrV5xedLhennigbaLkH2WwbJf0 bLqVu9jCFRt9o0Z7U80uTJmijfcwBdOHEbeF3twnW2jf9EVGdq3H+fwJF6SsBGLPKH LvxgF51HzBa9A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Darrick J. Wong" , Christoph Hellwig , Sasha Levin Subject: [PATCH 6.19 682/844] xfs: fix remote xattr valuelblk check Date: Sat, 28 Feb 2026 12:29:55 -0500 Message-ID: <20260228173244.1509663-683-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: "Darrick J. Wong" [ Upstream commit bd3138e8912c9db182eac5fed1337645a98b7a4f ] In debugging other problems with generic/753, it turns out that it's possible for the system go to down in the middle of a remote xattr set operation such that the leaf block entry is marked incomplete and valueblk is set to zero. Make this no longer a failure. Cc: # v4.15 Fixes: 13791d3b833428 ("xfs: scrub extended attribute leaf space") Signed-off-by: "Darrick J. Wong" Reviewed-by: Christoph Hellwig Signed-off-by: Sasha Levin --- fs/xfs/scrub/attr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/xfs/scrub/attr.c b/fs/xfs/scrub/attr.c index ef299be01de5e..a0878fdbcf386 100644 --- a/fs/xfs/scrub/attr.c +++ b/fs/xfs/scrub/attr.c @@ -338,7 +338,10 @@ xchk_xattr_entry( rentry = xfs_attr3_leaf_name_remote(leaf, idx); namesize = xfs_attr_leaf_entsize_remote(rentry->namelen); name_end = (char *)rentry + namesize; - if (rentry->namelen == 0 || rentry->valueblk == 0) + if (rentry->namelen == 0) + xchk_da_set_corrupt(ds, level); + if (rentry->valueblk == 0 && + !(ent->flags & XFS_ATTR_INCOMPLETE)) xchk_da_set_corrupt(ds, level); } if (name_end > buf_end) -- 2.51.0