From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 404B136309F; Sat, 28 Feb 2026 17:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300668; cv=none; b=JIob8LDdJWGiRtvp8lObklDNz1PbXPjf+5pK2UssV5NebsiDLHY955yQrJM4NOVfDUmzQyjSEHhNldhL6IQnSi5qmyOmDjohBUdmyxRowmC3B8JOsXhhKfpG+075k8Ejrg+dpYHMKg+X+eABRUjNXfIefoG5x4+2cUhvTTSl2zw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300668; c=relaxed/simple; bh=u2kxPBOwOLkphVOpPpRhqeDwmrywy8m72tKElHpBxYI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gbT8h/q+0BYXD7z6OR6Tnjs3B2LqugUlt2iD0JHwiRDhWCSfzcNS65CmkdeKJkz1uIeDaDBqmPsk59c9H4fwW8Zq9Z0mQxNGhx9kaiDgTNAQtSwuIANJvkaQsNAIdHBbNVeWIiWsLgEQ1wg4gtI4AT99bpQW23V+kRwNb7bb2RE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Am6GDfwG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Am6GDfwG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40AA4C19423; Sat, 28 Feb 2026 17:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300668; bh=u2kxPBOwOLkphVOpPpRhqeDwmrywy8m72tKElHpBxYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Am6GDfwGOSFMtxWCx4iAnNPewW4BLx/DF0voA0hv4d5lQYwyUze1YBLn9RiJOrqTy 4aIydoRxXTFlg4046gCtXMXaridYZThgpdS6Ik5+svajHlbC/e+gHNs9GS4qZsPIpX iNDiSblcl2nGPytSFlSa4sAEWm5OEgAhGnCcfF0vmSg4vgDMQ0a6IHJEoaEiMWKjDk trkdlv51yo7vxGFCmQ8l2ilZsdnG8Q1v0qL9YMaIEA0ckTX9zzO+YBl+9hUvt5vCf5 2PMQ2OpSX4AyqawjcmQkbLqkBsaEfPKbsOkywjZq9VbcDLj1VAPwcxCjcN1u86H+o4 4oh1e5bemzSFg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Haoxiang Li , Dan Carpenter , Su Hui , "Christophe Leroy (CS GROUP)" , Ioana Ciornei , Sasha Levin Subject: [PATCH 6.19 705/844] bus: fsl-mc: fix an error handling in fsl_mc_device_add() Date: Sat, 28 Feb 2026 12:30:18 -0500 Message-ID: <20260228173244.1509663-706-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Haoxiang Li [ Upstream commit 52f527d0916bcdd7621a0c9e7e599b133294d495 ] In fsl_mc_device_add(), device_initialize() is called first. put_device() should be called to drop the reference if error occurs. And other resources would be released via put_device -> fsl_mc_device_release. So remove redundant kfree() in error handling path. Fixes: bbf9d17d9875 ("staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver") Cc: stable@vger.kernel.org Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@stanley.mountain/ Signed-off-by: Su Hui Suggested-by: Christophe Leroy (CS GROUP) Signed-off-by: Haoxiang Li Reviewed-by: Ioana Ciornei Link: https://lore.kernel.org/r/20260124102054.1613093-1-lihaoxiang@isrc.iscas.ac.cn Signed-off-by: Christophe Leroy (CS GROUP) Signed-off-by: Sasha Levin --- drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c index a97baf2cbcdd5..eb7b6c0ba9e7c 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -909,11 +909,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc, return 0; error_cleanup_dev: - kfree(mc_dev->regions); - if (mc_bus) - kfree(mc_bus); - else - kfree(mc_dev); + put_device(&mc_dev->dev); return error; } -- 2.51.0