From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 667D140D099; Sat, 28 Feb 2026 17:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300677; cv=none; b=lZ/GVvJxC9mLhwqMIkXRh/KUlq+DVupoGzXKQZCTAh6dUJJU2fJLup2Ynzy4sqmOVxWht7g21dMRNKdCekhuKx4UsKUHR0tFEGfnRLFZ1MDWiveMhQplPBv19E4v1Npp6oOw8M/ybiZ6qJrRueD4ZYHYIVwHEv/ai6OQ1mS+l34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300677; c=relaxed/simple; bh=NxGOfkvRJjHXt727XexuhxLaF0DzYjTi8pPM5h4Zgzk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SkOQYvUrCC0ZvUqcwFszyd8yadWgoNmNcJDXsVz6QcM1uW5TX5YALaP7L8TzkUsZWtlVV/n/PqZhIW0ztcoUvDPvlOnaOlwZHmPvpn5EIWrjIALCgotUCDtN91y6xBcH/EatPZa4Pzm/2M/hlcITNq8qzATLCO6N9kchIq1ro3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TPGtURPG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TPGtURPG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A46EC116D0; Sat, 28 Feb 2026 17:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300677; bh=NxGOfkvRJjHXt727XexuhxLaF0DzYjTi8pPM5h4Zgzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TPGtURPGXmZE1P3JHY3E6Sr3n/2Sff2k+sWVduAPwT6njkS/8343PzcYQAMU8gCZj vhm+yVpfO29cnNHNvYVATLI+Jg1hb6qxr5lMI9+96T5g4wiCqDza7w/eP+sntDtHHI hJrefV53DqCP/Wii90nh6K7uUYmT94782bDtxzmGbtI4EAjRwD723RyJd9GtJmPtnZ IHIIoRkiba+gj+1h2DAcxYfb1j2eN5YvQtqE9r1H4Yp1dSBsfA2qmu0Yk3PohBPI8I Dmw+OIaa2bitMzyO0MuXflnDaSxN+LdGhCBE1jzNSWGa87uu2lV07AG7j6HYjgL51q rRK38cT0xDmRw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Antoniu Miclaus , Andy Shevchenko , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 6.19 714/844] iio: gyro: itg3200: Fix unchecked return value in read_raw Date: Sat, 28 Feb 2026 12:30:27 -0500 Message-ID: <20260228173244.1509663-715-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Antoniu Miclaus [ Upstream commit b79b24f578cdb2d657db23e5fafe82c7e6a36b72 ] The return value from itg3200_read_reg_s16() is stored in ret but never checked. The function unconditionally returns IIO_VAL_INT, ignoring potential I2C read failures. This causes garbage data to be returned to userspace when the read fails, with no error reported. Add proper error checking to propagate the failure to callers. Fixes: 9dbf091da080 ("iio: gyro: Add itg3200") Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/gyro/itg3200_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/gyro/itg3200_core.c b/drivers/iio/gyro/itg3200_core.c index cd8a2dae56cd9..bfe95ec1abda9 100644 --- a/drivers/iio/gyro/itg3200_core.c +++ b/drivers/iio/gyro/itg3200_core.c @@ -93,6 +93,8 @@ static int itg3200_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_RAW: reg = (u8)chan->address; ret = itg3200_read_reg_s16(indio_dev, reg, val); + if (ret) + return ret; return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: *val = 0; -- 2.51.0