From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13C58414933; Sat, 28 Feb 2026 17:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300713; cv=none; b=fTglwRMw0Xhi5/181rLZFTXYa5uXN8TIxPTdToan37xIcjoJ6e/hBe3fRiuDqRAQbxwTesguAOTHx4keTQeB9FNMYV3+5cYRWTWGbFz1p5vuYCxTDBSyQphpqY35j3BRr7ha0RZzf2RZMFliojJWr+O1ZexSq+JhTzW7AyH7R9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300713; c=relaxed/simple; bh=SUf0qdZ6P+PWNQj5j9osWjREKs8+YSw/TMis7sPESjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dPy5m01BYowQfv995/We/UceJmx2NrgIASTATuWFtq21E2zsKV/QtMe52Yvq5cCLUQShn4fA493mbYeX0iB9bq86/ncIUvwlJPkMPCN79ghII4y/hJPSu4NCyd38Rq2j4FFfIS7eT8dIVgjEycE+yHimo+tAzzVbcFmtGYCRXJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FzUNoCTL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FzUNoCTL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42C13C19424; Sat, 28 Feb 2026 17:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300712; bh=SUf0qdZ6P+PWNQj5j9osWjREKs8+YSw/TMis7sPESjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FzUNoCTLLmlQVqPXgq5bgq6qnA1CH9srDaTgU3sZ4IMfcPc6+aHnolocayUR4l2zu CEYYEJquAaSU4zmKzfdl73dGyDmQw+PrYLwVKYk9Bn+FSK0z3OBugLNkcpQLwtJtMZ +unjD6RyLEJW7lTs45R8OyvUceUkepGLUzXw2tBcf/E8o79nMLKJauR4lAK0TDMJcr sTW/HtrowmKkUYNv6rxKNPpMZhsiT7PTE3lxO4urVFPP7Qr8oFM59ZXG8tpI2vMuf2 imR5bjpcmV9Xz7IA/9F7wGZxi9OYLIF2AZO5UEdqKP+JycnVEpcYX1C3m+rG2LoRZB 0p2sfcSl3HvgQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniel Hodges , Eric Dumazet , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.19 748/844] tipc: fix RCU dereference race in tipc_aead_users_dec() Date: Sat, 28 Feb 2026 12:31:01 -0500 Message-ID: <20260228173244.1509663-749-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Daniel Hodges [ Upstream commit 6a65c0cb0ff20b3cbc5f1c87b37dd22cdde14a1c ] tipc_aead_users_dec() calls rcu_dereference(aead) twice: once to store in 'tmp' for the NULL check, and again inside the atomic_add_unless() call. Use the already-dereferenced 'tmp' pointer consistently, matching the correct pattern used in tipc_aead_users_inc() and tipc_aead_users_set(). Fixes: fc1b6d6de220 ("tipc: introduce TIPC encryption & authentication") Cc: stable@vger.kernel.org Reviewed-by: Eric Dumazet Signed-off-by: Daniel Hodges Link: https://patch.msgid.link/20260203145621.17399-1-git@danielhodges.dev Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/tipc/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c index 970db62bd029b..a3f9ca28c3d53 100644 --- a/net/tipc/crypto.c +++ b/net/tipc/crypto.c @@ -460,7 +460,7 @@ static void tipc_aead_users_dec(struct tipc_aead __rcu *aead, int lim) rcu_read_lock(); tmp = rcu_dereference(aead); if (tmp) - atomic_add_unless(&rcu_dereference(aead)->users, -1, lim); + atomic_add_unless(&tmp->users, -1, lim); rcu_read_unlock(); } -- 2.51.0