From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD55B4968FF; Sat, 28 Feb 2026 17:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300778; cv=none; b=ep5MshJ02Sk0qPuVe2mwE6SIbdNewB+ukyZ9s3jay75Rc9wVFr7ETe+6sWaJSOiJtTQFQ/ccvHCc7FWrqf4rl2XDXFo0Ih+xIcr3eH7qLEtvYOWhRWr1OMls87WckAh+lJrmaHroUzbTq17fnQVUfp463OJZ9QAxXCTp6dB1C68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300778; c=relaxed/simple; bh=dKiC0icjXP1TlfS6TPltT1637LnsHXjHUdGIYuZnsoM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kkbuzn2bWtLterXx0HDLRB60jgMcnJeqpVZt/9vleddz5q2oOCUj8UnqlDfCW/q0Bu/OhQeJxzkv+BFxYyoXE1EDtXmGPDYALEzDmAivfET5SyjlgKFbeUFJkBWurOHNP3/BGp18HOrq3TpRIb1dUAdQHfbtb4iSWiF8Bc/FYOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y7vIzwTK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y7vIzwTK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E46DBC19423; Sat, 28 Feb 2026 17:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300778; bh=dKiC0icjXP1TlfS6TPltT1637LnsHXjHUdGIYuZnsoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y7vIzwTKi9Rcfg/LwZBNOUdkwO1YPz7/vKq8LLvmRjh+4CQkExiWT+5KNprdy/g2A UUYClyq4EgD48wHon4k8/jCHZgjaUJO0RVbUIOQeswVNaNPPlmHb+UVdvC5eGkfPCF sxdFF8sDOyfJdrBriSt13NUjrsT0crLqwbcVOhz4gXEYKIFAs1Uscb54aSVFq/24eI 2Ke7kRV34O6Txwgzv5lOVx3/zabAi7DDBYLJXsfI6nE/KQ6/tZ2joTXedxje+c1jlP SnQ8zRfF473/nh14ArLXzYZKRuCdz4L5kjFJ1+LzeiLK996C6+TxCj/ekE3mjTbdUt EwDebFFYoKavQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Fourier , Helge Deller , Sasha Levin Subject: [PATCH 6.19 809/844] fbdev: vt8500lcdfb: fix missing dma_free_coherent() Date: Sat, 28 Feb 2026 12:32:02 -0500 Message-ID: <20260228173244.1509663-810-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Thomas Fourier [ Upstream commit 88b3b9924337336a31cefbe99a22ed09401be74a ] fbi->fb.screen_buffer is allocated with dma_alloc_coherent() but is not freed if the error path is reached. Fixes: e7b995371fe1 ("video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb") Cc: Signed-off-by: Thomas Fourier Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/vt8500lcdfb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c index b08a6fdc53fd2..85c7a99a7d648 100644 --- a/drivers/video/fbdev/vt8500lcdfb.c +++ b/drivers/video/fbdev/vt8500lcdfb.c @@ -369,7 +369,7 @@ static int vt8500lcd_probe(struct platform_device *pdev) if (fbi->palette_cpu == NULL) { dev_err(&pdev->dev, "Failed to allocate palette buffer\n"); ret = -ENOMEM; - goto failed_free_io; + goto failed_free_mem_virt; } irq = platform_get_irq(pdev, 0); @@ -432,6 +432,9 @@ static int vt8500lcd_probe(struct platform_device *pdev) failed_free_palette: dma_free_coherent(&pdev->dev, fbi->palette_size, fbi->palette_cpu, fbi->palette_phys); +failed_free_mem_virt: + dma_free_coherent(&pdev->dev, fbi->fb.fix.smem_len, + fbi->fb.screen_buffer, fbi->fb.fix.smem_start); failed_free_io: iounmap(fbi->regbase); failed_free_res: -- 2.51.0