From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F06962594B9 for ; Sun, 1 Mar 2026 01:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772328110; cv=none; b=jzCuhZjSsIKj/oY9Mx99i/1fXPZyS8vFyy4VdqUzA/tngYQctdWAQnaWpudIDgEXwBqnKswl4G5FBC75/9KBiX6ojAOyr3WL4PT/V+SB335BNKKJqyMseH3n78vq+gMQkBk7PRPTb8lOeB6mOp3LHxgopFQBASfNz/ggj1NmSr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772328110; c=relaxed/simple; bh=xaSk2/WdX7yBhYgJKw3lUPdnq8PaRx4WEfChMomWNpg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MHwFCiBTfHngG9fdGro2eBYdbxtOuffIpvXsbMjO/jraRmQGTA2Magzzs0h4AmSvt8GgE9zAyBtOJLXkjfSrcfhTz3KxU4z3bWfsepvgerDTF9R6KBuROn1VigLviUI++Ts1kXjCDmhO7luULp+edBFTAV1o0BKTrQZD3lvSdOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nhkec9dw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nhkec9dw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7404CC19421; Sun, 1 Mar 2026 01:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772328109; bh=xaSk2/WdX7yBhYgJKw3lUPdnq8PaRx4WEfChMomWNpg=; h=From:To:Cc:Subject:Date:From; b=nhkec9dwHWo8SXdDZvvNR66zVUhjmhbJlW/6BPtZlHffTMRrltgJfl1sNiK4zuYxS TfvIfsET4SSoUyUmhNWhxogQnHiiOXJrZXRNEREPjFOXMasFT04co/UaAuT3aDYOvK kOZI3S6QO7+CTYvaZjtvQwSNHN3FCEHFE0eX88qYpj4CTCuB+LxKbiA/mb5P+u+l5Y 8ssfDN46YC+gHDrSq7gOUoWWROWwwLwwsLSdoGYzWpCqqB7zVyT9XK6PYASVo1085s dNTjG/JLD7sQc0jah1iCuKTVY9KujJf32NksI4Ydy6zk2NEySAxkC5wgkM+PNj+4ks 15Uy15BahVmgg== From: Sasha Levin To: stable@vger.kernel.org, joonwonkang@google.com Cc: Jassi Brar Subject: FAILED: Patch "mailbox: Prevent out-of-bounds access in fw_mbox_index_xlate()" failed to apply to 6.12-stable tree Date: Sat, 28 Feb 2026 20:21:48 -0500 Message-ID: <20260301012148.1677862-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.12-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From fcd7f96c783626c07ee3ed75fa3739a8a2052310 Mon Sep 17 00:00:00 2001 From: Joonwon Kang Date: Wed, 26 Nov 2025 06:22:50 +0000 Subject: [PATCH] mailbox: Prevent out-of-bounds access in fw_mbox_index_xlate() Although it is guided that `#mbox-cells` must be at least 1, there are many instances of `#mbox-cells = <0>;` in the device tree. If that is the case and the corresponding mailbox controller does not provide `fw_xlate` and of_xlate` function pointers, `fw_mbox_index_xlate()` will be used by default and out-of-bounds accesses could occur due to lack of bounds check in that function. Cc: stable@vger.kernel.org Signed-off-by: Joonwon Kang Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 2acc6ec229a45..617ba505691d3 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -489,12 +489,10 @@ EXPORT_SYMBOL_GPL(mbox_free_channel); static struct mbox_chan *fw_mbox_index_xlate(struct mbox_controller *mbox, const struct fwnode_reference_args *sp) { - int ind = sp->args[0]; - - if (ind >= mbox->num_chans) + if (sp->nargs < 1 || sp->args[0] >= mbox->num_chans) return ERR_PTR(-EINVAL); - return &mbox->chans[ind]; + return &mbox->chans[sp->args[0]]; } /** -- 2.51.0