From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0ECC2D8796; Sun, 1 Mar 2026 01:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772328876; cv=none; b=FHuYgDld6msuaO2fBfw14aPRMjDc4Zu8Qgt8NnGnRTd8RNGCzF1fHM1rnRBrOfdeWhZs1knBrPdEX33LmrBH/snO218BUsoZXOr1SVuI9nrCyq/K+0zUvt1LW8vEqWR8yOvRH6xpqs8JoCejuGd11Oucd7mpJWGtuzX8LdWU2mI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772328876; c=relaxed/simple; bh=Tk9YFBsJwtWrt4yHWfRJjqSxr3CKFnJOP0I5MzrAtAo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R5iZiqCCmUAIFus/zedY4nZnbquqbt7PtsHvotqTnQyVwrWemGIyIAuznhRDbHN6tGW3sqkJ9hvU6/fvitIjpc3654Ox+mVlzKG7BoDpiE9+h5bob7WLR+gTNO6y1kTGQaLp6BQjqus4IEoFQl83UELem2BRFPOw4As7Ua86bs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LbAAqu4e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LbAAqu4e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8C1EC19421; Sun, 1 Mar 2026 01:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772328876; bh=Tk9YFBsJwtWrt4yHWfRJjqSxr3CKFnJOP0I5MzrAtAo=; h=From:To:Cc:Subject:Date:From; b=LbAAqu4eRzo6zeEcVwOU3UvqIcQov+bVgCVNk2V3vkIuqcsxZ7mZ5jXvOMvJ7p5/v ak1Em+hlHUSBGVhbf/+m9QXw7jh02tPHZ7L2FR7w/sluP9k9vKSK1gdYirFQFuVkyT Hd8Dwv44VAd6D7dDs820h4OMmKPKLkrOlpzE54VQMohNpClBBc+oPYiwPjHiKiPWxW NzJcEJqlP0l0DgENU9aB95uqCwPYPuHCZSvokd61ZhUy47EeoM5iKe9vJgfL3klJB3 L5EdryFpNTh2FxMWwP2NIuSBgsF1VggsLGHQgaDNOj2d+3+Cd96H9TEhFSkQq21zR9 GnHNw09EypIbg== From: Sasha Levin To: stable@vger.kernel.org, mmaddireddy@nvidia.com Cc: Manivannan Sadhasivam , Bjorn Helgaas , Niklas Cassel , Frank Li , linux-pci@vger.kernel.org Subject: FAILED: Patch "PCI: endpoint: Fix swapped parameters in pci_{primary/secondary}_epc_epf_unlink() functions" failed to apply to 6.6-stable tree Date: Sat, 28 Feb 2026 20:34:34 -0500 Message-ID: <20260301013434.1694129-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 8754dd7639ab0fd68c3ab9d91c7bdecc3e5740a8 Mon Sep 17 00:00:00 2001 From: Manikanta Maddireddy Date: Thu, 8 Jan 2026 11:57:47 +0530 Subject: [PATCH] PCI: endpoint: Fix swapped parameters in pci_{primary/secondary}_epc_epf_unlink() functions struct configfs_item_operations callbacks are defined like the following: int (*allow_link)(struct config_item *src, struct config_item *target); void (*drop_link)(struct config_item *src, struct config_item *target); While pci_primary_epc_epf_link() and pci_secondary_epc_epf_link() specify the parameters in the correct order, pci_primary_epc_epf_unlink() and pci_secondary_epc_epf_unlink() specify the parameters in the wrong order, leading to the below kernel crash when using the unlink command in configfs: Unable to handle kernel paging request at virtual address 0000000300000857 Mem abort info: ... pc : string+0x54/0x14c lr : vsnprintf+0x280/0x6e8 ... string+0x54/0x14c vsnprintf+0x280/0x6e8 vprintk_default+0x38/0x4c vprintk+0xc4/0xe0 pci_epf_unbind+0xdc/0x108 configfs_unlink+0xe0/0x208+0x44/0x74 vfs_unlink+0x120/0x29c __arm64_sys_unlinkat+0x3c/0x90 invoke_syscall+0x48/0x134 do_el0_svc+0x1c/0x30prop.0+0xd0/0xf0 Fixes: e85a2d783762 ("PCI: endpoint: Add support in configfs to associate two EPCs with EPF") Signed-off-by: Manikanta Maddireddy [mani: cced stable, changed commit message as per https://lore.kernel.org/linux-pci/aV9joi3jF1R6ca02@ryzen] Signed-off-by: Manivannan Sadhasivam Signed-off-by: Bjorn Helgaas Reviewed-by: Niklas Cassel Reviewed-by: Frank Li Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260108062747.1870669-1-mmaddireddy@nvidia.com --- drivers/pci/endpoint/pci-ep-cfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c index 43feb6139fa36..8b392a8363bb1 100644 --- a/drivers/pci/endpoint/pci-ep-cfs.c +++ b/drivers/pci/endpoint/pci-ep-cfs.c @@ -68,8 +68,8 @@ static int pci_secondary_epc_epf_link(struct config_item *epf_item, return 0; } -static void pci_secondary_epc_epf_unlink(struct config_item *epc_item, - struct config_item *epf_item) +static void pci_secondary_epc_epf_unlink(struct config_item *epf_item, + struct config_item *epc_item) { struct pci_epf_group *epf_group = to_pci_epf_group(epf_item->ci_parent); struct pci_epc_group *epc_group = to_pci_epc_group(epc_item); @@ -132,8 +132,8 @@ static int pci_primary_epc_epf_link(struct config_item *epf_item, return 0; } -static void pci_primary_epc_epf_unlink(struct config_item *epc_item, - struct config_item *epf_item) +static void pci_primary_epc_epf_unlink(struct config_item *epf_item, + struct config_item *epc_item) { struct pci_epf_group *epf_group = to_pci_epf_group(epf_item->ci_parent); struct pci_epc_group *epc_group = to_pci_epc_group(epc_item); -- 2.51.0