From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB2F1243969; Sun, 1 Mar 2026 01:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772329273; cv=none; b=A/nEDRfAmHQr99RIuldteoYYAJuWCmTPP3jJVtQsqvvuNxGss7OpQK8vRtFC3eAOFmMFZtXffyVE/MawP9TiDIJBwJAogbzfHsjAOOo7DoexS2wY1ohhW5Jd0ATClom5cYMwkpyyq2R96oCVksfOau47m4hLx7xLFE6dy3MYRVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772329273; c=relaxed/simple; bh=7MXlaiWThIA7iA8+nr5mmaG/dMzmfS6mlcgwr5tL5tE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GKECOw21psFLpCmgmDi3I63WXmql9+bgdhcZvThVnoh5lxSncaTDJyqUiRNtpr4tuXjnFpXPpw310ngnPskz+pjRdmyYSlpPxw8jKeI3y4luPmb9pWERUPJvgNzzK/pYRqZvOIfXldTMS4Z7zugSR4mD3gFq+BLWYN7Ud43++l0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=luKNZuCI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="luKNZuCI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33AF3C19421; Sun, 1 Mar 2026 01:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772329273; bh=7MXlaiWThIA7iA8+nr5mmaG/dMzmfS6mlcgwr5tL5tE=; h=From:To:Cc:Subject:Date:From; b=luKNZuCI7k/OJbTx/WUL8iXPDqFoZa3DfVtmW49VbzfOsRxU6b/J9526kWrhx95YQ 5poESsk7E58mgfbqMld1MgpMJ3nQSyUehNpneWEEWdOJgo3fZwjYZ15HZfpHoXhwjO BXCc5faGzY+gEOvKhuX38oqzZV5GuD1XVW4ootkg0qctJD16Cn+e/bW5rF99KZIu4O h0YiPNy2v2A+QlIn93r+lxD+NlbvnfnqmS4IRxlkacaT6m1Ekpn2PLTh25yUn3nMNB LPxaaRAKPe3fi74tjitnftjEYAL5lLRxLOxnm/J3pUknpjaob/jsT99GV/HNnZ4Pcl wXN0EdoyAfTkA== From: Sasha Levin To: stable@vger.kernel.org, ssrane_b23@ee.vjti.ac.in Cc: syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com, Hans Verkuil , linux-media@vger.kernel.org Subject: FAILED: Patch "media: radio-keene: fix memory leak in error path" failed to apply to 6.1-stable tree Date: Sat, 28 Feb 2026 20:41:11 -0500 Message-ID: <20260301014112.1702729-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From b8bf939d77c0cd01118e953bbf554e0fa15e9006 Mon Sep 17 00:00:00 2001 From: Shaurya Rane Date: Thu, 27 Nov 2025 00:34:10 +0530 Subject: [PATCH] media: radio-keene: fix memory leak in error path Fix a memory leak in usb_keene_probe(). The v4l2 control handler is initialized and controls are added, but if v4l2_device_register() or video_register_device() fails afterward, the handler was never freed, leaking memory. Add v4l2_ctrl_handler_free() call in the err_v4l2 error path to ensure the control handler is properly freed for all error paths after it is initialized. Reported-by: syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=a41b73dce23962a74c72 Fixes: 1bf20c3a0c61 ("[media] radio-keene: add a driver for the Keene FM Transmitter") Cc: stable@vger.kernel.org Signed-off-by: Shaurya Rane Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-keene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/radio/radio-keene.c b/drivers/media/radio/radio-keene.c index f3b57f0cb1ec4..c133305fd0194 100644 --- a/drivers/media/radio/radio-keene.c +++ b/drivers/media/radio/radio-keene.c @@ -338,7 +338,6 @@ static int usb_keene_probe(struct usb_interface *intf, if (hdl->error) { retval = hdl->error; - v4l2_ctrl_handler_free(hdl); goto err_v4l2; } retval = v4l2_device_register(&intf->dev, &radio->v4l2_dev); @@ -384,6 +383,7 @@ static int usb_keene_probe(struct usb_interface *intf, err_vdev: v4l2_device_unregister(&radio->v4l2_dev); err_v4l2: + v4l2_ctrl_handler_free(&radio->hdl); kfree(radio->buffer); kfree(radio); err: -- 2.51.0