From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B261DF271; Sun, 1 Mar 2026 01:46:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772329592; cv=none; b=kmjJtIjzYRalOqEwinmyvKFkkPlLf9ecJpqlimdt+AYWPcbeDFyACRsAM4z2jQip1MQncgKVIKAk4iwz6a6HvcjbfsMTqAt4JNJQsObfLfFfgyPE9h3ip3rfoCPhSlXqdqcXVkfkI6qUDE9fsPvX0auAyCUlP+woUP+iFV1kqn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772329592; c=relaxed/simple; bh=29njihTX7Hp1LuY9VaK6skv569j4qG2NKkkXpuEgJNE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IPQq6nydJF6NDtpd5Er9f81JI+fhKT5yma1ewi5mq7sdHD0P5sgaBtjm39dCEGTwAatrFvIu1BSfhVIzNONRRuP9iy+P5t2a4oOHG7AAZn3iFvcniw/y8uryEtWLI7Vf8rYgljQSj7pszJUje0jvWImBoahygEB1rKOR9UrhdEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BeA+Lvi+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BeA+Lvi+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F7A7C19421; Sun, 1 Mar 2026 01:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772329592; bh=29njihTX7Hp1LuY9VaK6skv569j4qG2NKkkXpuEgJNE=; h=From:To:Cc:Subject:Date:From; b=BeA+Lvi+X7ws1Rfd9ex0Yllw4rsrlVm6oezcn0ma5crE0XX1c8wkJOfCqSeEWMWZ/ TYFGuAsRwhxz+cmSEdAS7BHVQLD9qOrRCe0VoNz0Qt2iKXEhjWMW2nDd5lyqYvhGWg RaxwpgpKtajvckDrY8HW9KEi2fTAfIJwkbywMP0WafM6IL4Yq2KiW+kAXKS1g0SMKq 1YDkpkhxD46E1qfwK/6m00wWh9dwJfJ0EayDcnecMP/JIRLF51y9p53bK9A1iYZuxo nsk57VdZT84I2+QGQ0IFBkTpm0pr7T0JUx3eH2dhrm4HbrBX3s2PKfZND94G/AL+h3 YPGh+er7iP7FQ== From: Sasha Levin To: stable@vger.kernel.org, metze@samba.org Cc: Steve French , Tom Talpey , Long Li , Namjae Jeon , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, Steve French Subject: FAILED: Patch "smb: client: let smbd_post_send_negotiate_req() use smbd_post_send()" failed to apply to 6.1-stable tree Date: Sat, 28 Feb 2026 20:46:30 -0500 Message-ID: <20260301014630.1709488-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 5b1c6149657af840a02885135c700ab42e6aa322 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 22 Jan 2026 18:16:59 +0100 Subject: [PATCH] smb: client: let smbd_post_send_negotiate_req() use smbd_post_send() The server has similar logic and it makes sure that request->wr is used instead of a stack struct ib_send_wr send_wr. This makes sure send_done can see request->wr.send_flags as the next commit will check for IB_SEND_SIGNALED Cc: # 6.18.x Cc: Steve French Cc: Tom Talpey Cc: Long Li Cc: Namjae Jeon Cc: linux-cifs@vger.kernel.org Cc: samba-technical@lists.samba.org Signed-off-by: Stefan Metzmacher Signed-off-by: Steve French --- fs/smb/client/smbdirect.c | 32 +++++++------------------------- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c index 20faa6d7f514d..88fefb901c27f 100644 --- a/fs/smb/client/smbdirect.c +++ b/fs/smb/client/smbdirect.c @@ -35,6 +35,10 @@ static void enqueue_reassembly( static struct smbdirect_recv_io *_get_first_reassembly( struct smbdirect_socket *sc); +static int smbd_post_send(struct smbdirect_socket *sc, + struct smbdirect_send_batch *batch, + struct smbdirect_send_io *request); + static int smbd_post_recv( struct smbdirect_socket *sc, struct smbdirect_recv_io *response); @@ -1021,7 +1025,6 @@ static int smbd_ia_open( static int smbd_post_send_negotiate_req(struct smbdirect_socket *sc) { struct smbdirect_socket_parameters *sp = &sc->parameters; - struct ib_send_wr send_wr; int rc; struct smbdirect_send_io *request; struct smbdirect_negotiate_req *packet; @@ -1052,33 +1055,12 @@ static int smbd_post_send_negotiate_req(struct smbdirect_socket *sc) request->sge[0].length = sizeof(*packet); request->sge[0].lkey = sc->ib.pd->local_dma_lkey; - ib_dma_sync_single_for_device( - sc->ib.dev, request->sge[0].addr, - request->sge[0].length, DMA_TO_DEVICE); - - request->cqe.done = send_done; - - send_wr.next = NULL; - send_wr.wr_cqe = &request->cqe; - send_wr.sg_list = request->sge; - send_wr.num_sge = request->num_sge; - send_wr.opcode = IB_WR_SEND; - send_wr.send_flags = IB_SEND_SIGNALED; - - log_rdma_send(INFO, "sge addr=0x%llx length=%u lkey=0x%x\n", - request->sge[0].addr, - request->sge[0].length, request->sge[0].lkey); - - atomic_inc(&sc->send_io.pending.count); - rc = ib_post_send(sc->ib.qp, &send_wr, NULL); + rc = smbd_post_send(sc, NULL, request); if (!rc) return 0; - /* if we reach here, post send failed */ - log_rdma_send(ERR, "ib_post_send failed rc=%d\n", rc); - atomic_dec(&sc->send_io.pending.count); - - smbd_disconnect_rdma_connection(sc); + if (rc == -EAGAIN) + rc = -EIO; dma_mapping_failed: smbd_free_send_io(request); -- 2.51.0