From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 328D8262FEC; Sun, 1 Mar 2026 01:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330389; cv=none; b=MR8Iw7KsghsikWFmGuKA6EN+J1p+SZ5J1x8Nz/YarF3wMc4TqhFiwpqHcxo+T4mjFyB+jynxA8XZVyQXun9FIEYGUPbTXFtBtjhJBMvlmOqvoGCp2sccVAZbyqZX3Q8HzrofEkA5vm2gYplFSMl4lIxWxKeM9thkqGZSZLcg2QU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330389; c=relaxed/simple; bh=4//siI1gkvZKxirz1w809X4fINe88q2vYRDNWZOzVq0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=JYDT4y3BFrItdfkQKfOhZlqJELXUVnyxpfTjX3V/MrD42HH8b3soQujNFj8723E1jBkm/wZljXNbi+886NwIgfIXo+FjKBh4VucEl4zGP+B0S0XkXt7s9oiylTez18H8JkfqqOF0Qpe4Qqxkc2MLP1OYvyWdgVRKprMl15E6no8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V0oGMMaB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V0oGMMaB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9019EC19421; Sun, 1 Mar 2026 01:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772330389; bh=4//siI1gkvZKxirz1w809X4fINe88q2vYRDNWZOzVq0=; h=From:To:Cc:Subject:Date:From; b=V0oGMMaBjfjVr6BCcGaw43eyV7EE1UsgH/2IUhSqfMaUvVLdvE6h3flfd9/dsl8Th jByCTpZSn2zsYAEdvIXr4f8FkSUMJsoQS/SpyXdwznnXpuDY19wPhK/T8K3eQidAyy r11++1f4ngDvgJ09o0Hb4hkxfcHoHZAemZaJmbGBb7XMR2R1tiybVF+05aoOUF7rDT 9DgKcTyUsqZKDf0yh6xR73GJy7fx7eJocGaGs6IgsUlUTwqraiEAUHqQWLB+jDAquM Lt2tnjnQpu3XdEl0Z2WielztewpUTlazVxm9vmstQdAXgwgi0FS09K0FJLajDdmsnB 0JrJb5gvuue/g== From: Sasha Levin To: stable@vger.kernel.org, gnoack@google.com Cc: Jiri Kosina , linux-input@vger.kernel.org Subject: FAILED: Patch "HID: logitech-hidpp: Check maxfield in hidpp_get_report_length()" failed to apply to 5.10-stable tree Date: Sat, 28 Feb 2026 20:59:47 -0500 Message-ID: <20260301015947.1725656-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 1547d41f9f19d691c2c9ce4c29f746297baef9e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=BCnther=20Noack?= Date: Fri, 9 Jan 2026 13:25:58 +0100 Subject: [PATCH] HID: logitech-hidpp: Check maxfield in hidpp_get_report_length() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Do not crash when a report has no fields. Fake USB gadgets can send their own HID report descriptors and can define report structures without valid fields. This can be used to crash the kernel over USB. Cc: stable@vger.kernel.org Signed-off-by: Günther Noack Signed-off-by: Jiri Kosina --- drivers/hid/hid-logitech-hidpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index e871f1729d4b3..d0a38eff9cfa8 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -4314,7 +4314,7 @@ static int hidpp_get_report_length(struct hid_device *hdev, int id) re = &(hdev->report_enum[HID_OUTPUT_REPORT]); report = re->report_id_hash[id]; - if (!report) + if (!report || !report->maxfield) return 0; return report->field[0]->report_count + 1; -- 2.51.0