From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A8019CD19 for ; Sun, 1 Mar 2026 02:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330419; cv=none; b=Hx3TFDAVZ9Bkqq5kuYcURVlm+SCe2I7TmO5JAFRrnuzxwYFAAjaP/9py8sqTE0AX41u2rxbnyjy7VxjIby8LL4+8kP0LhMBZ/fXW/PNMTKC2udBmypjV2hX8rdYIDVq30vmA3ug/aCu6K62EqmoaQaWz6HX9anWdYc2kLbzevGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330419; c=relaxed/simple; bh=Y/Pkvml/BQFLsC8/UcnckneX/hvtllzBtpUcn+L9wlE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HbMpHZY+FR0Me2lHo1eQvjMEH7Xg3Kf0PFpSNTqLQdcWR/vHpS4Qn4+wJneCTQCjKv7ad33EuJJRgRDE0kZmyD9ojJU8BHw6tyKQAj8HC3PPZ1bO1Ziqhj2W/4ZX/mOdsVQam0yspdk1EJxkHk6r8oTC0bNmBqZvtk5VUdnOUxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OtIkpI9s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OtIkpI9s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14B61C19421; Sun, 1 Mar 2026 02:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772330419; bh=Y/Pkvml/BQFLsC8/UcnckneX/hvtllzBtpUcn+L9wlE=; h=From:To:Cc:Subject:Date:From; b=OtIkpI9sQnK2bSb6mwfrURTTHPFkDl0L1IriRaAJc1AQdgdcqKoKRQzCSbf+yooLh GJcvqmrVzvtoWemtTv4ktY1LKTbNQZZ+IRppFJ7MYvlXwTgXnCRJ3PXGVJUOQTO5be ei94Xx/Y29N3/PBZUEqe8eK9ARcdk49KR63pn9mKbfCIzXUvEtHfAYZ3ubQUbX/JGQ Von5IsiPn8L56cB/Wjs0i5TZ5pE9/1THZMZAZp9mGr07Bwg4TnU6RFZqpB8hzt4k3/ exTiDuhsRx64EINn0BKJEEwA1rJ3r3rvn3vL2Ah93ihg2u7+nRm/if7ReBagao6T84 pt8gSym8Pn/ow== From: Sasha Levin To: stable@vger.kernel.org, vulab@iscas.ac.cn Cc: Nishanth Menon , linux-arm-kernel@lists.infradead.org Subject: FAILED: Patch "soc: ti: pruss: Fix double free in pruss_clk_mux_setup()" failed to apply to 5.10-stable tree Date: Sat, 28 Feb 2026 21:00:17 -0500 Message-ID: <20260301020017.1726306-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 80db65d4acfb9ff12d00172aed39ea8b98261aad Mon Sep 17 00:00:00 2001 From: Wentao Liang Date: Tue, 13 Jan 2026 01:47:16 +0000 Subject: [PATCH] soc: ti: pruss: Fix double free in pruss_clk_mux_setup() In the pruss_clk_mux_setup(), the devm_add_action_or_reset() indirectly calls pruss_of_free_clk_provider(), which calls of_node_put(clk_mux_np) on the error path. However, after the devm_add_action_or_reset() returns, the of_node_put(clk_mux_np) is called again, causing a double free. Fix by returning directly, to avoid the duplicate of_node_put(). Fixes: ba59c9b43c86 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Link: https://patch.msgid.link/20260113014716.2464741-1-vulab@iscas.ac.cn Signed-off-by: Nishanth Menon --- drivers/soc/ti/pruss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c index 038576805bfa0..0fd59c73f585d 100644 --- a/drivers/soc/ti/pruss.c +++ b/drivers/soc/ti/pruss.c @@ -366,12 +366,10 @@ static int pruss_clk_mux_setup(struct pruss *pruss, struct clk *clk_mux, ret = devm_add_action_or_reset(dev, pruss_of_free_clk_provider, clk_mux_np); - if (ret) { + if (ret) dev_err(dev, "failed to add clkmux free action %d", ret); - goto put_clk_mux_np; - } - return 0; + return ret; put_clk_mux_np: of_node_put(clk_mux_np); -- 2.51.0