From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB48A230D0F; Sun, 1 Mar 2026 02:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330436; cv=none; b=HqT/kZtsmx6m7qig3xLjGuF4s+ixS+nFFldz3KjewnmSo7Us1XTNQSUz3YgONfudzsH2vI4QSijUwiYMxt1TnzRX6dA3gu2baV+WTSEEJZX4dvltsiZc9Io1sTPkEqRR/ravk+2er4rSUlSbiXjtEgRY2v7KgZMr4dRF93kCfO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330436; c=relaxed/simple; bh=nMNwJneYSJJWlKX9/dJvaD9YOK313JNikiHGlpdJzA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KIHTX2D4jXSRpCwV6z1w+nrZ6Z5ug26dBbRImAm9ItBR7APT5cQPnXeQkkAw89Bl2ADjIKOty72RbaQfywdThuMpLDk1FP1eJjDO/lCUJ7rd1C4IaJXrDh2sRddQlKJMcOQ4OQNLg7t4A66/eK4M97u6gD0kgPNueCP4Vk3M94Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B6Gy8nK2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B6Gy8nK2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9814C19421; Sun, 1 Mar 2026 02:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772330436; bh=nMNwJneYSJJWlKX9/dJvaD9YOK313JNikiHGlpdJzA4=; h=From:To:Cc:Subject:Date:From; b=B6Gy8nK2vq1JFg9bchsLEthKhO3Wqf40KtQNHoXP0xa+ioKTvvRAjuUC8bESyQ5/z zuWbeNYQoJh1vbaNxBZR8BOPdZVCO6EI74n3p/xlNeOs22YfNLTGl4QwNUDZ7moYQ0 kOjOGZSykHb+o3QzQViaHAw7SESQyEW5HLaSQ1EhcU3D7jilIUPD1NZp6TEqLkdKRh igzM5H8kouaoU6z27KcpZXxfMQwmwX4XbUQpZ2YjJJwdkFP+TxJCEOCKoVS9d7kfIO bosl1xs9Fslsf2nmuok2wv4ldQwcC0YV9rtNkTSycQ6cNfV7BUysx7qnXpfShH5V1q jOm4LM2On44hg== From: Sasha Levin To: stable@vger.kernel.org, hanguidong02@gmail.com Cc: Qiu-ji Chen , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki (Intel)" , driver-core@lists.linux.dev Subject: FAILED: Patch "driver core: enforce device_lock for driver_match_device()" failed to apply to 5.10-stable tree Date: Sat, 28 Feb 2026 21:00:34 -0500 Message-ID: <20260301020034.1726691-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From dc23806a7c47ec5f1293aba407fb69519f976ee0 Mon Sep 17 00:00:00 2001 From: Gui-Dong Han Date: Wed, 14 Jan 2026 00:28:43 +0800 Subject: [PATCH] driver core: enforce device_lock for driver_match_device() Currently, driver_match_device() is called from three sites. One site (__device_attach_driver) holds device_lock(dev), but the other two (bind_store and __driver_attach) do not. This inconsistency means that bus match() callbacks are not guaranteed to be called with the lock held. Fix this by introducing driver_match_device_locked(), which guarantees holding the device lock using a scoped guard. Replace the unlocked calls in bind_store() and __driver_attach() with this new helper. Also add a lock assertion to driver_match_device() to enforce this guarantee. This consistency also fixes a known race condition. The driver_override implementation relies on the device_lock, so the missing lock led to the use-after-free (UAF) reported in Bugzilla for buses using this field. Stress testing the two newly locked paths for 24 hours with CONFIG_PROVE_LOCKING and CONFIG_LOCKDEP enabled showed no UAF recurrence and no lockdep warnings. Cc: stable@vger.kernel.org Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220789 Suggested-by: Qiu-ji Chen Signed-off-by: Gui-Dong Han Fixes: 49b420a13ff9 ("driver core: check bus->match without holding device lock") Reviewed-by: Danilo Krummrich Reviewed-by: Greg Kroah-Hartman Reviewed-by: Rafael J. Wysocki (Intel) Link: https://patch.msgid.link/20260113162843.12712-1-hanguidong02@gmail.com Signed-off-by: Danilo Krummrich --- drivers/base/base.h | 9 +++++++++ drivers/base/bus.c | 2 +- drivers/base/dd.c | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index 430cbefbc97ff..677320881af15 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -182,9 +182,18 @@ void device_set_deferred_probe_reason(const struct device *dev, struct va_format static inline int driver_match_device(const struct device_driver *drv, struct device *dev) { + device_lock_assert(dev); + return drv->bus->match ? drv->bus->match(dev, drv) : 1; } +static inline int driver_match_device_locked(const struct device_driver *drv, + struct device *dev) +{ + guard(device)(dev); + return driver_match_device(drv, dev); +} + static inline void dev_sync_state(struct device *dev) { if (dev->bus->sync_state) diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 9eb7771706f01..331d750465e2f 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -263,7 +263,7 @@ static ssize_t bind_store(struct device_driver *drv, const char *buf, int err = -ENODEV; dev = bus_find_device_by_name(bus, NULL, buf); - if (dev && driver_match_device(drv, dev)) { + if (dev && driver_match_device_locked(drv, dev)) { err = device_driver_attach(drv, dev); if (!err) { /* success */ diff --git a/drivers/base/dd.c b/drivers/base/dd.c index bea8da5f8a3a9..ed3a076248169 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -1180,7 +1180,7 @@ static int __driver_attach(struct device *dev, void *data) * is an error. */ - ret = driver_match_device(drv, dev); + ret = driver_match_device_locked(drv, dev); if (ret == 0) { /* no match */ return 0; -- 2.51.0