From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2761190664 for ; Sun, 1 Mar 2026 02:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330455; cv=none; b=Zd3QzGAFbDAV8/cA7kBZL8FsysbIdp5TzvPPro3/OfMhHRRkq4hV3Q1K0/8KZ0KpUYp6AcIAZiWfDmAcWsmbTjgD026+74ULCAtwynjDfljJLZPlTM+PWasl23snKLZ6fLesWD0ZOw+7prizE/N1PqpUe1cmLyO08UrYx18h3eg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330455; c=relaxed/simple; bh=sfpiuxyMyhOg55SUk2UWzh/KW0zWseTzzIvgv+ooAW8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JDmSThnNvHqlIH0GqfN5OqcxmD3w8HPkvPCiqIepDEgWBxiaCDLVz+ukamHTFLd9amn5EcgvpnPO7h1t1PG/yApEbpjlRvFcDwD9TST63DF5K2mAB6bLDJl9Irg4dplMpksAZ7zs9zq3CszvqCo5HqJ2oq9fVImQ8Fmq7bc5Gak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aoW/duLL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aoW/duLL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47B66C19421; Sun, 1 Mar 2026 02:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772330455; bh=sfpiuxyMyhOg55SUk2UWzh/KW0zWseTzzIvgv+ooAW8=; h=From:To:Cc:Subject:Date:From; b=aoW/duLLEm6YO69hDkLZjJrGYGH9OTKlShLpn7t8/W7uMvag7NzjN4CnCKdg2HpwV BCa++IxYMj5XuwjWCfB2PP23UZ89iZJR1Nsn965ujSuAC6AxSLv5ZFdt3Odr+uvsjm nad+Wb2igYgojkzOU/jlktZhlITbqhDE5YpU1CStLGaO8hwQ4TqQ7Vv4v11vX7BadE xWlbDh8vwK0g8nJIt52jNEbSa0ZXw2FtdP4y5uYaGDmmWTexsXtsYDDauF3uB3nYdn /s3oKGLlltPZXAldE29UZBAbTenZYZWTTnOfhMvP49ljiZYd2rR6hJ1FrOtQbQlfVH 5XGcZ+xDPFAbQ== From: Sasha Levin To: stable@vger.kernel.org, joonwonkang@google.com Cc: Jassi Brar Subject: FAILED: Patch "mailbox: Prevent out-of-bounds access in fw_mbox_index_xlate()" failed to apply to 5.10-stable tree Date: Sat, 28 Feb 2026 21:00:53 -0500 Message-ID: <20260301020054.1727820-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From fcd7f96c783626c07ee3ed75fa3739a8a2052310 Mon Sep 17 00:00:00 2001 From: Joonwon Kang Date: Wed, 26 Nov 2025 06:22:50 +0000 Subject: [PATCH] mailbox: Prevent out-of-bounds access in fw_mbox_index_xlate() Although it is guided that `#mbox-cells` must be at least 1, there are many instances of `#mbox-cells = <0>;` in the device tree. If that is the case and the corresponding mailbox controller does not provide `fw_xlate` and of_xlate` function pointers, `fw_mbox_index_xlate()` will be used by default and out-of-bounds accesses could occur due to lack of bounds check in that function. Cc: stable@vger.kernel.org Signed-off-by: Joonwon Kang Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 2acc6ec229a45..617ba505691d3 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -489,12 +489,10 @@ EXPORT_SYMBOL_GPL(mbox_free_channel); static struct mbox_chan *fw_mbox_index_xlate(struct mbox_controller *mbox, const struct fwnode_reference_args *sp) { - int ind = sp->args[0]; - - if (ind >= mbox->num_chans) + if (sp->nargs < 1 || sp->args[0] >= mbox->num_chans) return ERR_PTR(-EINVAL); - return &mbox->chans[ind]; + return &mbox->chans[sp->args[0]]; } /** -- 2.51.0