From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26C22673AA; Sun, 1 Mar 2026 02:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330570; cv=none; b=bPVlPOCpaMrYOQ9JkKqn76aNhaBS5zproC2oPxLecu6XGkRQEF/nsxk328ELpKGJOSl2LKtxm566HCaK0UBONqaELxZEHW1QcWXo3yd8fSQOZaWiCMq5gR2/FFNrwWwR5YaNCIMV7jJQq+IdkKIADZttWxSUiqy0bnS2MWQwwG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772330570; c=relaxed/simple; bh=syPIQXWwhj6eiG9ZKlOOFdyQ/tRTgqffREQT43QIoJs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BUKdkOu8FFi8WTqyZhplMput0XxLmA/OJsTubA1DcgpoBsZXJ0OO9RIz843ZKL6bXDKTbj/M9usFLvhc7QhFE/GscqaRUJfAOKaNFIQW5PM2NWFxu8ySxjsGxGkFo/bunvBNIedTsehL2CiQ/t4hGJF7awQ/OveIgOem3KMSJ04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PSK+5Arn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PSK+5Arn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09DCBC19421; Sun, 1 Mar 2026 02:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772330570; bh=syPIQXWwhj6eiG9ZKlOOFdyQ/tRTgqffREQT43QIoJs=; h=From:To:Cc:Subject:Date:From; b=PSK+5ArnCNIHrBrrg39YznHx9/OVeJhBhqH+fh4flCxYn0l9w4dpOnxhu+vSNd3Z7 J5NuPen0XAZVhORdNx3+OGpF3mtBDBFDycs4UUe45e0HyY/2lZssK/+LFACrf0VNjL UvFaEHBBDyB13no7EAg6FUg0vokqIILMipD4qMkuQXpgetE7BgWSNGb+nH2in/JsG5 4SOdbgWWAq0QPph+XLAjNSyoY530iRfg9oWCyhuAYioDr6SlaN3p8hABurUvM6y00y uCIG0J0zyi3NMzEcDP7Mv28VaqL9LtUwubeZuegtKmfhCkhbDaNFj25BmUSgdZfkoc VYKz/3U2MRvbw== From: Sasha Levin To: stable@vger.kernel.org, aha310510@gmail.com Cc: Inki Dae , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: FAILED: Patch "drm/exynos: vidi: fix to avoid directly dereferencing user pointer" failed to apply to 5.10-stable tree Date: Sat, 28 Feb 2026 21:02:48 -0500 Message-ID: <20260301020248.1730726-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From d4c98c077c7fb2dfdece7d605e694b5ea2665085 Mon Sep 17 00:00:00 2001 From: Jeongjun Park Date: Mon, 19 Jan 2026 17:25:52 +0900 Subject: [PATCH] drm/exynos: vidi: fix to avoid directly dereferencing user pointer In vidi_connection_ioctl(), vidi->edid(user pointer) is directly dereferenced in the kernel. This allows arbitrary kernel memory access from the user space, so instead of directly accessing the user pointer in the kernel, we should modify it to copy edid to kernel memory using copy_from_user() and use it. Cc: Signed-off-by: Jeongjun Park Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 480c99a8f9f75..9709c07e5d8f4 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -252,13 +252,27 @@ int vidi_connection_ioctl(struct drm_device *drm_dev, void *data, if (vidi->connection) { const struct drm_edid *drm_edid; - const struct edid *raw_edid; + const void __user *edid_userptr = u64_to_user_ptr(vidi->edid); + void *edid_buf; + struct edid hdr; size_t size; - raw_edid = (const struct edid *)(unsigned long)vidi->edid; - size = (raw_edid->extensions + 1) * EDID_LENGTH; + if (copy_from_user(&hdr, edid_userptr, sizeof(hdr))) + return -EFAULT; - drm_edid = drm_edid_alloc(raw_edid, size); + size = (hdr.extensions + 1) * EDID_LENGTH; + + edid_buf = kmalloc(size, GFP_KERNEL); + if (!edid_buf) + return -ENOMEM; + + if (copy_from_user(edid_buf, edid_userptr, size)) { + kfree(edid_buf); + return -EFAULT; + } + + drm_edid = drm_edid_alloc(edid_buf, size); + kfree(edid_buf); if (!drm_edid) return -ENOMEM; -- 2.51.0