From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0572FFFA5 for ; Sun, 1 Mar 2026 02:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772333002; cv=none; b=prC8EbMkmz7e7+hGxlZbf2yWaIi0TrwNygLm8FO14ZSZffYxk+y1RkZKXQI6Rg7YSOI5xgiHiDqSbwskqsY3Ic9r//LXI7Cfn/28A4c4khXBWk5uUbcKc4wbz7adp8M7IHFufqWq5dqSBmSGvRTtxXdJ2cWHAyaoIOyM6BQNJ8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772333002; c=relaxed/simple; bh=StiYaJg5TnIgR97jqI7sw8c91dqPU9OEJIf6O1a7rcc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YBGbNTktSq6UynuFedzImtt07I+265JtkFC5zrqleZGXJlqMMx7sUM+e6jzyGywpQgQFsaOrZGBUeGIXx+VS4qOedDLpRwSWK2Pc2bwvaXHFE/sESp/utoqBBEL979EHMAl5OZRZ1TQsPRzsDIyAUB0+xYDRWog3JxWvd0wq6q4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fk+/fKfa; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fk+/fKfa" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so1092444a12.3 for ; Sat, 28 Feb 2026 18:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772333000; x=1772937800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k/4+K7t1AmwyZhD8tmPo2E9QsgNK7fdWts0ll2jiHOI=; b=fk+/fKfadFRQ7MYgVDN1VuVfl4regnAJCFFnKsnVI6r492dj1JHXFRU4eg4nF1DnfX Yejzn8vJxjB9ZRgtAQM6GbRb0H5XgmWZk7XhDfs2CEUFjNExW2nQeOnOdG95VvIA92UL mbfZDSpSfP+g/sXHSgCK6xRxdgYXcUmT9fc6kJv9vwn/IsqP2GNTyIhsBw0/fSXiF4fz P17VaME0dRXVtQeQIRiama8JI8O+jWqqxq8GGRFKr/81fgM7D+mS/TCjXyDPJDTUNVdN vAEwp+EeCbW1EGte+BnFhO6V09fE+E9mOqsN4noP8ILIRhWi4zBKgsb1EwThyvmWjzMS MMiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772333000; x=1772937800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=k/4+K7t1AmwyZhD8tmPo2E9QsgNK7fdWts0ll2jiHOI=; b=wx7L+lq7SDxMUcoGYRXLBmbE4RVKD5HR374RdCAePL4b7dpDObIgaqLP7HskinIoPO T4nTaTJnZIBbPIAlSNz3rk4agzwwNQ2BvJZGqanHTcwzCtYplwIwgETMdsFMCzXvmSkm 0ZncRivP6f5FhLWUHFjscbhc1kD1ShvBKju1hWdITcbkFuWABtWFHSrKGDPAU0eWWEyz 2L+qF4KoI80JdkNfkYcLj8iXZHAmexjRq0WdxTFm/j8EgWeSLaoTzh6ce4SeCQA82jIT DpBhFvaF5gu9qkRVrxGMrVCWMiSaQqfgibfUE8arQwYA9YmsZLU/0j0xL1QzTQYCgMSD 6rag== X-Gm-Message-State: AOJu0Yy8blfdLQmaE4JmBQ0B1CLOYiqdfcfXiTEov97g9vlb7810IVcg 09Tgg6yNFwZ6TmPQS+8krKmYcvljTh4VRqxHdyRfSOeBJPwvqXJApYKCFBPjAaKJ X-Gm-Gg: ATEYQzy5ch6ve5EJ5WHNRDSI51LFx7F4YgANtVpPLX+wp7n0XK2eZBAenRV0bnOPnoN bnjPLkY19gTPXlSGleC+pyjp3e63/tt8gKjcMRuLNjJxiNsBfaQjGUQoFl6DTAvQvu7vhL5KJDw 0gmC7Td6DzqoT8nr9b9Vujl50GEq5064gmZNGQE5QWIcagefDzaxkyeyVk38QJBW/oVKTc1fMXr 91iefYh538QxvtUZ1ef3aCg992sn/UogZMZof01fZKMRMDfRMChQlALh9WB+NUO0r8qCDQ+KVzU lgH5gIothcSSBQ8gP4fvXjrExuHTDkwH4CNEQMIAI7ielNsHREuw/ZyOwqkY2/wnpQo5eWJE3TS WZS3h5/SvCkyT1YSnY2ak8lamdlOVBIiuVpyfKr4dZ7BXB3OF2Sln36zutY8CFx4Rc6LL1ORHHn ochllWvyFaqL0swldpN4H+CNXIMjcGqlZeDSgea8CQXMsJ+3RygAumBko= X-Received: by 2002:a05:6a00:b42:b0:81f:9c54:65df with SMTP id d2e1a72fcca58-8274da052f5mr6154918b3a.50.1772333000173; Sat, 28 Feb 2026 18:43:20 -0800 (PST) Received: from localhost.localdomain ([222.109.75.221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d55216sm9299322b3a.11.2026.02.28.18.43.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 28 Feb 2026 18:43:19 -0800 (PST) From: Yuchan Nam To: stable@vger.kernel.org Cc: sashal@kernel.org, sprasad@microsoft.com, stfrench@microsoft.com, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, Yuchan Nam Subject: [PATCH 6.6.y] cifs: some missing initializations on replay Date: Sun, 1 Mar 2026 11:43:08 +0900 Message-ID: <20260301024308.80078-1-entropy1110@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260301013911.1700044-1-sashal@kernel.org> References: <20260301013911.1700044-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Shyam Prasad N [ Upstream commit 14f66f44646333d2bfd7ece36585874fd72f8286 ] In several places in the code, we have a label to signify the start of the code where a request can be replayed if necessary. However, some of these places were missing the necessary reinitializations of certain local variables before replay. This change makes sure that these variables get initialized after the label. Cc: stable@vger.kernel.org Reported-by: Yuchan Nam Tested-by: Yuchan Nam Signed-off-by: Shyam Prasad N Signed-off-by: Steve French Signed-off-by: Yuchan Nam --- fs/smb/client/smb2ops.c | 2 ++ fs/smb/client/smb2pdu.c | 1 + 2 files changed, 3 insertions(+) diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index 138b3ed..4239b68 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -1147,6 +1147,7 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon, replay_again: /* reinitialize for possible replay */ + used_len = 0; flags = CIFS_CP_CREATE_CLOSE_OP; oplock = SMB2_OPLOCK_LEVEL_NONE; server = cifs_pick_channel(ses); @@ -1545,6 +1546,7 @@ smb2_ioctl_query_info(const unsigned int xid, replay_again: /* reinitialize for possible replay */ + buffer = NULL; flags = CIFS_CP_CREATE_CLOSE_OP; oplock = SMB2_OPLOCK_LEVEL_NONE; server = cifs_pick_channel(ses); diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c index a8890ae..595f043 100644 --- a/fs/smb/client/smb2pdu.c +++ b/fs/smb/client/smb2pdu.c @@ -2850,6 +2850,7 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode, replay_again: /* reinitialize for possible replay */ + pc_buf = NULL; flags = 0; n_iov = 2; server = cifs_pick_channel(ses); -- 2.43.0