From: Eric Biggers <ebiggers@kernel.org>
To: Steve French <sfrench@samba.org>, linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org, linux-crypto@vger.kernel.org,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] smb: client: Compare MACs in constant time
Date: Mon, 2 Mar 2026 21:04:39 -0800 [thread overview]
Message-ID: <20260303050439.GB5238@sol> (raw)
In-Reply-To: <20260218042702.67907-1-ebiggers@kernel.org>
On Tue, Feb 17, 2026 at 08:27:02PM -0800, Eric Biggers wrote:
> To prevent timing attacks, MAC comparisons need to be constant-time.
> Replace the memcmp() with the correct function, crypto_memneq().
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> fs/smb/client/smb1encrypt.c | 3 ++-
> fs/smb/client/smb2transport.c | 4 +++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
Any feedback on this? Just to clarify, this is intended to be taken
through the smb tree.
- Eric
next prev parent reply other threads:[~2026-03-03 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 4:27 [PATCH] smb: client: Compare MACs in constant time Eric Biggers
2026-03-03 5:04 ` Eric Biggers [this message]
2026-03-03 16:23 ` Paulo Alcantara
2026-03-04 2:58 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303050439.GB5238@sol \
--to=ebiggers@kernel.org \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox