public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Chengwen Feng <fengchengwen@huawei.com>,
	linux-pci@vger.kernel.org, bhelgaas@google.com
Cc: oe-kbuild-all@lists.linux.dev, linux-acpi@vger.kernel.org,
	rafael@kernel.org, lenb@kernel.org, wei.huang2@amd.com,
	Eric.VanTassell@amd.com, jonathan.cameron@huawei.com,
	wangzhou1@hisilicon.com, wanghuiqiang@huawei.com,
	liuyonglong@huawei.com, Chengwen Feng <fengchengwen@huawei.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform
Date: Thu, 5 Mar 2026 09:29:03 +0800	[thread overview]
Message-ID: <202603050927.IVSflNry-lkp@intel.com> (raw)
In-Reply-To: <20260303003625.39035-1-fengchengwen@huawei.com>

Hi Chengwen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus rafael-pm/linux-next rafael-pm/bleeding-edge linus/master v7.0-rc2 next-20260303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chengwen-Feng/PCI-TPH-Fix-get-cpu-steer-tag-fail-on-ARM64-platform/20260303-084305
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20260303003625.39035-1-fengchengwen%40huawei.com
patch subject: [PATCH] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform
config: loongarch-randconfig-002-20260305 (https://download.01.org/0day-ci/archive/20260305/202603050927.IVSflNry-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260305/202603050927.IVSflNry-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603050927.IVSflNry-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/tph.c:92:20: warning: 'tph_invoke_dsm' defined but not used [-Wunused-function]
      92 | static acpi_status tph_invoke_dsm(acpi_handle handle, u32 cpu_uid,
         |                    ^~~~~~~~~~~~~~
>> drivers/pci/tph.c:56:12: warning: 'tph_extract_tag' defined but not used [-Wunused-function]
      56 | static u16 tph_extract_tag(enum tph_mem_type mem_type, u8 req_type,
         |            ^~~~~~~~~~~~~~~


vim +/tph_invoke_dsm +92 drivers/pci/tph.c

d2e8a34876ce69b Wei Huang 2024-10-02   55  
d2e8a34876ce69b Wei Huang 2024-10-02  @56  static u16 tph_extract_tag(enum tph_mem_type mem_type, u8 req_type,
d2e8a34876ce69b Wei Huang 2024-10-02   57  			   union st_info *info)
d2e8a34876ce69b Wei Huang 2024-10-02   58  {
d2e8a34876ce69b Wei Huang 2024-10-02   59  	switch (req_type) {
d2e8a34876ce69b Wei Huang 2024-10-02   60  	case PCI_TPH_REQ_TPH_ONLY: /* 8-bit tag */
d2e8a34876ce69b Wei Huang 2024-10-02   61  		switch (mem_type) {
d2e8a34876ce69b Wei Huang 2024-10-02   62  		case TPH_MEM_TYPE_VM:
d2e8a34876ce69b Wei Huang 2024-10-02   63  			if (info->vm_st_valid)
d2e8a34876ce69b Wei Huang 2024-10-02   64  				return info->vm_st;
d2e8a34876ce69b Wei Huang 2024-10-02   65  			break;
d2e8a34876ce69b Wei Huang 2024-10-02   66  		case TPH_MEM_TYPE_PM:
d2e8a34876ce69b Wei Huang 2024-10-02   67  			if (info->pm_st_valid)
d2e8a34876ce69b Wei Huang 2024-10-02   68  				return info->pm_st;
d2e8a34876ce69b Wei Huang 2024-10-02   69  			break;
d2e8a34876ce69b Wei Huang 2024-10-02   70  		}
d2e8a34876ce69b Wei Huang 2024-10-02   71  		break;
d2e8a34876ce69b Wei Huang 2024-10-02   72  	case PCI_TPH_REQ_EXT_TPH: /* 16-bit tag */
d2e8a34876ce69b Wei Huang 2024-10-02   73  		switch (mem_type) {
d2e8a34876ce69b Wei Huang 2024-10-02   74  		case TPH_MEM_TYPE_VM:
d2e8a34876ce69b Wei Huang 2024-10-02   75  			if (info->vm_xst_valid)
d2e8a34876ce69b Wei Huang 2024-10-02   76  				return info->vm_xst;
d2e8a34876ce69b Wei Huang 2024-10-02   77  			break;
d2e8a34876ce69b Wei Huang 2024-10-02   78  		case TPH_MEM_TYPE_PM:
d2e8a34876ce69b Wei Huang 2024-10-02   79  			if (info->pm_xst_valid)
d2e8a34876ce69b Wei Huang 2024-10-02   80  				return info->pm_xst;
d2e8a34876ce69b Wei Huang 2024-10-02   81  			break;
d2e8a34876ce69b Wei Huang 2024-10-02   82  		}
d2e8a34876ce69b Wei Huang 2024-10-02   83  		break;
d2e8a34876ce69b Wei Huang 2024-10-02   84  	default:
d2e8a34876ce69b Wei Huang 2024-10-02   85  		return 0;
d2e8a34876ce69b Wei Huang 2024-10-02   86  	}
d2e8a34876ce69b Wei Huang 2024-10-02   87  
d2e8a34876ce69b Wei Huang 2024-10-02   88  	return 0;
d2e8a34876ce69b Wei Huang 2024-10-02   89  }
d2e8a34876ce69b Wei Huang 2024-10-02   90  
d2e8a34876ce69b Wei Huang 2024-10-02   91  #define TPH_ST_DSM_FUNC_INDEX	0xF
d2e8a34876ce69b Wei Huang 2024-10-02  @92  static acpi_status tph_invoke_dsm(acpi_handle handle, u32 cpu_uid,
d2e8a34876ce69b Wei Huang 2024-10-02   93  				  union st_info *st_out)
d2e8a34876ce69b Wei Huang 2024-10-02   94  {
d2e8a34876ce69b Wei Huang 2024-10-02   95  	union acpi_object arg3[3], in_obj, *out_obj;
d2e8a34876ce69b Wei Huang 2024-10-02   96  
d2e8a34876ce69b Wei Huang 2024-10-02   97  	if (!acpi_check_dsm(handle, &pci_acpi_dsm_guid, 7,
d2e8a34876ce69b Wei Huang 2024-10-02   98  			    BIT(TPH_ST_DSM_FUNC_INDEX)))
d2e8a34876ce69b Wei Huang 2024-10-02   99  		return AE_ERROR;
d2e8a34876ce69b Wei Huang 2024-10-02  100  
d2e8a34876ce69b Wei Huang 2024-10-02  101  	/* DWORD: feature ID (0 for processor cache ST query) */
d2e8a34876ce69b Wei Huang 2024-10-02  102  	arg3[0].integer.type = ACPI_TYPE_INTEGER;
d2e8a34876ce69b Wei Huang 2024-10-02  103  	arg3[0].integer.value = 0;
d2e8a34876ce69b Wei Huang 2024-10-02  104  
d2e8a34876ce69b Wei Huang 2024-10-02  105  	/* DWORD: target UID */
d2e8a34876ce69b Wei Huang 2024-10-02  106  	arg3[1].integer.type = ACPI_TYPE_INTEGER;
d2e8a34876ce69b Wei Huang 2024-10-02  107  	arg3[1].integer.value = cpu_uid;
d2e8a34876ce69b Wei Huang 2024-10-02  108  
d2e8a34876ce69b Wei Huang 2024-10-02  109  	/* QWORD: properties, all 0's */
d2e8a34876ce69b Wei Huang 2024-10-02  110  	arg3[2].integer.type = ACPI_TYPE_INTEGER;
d2e8a34876ce69b Wei Huang 2024-10-02  111  	arg3[2].integer.value = 0;
d2e8a34876ce69b Wei Huang 2024-10-02  112  
d2e8a34876ce69b Wei Huang 2024-10-02  113  	in_obj.type = ACPI_TYPE_PACKAGE;
d2e8a34876ce69b Wei Huang 2024-10-02  114  	in_obj.package.count = ARRAY_SIZE(arg3);
d2e8a34876ce69b Wei Huang 2024-10-02  115  	in_obj.package.elements = arg3;
d2e8a34876ce69b Wei Huang 2024-10-02  116  
d2e8a34876ce69b Wei Huang 2024-10-02  117  	out_obj = acpi_evaluate_dsm(handle, &pci_acpi_dsm_guid, 7,
d2e8a34876ce69b Wei Huang 2024-10-02  118  				    TPH_ST_DSM_FUNC_INDEX, &in_obj);
d2e8a34876ce69b Wei Huang 2024-10-02  119  	if (!out_obj)
d2e8a34876ce69b Wei Huang 2024-10-02  120  		return AE_ERROR;
d2e8a34876ce69b Wei Huang 2024-10-02  121  
d2e8a34876ce69b Wei Huang 2024-10-02  122  	if (out_obj->type != ACPI_TYPE_BUFFER) {
d2e8a34876ce69b Wei Huang 2024-10-02  123  		ACPI_FREE(out_obj);
d2e8a34876ce69b Wei Huang 2024-10-02  124  		return AE_ERROR;
d2e8a34876ce69b Wei Huang 2024-10-02  125  	}
d2e8a34876ce69b Wei Huang 2024-10-02  126  
d2e8a34876ce69b Wei Huang 2024-10-02  127  	st_out->value = *((u64 *)(out_obj->buffer.pointer));
d2e8a34876ce69b Wei Huang 2024-10-02  128  
d2e8a34876ce69b Wei Huang 2024-10-02  129  	ACPI_FREE(out_obj);
d2e8a34876ce69b Wei Huang 2024-10-02  130  
d2e8a34876ce69b Wei Huang 2024-10-02  131  	return AE_OK;
d2e8a34876ce69b Wei Huang 2024-10-02  132  }
d2e8a34876ce69b Wei Huang 2024-10-02  133  #endif
d2e8a34876ce69b Wei Huang 2024-10-02  134  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2026-03-05  1:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  0:36 [PATCH] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform Chengwen Feng
2026-03-03 19:02 ` Bjorn Helgaas
2026-03-04  9:28   ` fengchengwen
2026-03-04 15:38     ` Bjorn Helgaas
2026-03-05  8:40       ` fengchengwen
2026-03-04 13:50 ` kernel test robot
2026-03-04 23:18 ` kernel test robot
2026-03-05  0:02 ` kernel test robot
2026-03-05  1:29 ` kernel test robot [this message]
2026-03-05  8:36 ` [PATCH v2] " Chengwen Feng
2026-03-05  8:53   ` Huacai Chen
2026-03-05  9:07     ` fengchengwen
2026-03-05 14:54       ` Jonathan Cameron
2026-03-06  2:20         ` fengchengwen
2026-03-06  2:19 ` [PATCH v3] " Chengwen Feng
2026-03-06 10:01   ` Jonathan Cameron
2026-03-09  4:18     ` fengchengwen
2026-03-09  4:16 ` [PATCH v4 0/2] " Chengwen Feng
2026-03-09  4:16   ` [PATCH v4 1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86 Chengwen Feng
2026-03-09 10:30     ` Jonathan Cameron
2026-03-09 13:29     ` Huacai Chen
2026-03-10  3:29       ` fengchengwen
2026-03-09  4:16   ` [PATCH v4 2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform Chengwen Feng
2026-03-09 10:59     ` Jonathan Cameron
2026-03-09 10:28   ` [PATCH v4 0/2] " Jonathan Cameron
2026-03-10  3:26     ` fengchengwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202603050927.IVSflNry-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Eric.VanTassell@amd.com \
    --cc=bhelgaas@google.com \
    --cc=fengchengwen@huawei.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wanghuiqiang@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=wei.huang2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox