* [PATCH] drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START,END}
@ 2026-03-06 6:28 Xi Ruoyao
2026-03-12 20:59 ` Alex Hung
0 siblings, 1 reply; 2+ messages in thread
From: Xi Ruoyao @ 2026-03-06 6:28 UTC (permalink / raw)
To: Alex Hung, Alex Deucher, Christian König
Cc: loongarch, Mingcong Bai, Zixing Liu, Ard Biesheuvel, Xi Ruoyao,
LiarOnce, stable, Harry Wentland, Leo Li, Rodrigo Siqueira,
David Airlie, Simona Vetter, Alvin Lee, Dillon Varone, Ray Wu,
Kees Cook, Yan Li, Ryan Seto, Saaem Rizvi, amd-gfx, dri-devel,
linux-kernel
[Why]
The dcn32_override_min_req_memclk function is in dcn32_fpu.c, which is
compiled with CC_FLAGS_FPU into FP instructions. So when we call it we
must use DC_FP_{START,END} to save and restore the FP context, and
prepare the FP unit on architectures like LoongArch where the FP unit
isn't always on.
Reported-by: LiarOnce <liaronce@hotmail.com>
Fixes: ee7be8f3de1c ("drm/amd/display: Limit DCN32 8 channel or less parts to DPM1 for FPO")
Cc: stable@vger.kernel.org
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
index 7ebb7d1193af..c7fd604024d6 100644
--- a/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
@@ -1785,7 +1785,10 @@ static bool dml1_validate(struct dc *dc, struct dc_state *context, enum dc_valid
dc->res_pool->funcs->calculate_wm_and_dlg(dc, context, pipes, pipe_cnt, vlevel);
+ DC_FP_START();
dcn32_override_min_req_memclk(dc, context);
+ DC_FP_END();
+
dcn32_override_min_req_dcfclk(dc, context);
BW_VAL_TRACE_END_WATERMARKS();
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START,END}
2026-03-06 6:28 [PATCH] drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START,END} Xi Ruoyao
@ 2026-03-12 20:59 ` Alex Hung
0 siblings, 0 replies; 2+ messages in thread
From: Alex Hung @ 2026-03-12 20:59 UTC (permalink / raw)
To: Xi Ruoyao, Alex Deucher, Christian König
Cc: loongarch, Mingcong Bai, Zixing Liu, Ard Biesheuvel, LiarOnce,
stable, Harry Wentland, Leo Li, Rodrigo Siqueira, David Airlie,
Simona Vetter, Alvin Lee, Dillon Varone, Ray Wu, Kees Cook,
Yan Li, Ryan Seto, Saaem Rizvi, amd-gfx, dri-devel, linux-kernel
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 3/5/26 23:28, Xi Ruoyao wrote:
> [Why]
> The dcn32_override_min_req_memclk function is in dcn32_fpu.c, which is
> compiled with CC_FLAGS_FPU into FP instructions. So when we call it we
> must use DC_FP_{START,END} to save and restore the FP context, and
> prepare the FP unit on architectures like LoongArch where the FP unit
> isn't always on.
>
> Reported-by: LiarOnce <liaronce@hotmail.com>
> Fixes: ee7be8f3de1c ("drm/amd/display: Limit DCN32 8 channel or less parts to DPM1 for FPO")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
> index 7ebb7d1193af..c7fd604024d6 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
> @@ -1785,7 +1785,10 @@ static bool dml1_validate(struct dc *dc, struct dc_state *context, enum dc_valid
>
> dc->res_pool->funcs->calculate_wm_and_dlg(dc, context, pipes, pipe_cnt, vlevel);
>
> + DC_FP_START();
> dcn32_override_min_req_memclk(dc, context);
> + DC_FP_END();
> +
> dcn32_override_min_req_dcfclk(dc, context);
>
> BW_VAL_TRACE_END_WATERMARKS();
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-12 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-06 6:28 [PATCH] drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START,END} Xi Ruoyao
2026-03-12 20:59 ` Alex Hung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox