From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A693A393DF8 for ; Mon, 9 Mar 2026 11:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773054144; cv=none; b=Joyy7kWw/lDw/z2cTQRetz54oac0Zb8JAn1vzJnHhV0/O+mK8/JgUV/JGxRl6VfBKd/OODMwQAUsW0WakTL9MMPnmrfGaqp+a/z5sk962hFAleANnLExLjusmkHM7husyxTyj/9j21wc53V/t4lsU88dxnxLGjUP+MjaAPbjVTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773054144; c=relaxed/simple; bh=2W3pFSG6qYVC8K/NGbx/WunuYTdw5B6tOMZknbcTE5E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pRavOkyXxLJ92o0b3lEZOWaG6Kdl26wwzqI0PmWfZ4dY9vXa4y/obMnBc9a+qJQvaS6u1AY4gUp4cYOr2LSuaurzeqfmsGttb8iSQDCFYWez8FqVlOb5p1HKhI17taFKPumPErfhb/kOUXV35wnLX+DT7z2LvA9m2FHASUut0dI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mf2LQuh2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mf2LQuh2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6A5EC4CEF7; Mon, 9 Mar 2026 11:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773054144; bh=2W3pFSG6qYVC8K/NGbx/WunuYTdw5B6tOMZknbcTE5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mf2LQuh2MOuTTD4tLYRckyl0+ESsLk0cG677ln9PqmszwTZ3BqBuVGeZJ+neFt0I4 JpHShkhil0iyb6t7rHr5x65AfogJW2nUHgBBKa/TcnBoc2tpeyx5bfVp/JrtCjrkfk JNycHFWjS7mnNONqi1yYNst2JXCCqKF0gFbzshN0LFERpQFz5TymYeRNtguWEraJfk 6efYdBIwwaWAelaQHBrU6z+mWxgsq9bitFZeATN4IKH93//y7EkzD/TLXxWvm9m9NB cFiKe5bH4fAsT8qMiigrFbrwff16IEXKxnSRYPJIh5OzC83ra8UUBRhIAzwbgeI2/f kH65N8vCHpM+w== From: Sasha Levin To: stable@vger.kernel.org Cc: Daniel Hodges , Johannes Berg , Sasha Levin Subject: [PATCH 6.12.y] wifi: libertas: fix use-after-free in lbs_free_adapter() Date: Mon, 9 Mar 2026 07:02:21 -0400 Message-ID: <20260309110221.805280-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026030916-guts-unsent-00b7@gregkh> References: <2026030916-guts-unsent-00b7@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daniel Hodges [ Upstream commit 03cc8f90d0537fcd4985c3319b4fafbf2e3fb1f0 ] The lbs_free_adapter() function uses timer_delete() (non-synchronous) for both command_timer and tx_lockup_timer before the structure is freed. This is incorrect because timer_delete() does not wait for any running timer callback to complete. If a timer callback is executing when lbs_free_adapter() is called, the callback will access freed memory since lbs_cfg_free() frees the containing structure immediately after lbs_free_adapter() returns. Both timer callbacks (lbs_cmd_timeout_handler and lbs_tx_lockup_handler) access priv->driver_lock, priv->cur_cmd, priv->dev, and other fields, which would all be use-after-free violations. Use timer_delete_sync() instead to ensure any running timer callback has completed before returning. This bug was introduced in commit 8f641d93c38a ("libertas: detect TX lockups and reset hardware") where del_timer() was used instead of del_timer_sync() in the cleanup path. The command_timer has had the same issue since the driver was first written. Fixes: 8f641d93c38a ("libertas: detect TX lockups and reset hardware") Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence") Cc: stable@vger.kernel.org Signed-off-by: Daniel Hodges Link: https://patch.msgid.link/20260206195356.15647-1-git@danielhodges.dev Signed-off-by: Johannes Berg [ del_timer() => timer_delete_sync() ] Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c index 78e8b5aecec0e..91b9501c6d8cb 100644 --- a/drivers/net/wireless/marvell/libertas/main.c +++ b/drivers/net/wireless/marvell/libertas/main.c @@ -881,8 +881,8 @@ static void lbs_free_adapter(struct lbs_private *priv) { lbs_free_cmd_buffer(priv); kfifo_free(&priv->event_fifo); - del_timer(&priv->command_timer); - del_timer(&priv->tx_lockup_timer); + timer_delete_sync(&priv->command_timer); + timer_delete_sync(&priv->tx_lockup_timer); del_timer(&priv->auto_deepsleep_timer); } -- 2.51.0