From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744CA39B4BA for ; Mon, 9 Mar 2026 11:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773055771; cv=none; b=lfqo8/xlQ0P5JNj2wQM2e30tby08MdQ37/w/+rpOdKdw1o8SA9atTvj6R4PEZ/dLFsEx5GeHoAZ0wnWXNIK4fXSRcEf+Ndk91ZmpyYD8CSjNVC8wtEQ2bLWvY/bbi263uKdy44CFhQyi2upBTbbfbYpmmD6/5ohxUizBt8SWP+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773055771; c=relaxed/simple; bh=S1pSCU/Hwevk4H4NToMkxdK8zxREjfNP57fgBfkI3jE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KkcABa8+/y5uZS1/TkB7j80DnO7Z/Ln5N29EsMQid6ZG2AjNouKVpmn+7CR4VXdrRMg4F2sHgLjA8NHbcGx9hdYCqINNBdKY5o6txWmedJZYKIhpr7rJFRW5aLPaaChTc8nkforkG587TV+IPC4+J4jFlh6ZPiXdmipyPTc3CN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t8LK0OlW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t8LK0OlW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC0EAC4CEF7; Mon, 9 Mar 2026 11:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773055771; bh=S1pSCU/Hwevk4H4NToMkxdK8zxREjfNP57fgBfkI3jE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t8LK0OlW3TeTPwiEFTNP9l3/OzpS4L9b3D/+AKJG94w5X0I6PbJeCco4XwURvVGDg 5xe0ZjeM2gUe8pDaV6sGPD/lIwWv3DQ5pPxsFoAiOdDfFJCGNnFLI4wkRn6Uc6iag4 OrGLiYJXKEdxeJBN3bOw1tEssmZ1t/fppBGpNxjV59AwFvaI5CsXi7Z1y1CN27jqpS +arlAeWo5VwrOypORxEQUDcvJz2MMaC9xOWOAlV6HTHsl0snuFvUAr2T9LNEcVEizj dESaWyybAafNplxAq804GBr53YTxMgTdQvG38xNl8xbR2BTk7DQthm+3AIYH8ToeiH VghUAKcuCTS9w== From: Sasha Levin To: stable@vger.kernel.org Cc: Daniel Hodges , Johannes Berg , Sasha Levin Subject: [PATCH 5.10.y] wifi: libertas: fix use-after-free in lbs_free_adapter() Date: Mon, 9 Mar 2026 07:29:28 -0400 Message-ID: <20260309112928.819155-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026030918-bulge-october-6117@gregkh> References: <2026030918-bulge-october-6117@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daniel Hodges [ Upstream commit 03cc8f90d0537fcd4985c3319b4fafbf2e3fb1f0 ] The lbs_free_adapter() function uses timer_delete() (non-synchronous) for both command_timer and tx_lockup_timer before the structure is freed. This is incorrect because timer_delete() does not wait for any running timer callback to complete. If a timer callback is executing when lbs_free_adapter() is called, the callback will access freed memory since lbs_cfg_free() frees the containing structure immediately after lbs_free_adapter() returns. Both timer callbacks (lbs_cmd_timeout_handler and lbs_tx_lockup_handler) access priv->driver_lock, priv->cur_cmd, priv->dev, and other fields, which would all be use-after-free violations. Use timer_delete_sync() instead to ensure any running timer callback has completed before returning. This bug was introduced in commit 8f641d93c38a ("libertas: detect TX lockups and reset hardware") where del_timer() was used instead of del_timer_sync() in the cleanup path. The command_timer has had the same issue since the driver was first written. Fixes: 8f641d93c38a ("libertas: detect TX lockups and reset hardware") Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence") Cc: stable@vger.kernel.org Signed-off-by: Daniel Hodges Link: https://patch.msgid.link/20260206195356.15647-1-git@danielhodges.dev Signed-off-by: Johannes Berg [ del_timer() => timer_delete_sync() ] Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c index 1c56cc2742b07..459b30a1050d7 100644 --- a/drivers/net/wireless/marvell/libertas/main.c +++ b/drivers/net/wireless/marvell/libertas/main.c @@ -882,8 +882,8 @@ static void lbs_free_adapter(struct lbs_private *priv) { lbs_free_cmd_buffer(priv); kfifo_free(&priv->event_fifo); - del_timer(&priv->command_timer); - del_timer(&priv->tx_lockup_timer); + timer_delete_sync(&priv->command_timer); + timer_delete_sync(&priv->tx_lockup_timer); del_timer(&priv->auto_deepsleep_timer); } -- 2.51.0