From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F6BC2C08D0 for ; Mon, 9 Mar 2026 13:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773062861; cv=none; b=eSnuQxtZ7QepdPiZnhyzrVHaiRVbf0GKk4gKT+dG5sY6LfKQij6S/I1yUukEo13ekg753RCW2529aHhWNxts5Az+hBxZgqbvoLqSGag2lKsPOIE5V92HsXrL7gm3huIbzisP7KPjvbRaJOfKOOsCxyaG64YoffjaXX30MKhn558= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773062861; c=relaxed/simple; bh=378/2avhtLkyFLZi9lshJDpXYSvMSpxOriIkB1PzPaI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YwidcI7f03ybSuX0lyPFMhqTVvwCliNuVQJiDfETsiEOIA36kHFZLOuH4XL4o9QUQmgACTC52P1f/OqIbxed5QmAAZEJQqACAfeSmNiGNyIRfso/zbm/7vFSjR2sUkwgiplZrtndVSY+7O7a+5c83gEJEtyrD28234rf0Eyy0kI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ifGudzZl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ifGudzZl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 742BBC4CEF7; Mon, 9 Mar 2026 13:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773062861; bh=378/2avhtLkyFLZi9lshJDpXYSvMSpxOriIkB1PzPaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ifGudzZlFlRA1CfrVrKkxcuPZxooM70Kky45ljxHyLDw5rzZTal2hETOsD8MQeRGd xetrYU1lUbzuhXflS9c8XM76tJRxHe7lbH6HqGoCc1vzA2NfI2mrNJEHIUtv4sEqc0 NaiQ97i/exABs4PTfKlubD7IyJ8uy1LjuEjANdnqP1hMsyEG7N68b3w9g9B+gTsbUW EbH5LoEYegv3IA8ZBgB1zY4adEQu6TiT2D8+4h2qlKwCTp9wNGNz3N4rd3ERRkBgTp knukQBUR1dFsSds0k1vHLdgt9HoHxAdjNRPYmScD/wzgnhBa7cf2qWPrM6hyNlXmSC B9ZsqakuWYXcg== From: Sasha Levin To: stable@vger.kernel.org Cc: Jason Gunthorpe , Jason Gunthorpe , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.15.y] RDMA/irdma: Fix kernel stack leak in irdma_create_user_ah() Date: Mon, 9 Mar 2026 09:27:39 -0400 Message-ID: <20260309132739.944769-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026030901-book-commodity-3938@gregkh> References: <2026030901-book-commodity-3938@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jason Gunthorpe [ Upstream commit 74586c6da9ea222a61c98394f2fc0a604748438c ] struct irdma_create_ah_resp { // 8 bytes, no padding __u32 ah_id; // offset 0 - SET (uresp.ah_id = ah->sc_ah.ah_info.ah_idx) __u8 rsvd[4]; // offset 4 - NEVER SET <- LEAK }; rsvd[4]: 4 bytes of stack memory leaked unconditionally. Only ah_id is assigned before ib_respond_udata(). The reserved members of the structure were not zeroed. Cc: stable@vger.kernel.org Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") Signed-off-by: Jason Gunthorpe Link: https://patch.msgid.link/3-v1-83e918d69e73+a9-rdma_udata_rc_jgg@nvidia.com Signed-off-by: Leon Romanovsky [ adapted fix to combined irdma_create_ah() ] Signed-off-by: Sasha Levin --- drivers/infiniband/hw/irdma/verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c index e62a825622834..40960f0803fbc 100644 --- a/drivers/infiniband/hw/irdma/verbs.c +++ b/drivers/infiniband/hw/irdma/verbs.c @@ -4170,7 +4170,7 @@ static int irdma_create_ah(struct ib_ah *ibah, struct irdma_sc_ah *sc_ah; u32 ah_id = 0; struct irdma_ah_info *ah_info; - struct irdma_create_ah_resp uresp; + struct irdma_create_ah_resp uresp = {}; union { struct sockaddr saddr; struct sockaddr_in saddr_in; -- 2.51.0