From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8E313CCA10 for ; Mon, 9 Mar 2026 14:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773064813; cv=none; b=Jwqbz9cTW3tuhNfEI014ooKgIHuCEqsqZ0ECoEtICWNdAqOGcpo9EDehuqWP1j6zP5GyyLwhYgRLUQOAd2OUBUruN/JbygMO1QIZpN7KbFeuXcgskd9bsov4Y2Ypqlo7+qnTltzsGM4zR1OwqTYoln7b83Ahr+upaUVN+R8Z80U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773064813; c=relaxed/simple; bh=UvD+53ONYkW8ygV9bQLLL2/ULZ8C9eIEGA0I6PdX32o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dQtI/6ltShCEeyF3W+b5LPH26+7kkNKcigbRscl5g4EFRl+itVdytMHDMnaKOGe5sCI6ryG3J8eWEWFgfPpneAXekfccNdHKftUBQUAN5mNoiI0ACQoERKW/VTE8GTYRToxClO2GGl1NiINnIE+HpIPe4uhFoNcKdWAVWscDQso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bM5LYutE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bM5LYutE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09C4FC4CEF7; Mon, 9 Mar 2026 14:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773064812; bh=UvD+53ONYkW8ygV9bQLLL2/ULZ8C9eIEGA0I6PdX32o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bM5LYutE/g6BRY5qlpdE05V4xA/ej5nYuA/6zdfxtDg7lQE5Rn0WokmUB2sFIyqkM OD8HoXVWbG6cyE94aqoj2DA1kZcDQd+Wc2sUtrYZS1SxozH89iDVbt0gJf54fiM9/L 7XJvt/moQdKm5EJ74e87e/HgO/SOFw7NZgUnSXmy/UWBMr+bVekVQxQ9kw84qa7ZV0 6gItMlNLn7ntY3JC3KdNXBCFZCSvcNVI1PTiR3PlQf6iOo/FLqvce9Fd6wKKI4hMlC 3UDBGbROLmX6dnShRy7oRIEi6EbRf53tvt7TZlH+jclJTHK7z3NCMNTBILDnle5P40 Cj5l/tnUOydWg== From: Sasha Levin To: stable@vger.kernel.org Cc: Thorsten Blum , "Paulo Alcantara (Red Hat)" , Steve French , Sasha Levin Subject: [PATCH 5.15.y] smb: client: Don't log plaintext credentials in cifs_set_cifscreds Date: Mon, 9 Mar 2026 10:00:09 -0400 Message-ID: <20260309140009.1065571-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026030914-pellet-condone-8fe6@gregkh> References: <2026030914-pellet-condone-8fe6@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thorsten Blum [ Upstream commit 2f37dc436d4e61ff7ae0b0353cf91b8c10396e4d ] When debug logging is enabled, cifs_set_cifscreds() logs the key payload and exposes the plaintext username and password. Remove the debug log to avoid exposing credentials. Fixes: 8a8798a5ff90 ("cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts") Cc: stable@vger.kernel.org Acked-by: Paulo Alcantara (Red Hat) Signed-off-by: Thorsten Blum Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/connect.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 677c757fffffb..098a2ad8cec4e 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -1874,7 +1874,6 @@ cifs_set_cifscreds(struct smb3_fs_context *ctx, struct cifs_ses *ses) /* find first : in payload */ payload = upayload->data; delim = strnchr(payload, upayload->datalen, ':'); - cifs_dbg(FYI, "payload=%s\n", payload); if (!delim) { cifs_dbg(FYI, "Unable to find ':' in payload (datalen=%d)\n", upayload->datalen); -- 2.51.0