From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBF6938F229 for ; Mon, 9 Mar 2026 10:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773051570; cv=none; b=gVg1n8vqGK+idV8PhmCu40vaXssrohLoOLtF/aFCzuSWIJwVqpwEgvKdQX7M/aieGNOKLontovOK72F788T6ub9a5VNlgsL319ZGVWDl0JekmbHRVSud5SKkmoveXL6mg/6xyaELgAHu+NX8+/93SseD6QkeSNkC9MZO8ay0Ylo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773051570; c=relaxed/simple; bh=+qxqxS/XlWYKAoTF08psg3/Hv/MKjBdT/xt1vt4vZ6I=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=NQ3TmIclR2BKYxm20/24SORkJGUKTwL+gOVsKIRG8Pe7IHtqS5N1kBPmPk6blhYf8Us88KYmgAA0l37jxUg9FoC3MtUa8lM7Qz23k5Ib1yj0MncW9Vbfd8AfIwbKrLcLAEG+gMcsoFs8RuRaXqrRJOvHzrIsT1dUUW8kEXAXlJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hP3GqsNd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hP3GqsNd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78159C4CEF7; Mon, 9 Mar 2026 10:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773051569; bh=+qxqxS/XlWYKAoTF08psg3/Hv/MKjBdT/xt1vt4vZ6I=; h=Subject:To:Cc:From:Date:From; b=hP3GqsNdMOFj8mmOxr4+QWaStZ5X1gyKN/jnlFwcA8b/MR8LpXsmE3k3FC2Jtrrph HzHaXmJWqjSijIpmzCWHD6AIJHax+COg5wjlAKBGYMEC9fx/i4TJuEeKGQ+GgTZCjN jtudHdaZLck9Z1yNjInnsglQvA8yPMf7rlTlnvrI= Subject: FAILED: patch "[PATCH] wifi: libertas: fix use-after-free in lbs_free_adapter()" failed to apply to 6.1-stable tree To: git@danielhodges.dev,johannes.berg@intel.com Cc: From: Date: Mon, 09 Mar 2026 11:19:17 +0100 Message-ID: <2026030917-carry-easily-7913@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 03cc8f90d0537fcd4985c3319b4fafbf2e3fb1f0 # git commit -s git send-email --to '' --in-reply-to '2026030917-carry-easily-7913@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 03cc8f90d0537fcd4985c3319b4fafbf2e3fb1f0 Mon Sep 17 00:00:00 2001 From: Daniel Hodges Date: Fri, 6 Feb 2026 14:53:56 -0500 Subject: [PATCH] wifi: libertas: fix use-after-free in lbs_free_adapter() The lbs_free_adapter() function uses timer_delete() (non-synchronous) for both command_timer and tx_lockup_timer before the structure is freed. This is incorrect because timer_delete() does not wait for any running timer callback to complete. If a timer callback is executing when lbs_free_adapter() is called, the callback will access freed memory since lbs_cfg_free() frees the containing structure immediately after lbs_free_adapter() returns. Both timer callbacks (lbs_cmd_timeout_handler and lbs_tx_lockup_handler) access priv->driver_lock, priv->cur_cmd, priv->dev, and other fields, which would all be use-after-free violations. Use timer_delete_sync() instead to ensure any running timer callback has completed before returning. This bug was introduced in commit 8f641d93c38a ("libertas: detect TX lockups and reset hardware") where del_timer() was used instead of del_timer_sync() in the cleanup path. The command_timer has had the same issue since the driver was first written. Fixes: 8f641d93c38a ("libertas: detect TX lockups and reset hardware") Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence") Cc: stable@vger.kernel.org Signed-off-by: Daniel Hodges Link: https://patch.msgid.link/20260206195356.15647-1-git@danielhodges.dev Signed-off-by: Johannes Berg diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c index d44e02c6fe38..dd97f1b61f4d 100644 --- a/drivers/net/wireless/marvell/libertas/main.c +++ b/drivers/net/wireless/marvell/libertas/main.c @@ -799,8 +799,8 @@ static void lbs_free_adapter(struct lbs_private *priv) { lbs_free_cmd_buffer(priv); kfifo_free(&priv->event_fifo); - timer_delete(&priv->command_timer); - timer_delete(&priv->tx_lockup_timer); + timer_delete_sync(&priv->command_timer); + timer_delete_sync(&priv->tx_lockup_timer); } static const struct net_device_ops lbs_netdev_ops = {