From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7FDD2D8760; Tue, 10 Mar 2026 18:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773167056; cv=none; b=UFxgjbWHkzqGq5JsvsP7iBiriQe11OdfQnlscp7RFxAp3ut9mxLwAtcBfQUkh2/J6gK2nlDPACmT343zgho4TgZbHS8AtDetGEGYikRwb+Q+Ta+Wv0FJym6k3Ws72KDwsz6dO0sHdhxGo0i/M7MN0v7Z+eFekh87Z6ygimUntNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773167056; c=relaxed/simple; bh=60fgkUWv92rLl/BzDoW4SUNLQP2bHEZxw7UrCs7abIg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TM4yygKuEc5MAolrPjypIjSKPWSaj0xhBsuSVHCYe0/koAOGULtQbEP+wF1PFIxMmH29O3EpM6himsJjcC4+N97EvCZ8D59LC5Lx7s0RJTxBg9CuBUqyFC4b0ad5jKnLyY+XErsJO2YpNlQ1tSU3sHK8EmE3LhbgOYEU7ffiGnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pBppPdW3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pBppPdW3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1E11C19423; Tue, 10 Mar 2026 18:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773167056; bh=60fgkUWv92rLl/BzDoW4SUNLQP2bHEZxw7UrCs7abIg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pBppPdW33AdnO65LirAuuQCuyc0yAjz8IHfD6Oz5XBSkkHJ4wuk2hYjfgZ3+f0xCw /8RSI8DCAXhS68OOaLJ7lVQ7/LmOS6sIfejXfD133JUwwwOeSZRq0TafcfVCi3uUqX X/nW/eLSQEDtJPxN89fDZ56h9OJf0TMwb3rtmVtpGbYzxFL79IDtSlBoXA/tldrgQJ km/C1+XfbFv00YK3gqf2X3uRB8TxlJaAVj7QoI3dagJt4seqgfTcwpkRvk9K7g3G0O DDnR293hcji+pqLfGbQcKFqu9W92EAok8L75heenXeInVBRvyeUKJpNar1vGwMtXP3 4Dw6y+qHWUTvw== From: Conor Dooley To: linux-riscv@lists.infradead.org, Conor Dooley Cc: Conor Dooley , stable@vger.kernel.org, Daire McNamara , Valentina.FernandezAlanis@microchip.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] firmware: microchip: fail auto-update probe if no flash found Date: Tue, 10 Mar 2026 18:24:11 +0000 Message-ID: <20260310-gyration-smasher-1eb31125b2b6@spud> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260303-emphatic-roundness-8fe5cd8c3159@spud> References: <20260303-emphatic-roundness-8fe5cd8c3159@spud> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=836; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=hWgL2DzJiZOmEy7GIVpd1Ka6l//mB6IOSxtqxJ4xxNo=; b=owGbwMvMwCVWscWwfUFT0iXG02pJDJkbEs88+LWhQ4RZ7uH3mW/rL5ee0hfQmM4ne/7Fpi2Lr x/Pz93T3VHKwiDGxSArpsiSeLuvRWr9H5cdzj1vYeawMoEMYeDiFICJeAsyMvyttczhfnZpstkb nxIm723tHa+O/hR9teby+gmJKllfoxYy/A8r/c26O3uug/fn2fX2la92TmV45tfVujT8SNG/GaY s57gB X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit From: Conor Dooley On Tue, 03 Mar 2026 11:24:06 +0000, Conor Dooley wrote: > There's no point letting the driver probe if there is no flash, as > trying to do a firmware upload will fail. Move the code that attempts > to get the flash from firmware upload to probe, and let it emit a > message to users stating why auto-update is not supported. > The code currently could have a problem if there's a flash in > devicetree, but the system controller driver fails to get a pointer to > it from the mtd subsystem, which will cause > mpfs_sys_controller_get_flash() to return an error. Check for errors and > null, instead of just null, in the new clause. > > [...] Applied to riscv-soc-fixes, thanks! [1/1] firmware: microchip: fail auto-update probe if no flash found https://git.kernel.org/conor/c/c30b2509164f Thanks, Conor.