From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B6646AF1A; Tue, 10 Mar 2026 09:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773133356; cv=none; b=mnNzBs8mwanKbp/IUkHLyw6ZUG60SxbOHKJpJ2IDUyh6eZv104WDCkoaLksNjHlU2olFWwqGqz6vdYr43pJsb+PCFNU+G1nOvVEyCdsvXqvc1zCnzC/0lfvm7z7i8xId4DJID/8Nje9WzrGBSBvx3TXFl04tyWPvfRxFSCxWoaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773133356; c=relaxed/simple; bh=+qkH77Ub+mQy44uR6H6raPDNgH4I2sKT51kJXkKZMgE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=USa8SX4q6DwMK7AyBT+NUyebpFDL49eABPdg5PCQ3MtV5HvMK3j10NmHvahyWl5PdAdKR2QAH6pyl5oFViUtIKMioOAt6zeWjRUL0LeJ9Q6V+1SsDMhAoLYgRxOJV1v99EtQ2Yy9C/IXORGdksh1lZCXNOc6k2sR4gdl8WlRRV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=urSdA2SG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="urSdA2SG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC872C19423; Tue, 10 Mar 2026 09:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773133355; bh=+qkH77Ub+mQy44uR6H6raPDNgH4I2sKT51kJXkKZMgE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=urSdA2SGuk3V/rE+mPC8HAtbh/Z11fNbWzqyX1vpndqz7f0RK+UW/e+vYMIVKMYuu nmhegOAOif1O5pxs9KUSSwVAG10jsbrVyDJ35dfXEAi+MKmhDquuluxk2eRJ8tWfXY SvMNh4DNO9+C0xhhx7RPdmkmid0mj9FUY4pgs7DJLAkzvhtkfTrY/I+hxVWX84cbbv QzMnwvtoOPe8YSpRJIAfDScgQPH2tqJMLusfrv3JP9dgeIibuLmVTKur2u4hhw3btn 6dko7mreJVhG+IWUDskAsj7GhpPecDCDb/BDRwBErwdxk2v7zESsuPuRd+qo4jYuCO lHJITnTJzkO/w== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Antheas Kapenekakis , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin , derekjohn.clark@gmail.com, samsagax@gmail.com, hansg@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.19-6.18] platform/x86: oxpec: Add support for OneXPlayer APEX Date: Tue, 10 Mar 2026 05:01:34 -0400 Message-ID: <20260310090145.2709021-34-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260310090145.2709021-1-sashal@kernel.org> References: <20260310090145.2709021-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.19.6 Content-Transfer-Encoding: 8bit From: Antheas Kapenekakis [ Upstream commit 3385ea97c14d271dcb0c6e6fcf16972f819eecd8 ] OneXPlayer Apex is a new Strix Halo handheld. It uses the same registers as the OneXPlayer Fly devices. Add a quirk for it to the oxpec driver. Signed-off-by: Antheas Kapenekakis Link: https://patch.msgid.link/20260223183004.2696892-2-lkml@antheas.dev Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: ## Analysis This commit adds a DMI match entry for the OneXPlayer APEX handheld device to the existing `oxpec` platform driver. It maps the new device to the already-supported `oxp_fly` variant, which is used by other OneXPlayer Fly-series devices (F1, F1 EVA-01, F1 OLED). ### Code Change Analysis The change is minimal: 1. **7 lines added**: A new DMI table entry matching `ONEXPLAYER APEX` board name from vendor `ONE-NETBOOK`, using `oxp_fly` driver data 2. **1 line modified**: Copyright year update (2025 → 2025-2026) This is a textbook **device ID / hardware quirk addition** to an existing driver. The `oxp_fly` enum value and all associated logic already exist and are exercised by three other devices in the same DMI table. No new code paths, no new logic, no behavioral changes for existing hardware. ### Classification This falls clearly into the **"NEW DEVICE IDs"** exception category for stable backports: - The driver (`oxpec`) already exists in stable - The variant (`oxp_fly`) is already fully supported - Only a DMI identification entry is new - Enables fan control on a specific handheld device that would otherwise have no fan management ### Risk Assessment **Extremely low risk:** - DMI matching is board-specific — it cannot affect any other hardware - The `oxp_fly` code path is already tested by three other devices - Reviewed by the subsystem maintainer (Ilpo Järvinen) - No new code paths, APIs, or behavioral changes ### User Impact Without this quirk, OneXPlayer APEX users running stable kernels have no fan control through the standard hwmon/pwm interface. For a handheld gaming device, this is a significant usability issue — inadequate fan control can lead to thermal throttling or excessive noise. ### Stable Criteria Check - **Obviously correct**: Yes — trivial DMI table addition using existing variant - **Fixes a real issue**: Yes — enables hardware support for real users - **Small and contained**: Yes — 7 lines of DMI match data - **No new features**: Correct — uses existing driver functionality - **No new APIs**: Correct ### Verification - Verified the `oxp_fly` variant is already used by three other DMI entries in the same table (F1, F1 EVA-01, F1 OLED) by examining the diff context - Verified the change is purely a DMI table addition with no logic changes - Verified the commit has `Reviewed-by: Ilpo Järvinen` (x86 platform maintainer) - Copyright year change is cosmetic and has zero functional impact This is a standard hardware quirk addition — exactly the type of small, safe change that stable trees accept to enable hardware support for real users. **YES** drivers/platform/x86/oxpec.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c index 144a454103b93..59d6f9d9a9052 100644 --- a/drivers/platform/x86/oxpec.c +++ b/drivers/platform/x86/oxpec.c @@ -11,7 +11,7 @@ * * Copyright (C) 2022 Joaquín I. Aramendía * Copyright (C) 2024 Derek J. Clark - * Copyright (C) 2025 Antheas Kapenekakis + * Copyright (C) 2025-2026 Antheas Kapenekakis */ #include @@ -142,6 +142,13 @@ static const struct dmi_system_id dmi_table[] = { }, .driver_data = (void *)oxp_2, }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER APEX"), + }, + .driver_data = (void *)oxp_fly, + }, { .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"), -- 2.51.0