From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842303822B7; Tue, 10 Mar 2026 10:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773139922; cv=none; b=UOtLJpOY2cu3AtAHSk7UIXzHScgeyVMeF7K925LIriX2WLqKmdQCCpz+hhT8QVqTE3aUl91qdv6Z3CrBcdAm99ae4scnSKVMVvpC9s0o7LrDUVhplLWgOFCvz+hfgUlwaUtsHR6MAL+1BPA9FwW1Z7eRrLbtOV/zGzIDqyYp+YI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773139922; c=relaxed/simple; bh=GrPnMKq8qTTLkSYj+FJaMFdtv5tT9Y8pQdQVL/qtdFI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PR18NF7gMMtaSI0b6h5rYDcOuqTq8oSGYw6t33Jzjme+viIe3/mEtADRW4vMXqqot1YGR738nwwjuzZZ32qQwUasMX3iKgD9VukMPwqRAIdVVqG9OPupBlnZVqY/rVEK3s8rQqfIuA8Ia/pOaHhSNSLBFI0UUMLizWolF3k43r4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a1dZ4uFs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a1dZ4uFs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55E63C19423; Tue, 10 Mar 2026 10:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773139922; bh=GrPnMKq8qTTLkSYj+FJaMFdtv5tT9Y8pQdQVL/qtdFI=; h=From:To:Cc:Subject:Date:From; b=a1dZ4uFsaXmQApLh6YtjH9fDB1EYtW7zDkkcc1+My3UIHxVZo//APXtHZyRH6OsE5 qZUlE1YN3TQ7fx5R6ZsnxBfU3+aQ+SsGzTU9ipzx8dN1kpTAXFtPwr5j45/LoUb4mj z61etJSbS3YgvuMR0eJQRGtq5V3JXJ+/rK0wB5YUSBnkuSafs9MikawB5OceULd0Gk /apGCf+iTl/JmDRvFoww+iUcAr04ge4+igf3IWc/pamRKy/QaB66UXEVQusnRpnLSJ IsgjajzxEOsnkWcq0YZFVkcsThTYeHR8SAwclfdSmMsoIEZLrirAO+DppNI+3Xl3JU GWD2vSG5WI5Zg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vzugy-000000004Zd-0eWZ; Tue, 10 Mar 2026 11:52:00 +0100 From: Johan Hovold To: Dave Penkler Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH] gpib: lpvo_usb: fix memory leak on disconnect Date: Tue, 10 Mar 2026 11:51:27 +0100 Message-ID: <20260310105127.17538-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver iterates over the registered USB interfaces during GPIB attach and takes a reference to their USB devices until a match is found. These references are never released which leads to a memory leak when devices are disconnected. Fix the leak by dropping the unnecessary references. Fixes: fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver") Cc: stable@vger.kernel.org # 6.13 Cc: Dave Penkler Signed-off-by: Johan Hovold --- drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 389dde5a8481..e6ea9422d6f2 100644 --- a/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -402,7 +402,7 @@ static int usb_gpib_attach(struct gpib_board *board, const struct gpib_board_con for (j = 0 ; j < MAX_DEV ; j++) { if ((assigned_usb_minors & 1 << j) == 0) continue; - udev = usb_get_dev(interface_to_usbdev(lpvo_usb_interfaces[j])); + udev = interface_to_usbdev(lpvo_usb_interfaces[j]); device_path = kobject_get_path(&udev->dev.kobj, GFP_KERNEL); match = gpib_match_device_path(&lpvo_usb_interfaces[j]->dev, config->device_path); @@ -417,7 +417,7 @@ static int usb_gpib_attach(struct gpib_board *board, const struct gpib_board_con for (j = 0 ; j < MAX_DEV ; j++) { if ((assigned_usb_minors & 1 << j) == 0) continue; - udev = usb_get_dev(interface_to_usbdev(lpvo_usb_interfaces[j])); + udev = interface_to_usbdev(lpvo_usb_interfaces[j]); DIA_LOG(1, "dev. %d: bus %d -> %d dev: %d -> %d\n", j, udev->bus->busnum, config->pci_bus, udev->devnum, config->pci_slot); if (config->pci_bus == udev->bus->busnum && -- 2.52.0