* [PATCH] crypto: atmel-aes - Fix 3-page memory leak in atmel_aes_buff_cleanup
@ 2026-03-11 2:07 Thorsten Blum
2026-03-21 8:47 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-03-11 2:07 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, Cyrille Pitchen
Cc: Thorsten Blum, stable, linux-crypto, linux-arm-kernel,
linux-kernel
atmel_aes_buff_init() allocates 4 pages using __get_free_pages() with
ATMEL_AES_BUFFER_ORDER, but atmel_aes_buff_cleanup() frees only the
first page using free_page(), leaking the remaining 3 pages. Use
free_pages() with ATMEL_AES_BUFFER_ORDER to fix the memory leak.
Fixes: bbe628ed897d ("crypto: atmel-aes - improve performances of data transfer")
Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/crypto/atmel-aes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index bc0c40f10944..9b0cb97055dc 100644
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -2131,7 +2131,7 @@ static int atmel_aes_buff_init(struct atmel_aes_dev *dd)
static void atmel_aes_buff_cleanup(struct atmel_aes_dev *dd)
{
- free_page((unsigned long)dd->buf);
+ free_pages((unsigned long)dd->buf, ATMEL_AES_BUFFER_ORDER);
}
static int atmel_aes_dma_init(struct atmel_aes_dev *dd)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] crypto: atmel-aes - Fix 3-page memory leak in atmel_aes_buff_cleanup
2026-03-11 2:07 [PATCH] crypto: atmel-aes - Fix 3-page memory leak in atmel_aes_buff_cleanup Thorsten Blum
@ 2026-03-21 8:47 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-03-21 8:47 UTC (permalink / raw)
To: Thorsten Blum
Cc: David S. Miller, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Cyrille Pitchen, stable, linux-crypto, linux-arm-kernel,
linux-kernel
On Wed, Mar 11, 2026 at 03:07:35AM +0100, Thorsten Blum wrote:
> atmel_aes_buff_init() allocates 4 pages using __get_free_pages() with
> ATMEL_AES_BUFFER_ORDER, but atmel_aes_buff_cleanup() frees only the
> first page using free_page(), leaking the remaining 3 pages. Use
> free_pages() with ATMEL_AES_BUFFER_ORDER to fix the memory leak.
>
> Fixes: bbe628ed897d ("crypto: atmel-aes - improve performances of data transfer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/crypto/atmel-aes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-21 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 2:07 [PATCH] crypto: atmel-aes - Fix 3-page memory leak in atmel_aes_buff_cleanup Thorsten Blum
2026-03-21 8:47 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox