From: kernel test robot <lkp@intel.com>
To: Nathan Rebello <nathan.c.rebello@gmail.com>, gregkh@linuxfoundation.org
Cc: oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org,
heikki.krogerus@linux.intel.com, kyungtae.kim@dartmouth.edu,
stable@vger.kernel.org,
Nathan Rebello <nathan.c.rebello@gmail.com>
Subject: Re: [PATCH v4] usb: typec: ucsi: validate connector number in ucsi_notify_common()
Date: Fri, 13 Mar 2026 18:37:45 +0100 [thread overview]
Message-ID: <202603131813.ofOSyCrk-lkp@intel.com> (raw)
In-Reply-To: <20260312211503.1915-1-nathan.c.rebello@gmail.com>
Hi Nathan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus westeri-thunderbolt/next linus/master v7.0-rc3 next-20260313]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nathan-Rebello/usb-typec-ucsi-validate-connector-number-in-ucsi_notify_common/20260313-200729
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20260312211503.1915-1-nathan.c.rebello%40gmail.com
patch subject: [PATCH v4] usb: typec: ucsi: validate connector number in ucsi_notify_common()
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260313/202603131813.ofOSyCrk-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260313/202603131813.ofOSyCrk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603131813.ofOSyCrk-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from drivers/usb/typec/ucsi/ucsi.c:11:
drivers/usb/typec/ucsi/ucsi.c: In function 'ucsi_notify_common':
>> drivers/usb/typec/ucsi/ucsi.c:50:44: warning: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
50 | dev_err(ucsi->dev, "bogus connector number in CCI: %u\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/usb/typec/ucsi/ucsi.c:50:25: note: in expansion of macro 'dev_err'
50 | dev_err(ucsi->dev, "bogus connector number in CCI: %u\n",
| ^~~~~~~
drivers/usb/typec/ucsi/ucsi.c:50:77: note: format string is defined here
50 | dev_err(ucsi->dev, "bogus connector number in CCI: %u\n",
| ~^
| |
| unsigned int
| %lu
vim +50 drivers/usb/typec/ucsi/ucsi.c
39
40 void ucsi_notify_common(struct ucsi *ucsi, u32 cci)
41 {
42 /* Ignore bogus data in CCI if busy indicator is set. */
43 if (cci & UCSI_CCI_BUSY)
44 return;
45
46 if (UCSI_CCI_CONNECTOR(cci)) {
47 if (UCSI_CCI_CONNECTOR(cci) <= ucsi->cap.num_connectors)
48 ucsi_connector_change(ucsi, UCSI_CCI_CONNECTOR(cci));
49 else
> 50 dev_err(ucsi->dev, "bogus connector number in CCI: %u\n",
51 UCSI_CCI_CONNECTOR(cci));
52 }
53
54 if (cci & UCSI_CCI_ACK_COMPLETE &&
55 test_and_clear_bit(ACK_PENDING, &ucsi->flags))
56 complete(&ucsi->complete);
57
58 if (cci & UCSI_CCI_COMMAND_COMPLETE &&
59 test_and_clear_bit(COMMAND_PENDING, &ucsi->flags))
60 complete(&ucsi->complete);
61 }
62 EXPORT_SYMBOL_GPL(ucsi_notify_common);
63
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2026-03-13 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 21:15 [PATCH v4] usb: typec: ucsi: validate connector number in ucsi_notify_common() Nathan Rebello
2026-03-13 8:53 ` Heikki Krogerus
2026-03-13 22:30 ` Nathan Rebello
2026-03-13 17:37 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603131813.ofOSyCrk-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyungtae.kim@dartmouth.edu \
--cc=linux-usb@vger.kernel.org \
--cc=nathan.c.rebello@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox