From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C387E22332E for ; Sat, 14 Mar 2026 17:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773507733; cv=none; b=Buv8+BnQEFazeeEK95uSPzLu8GsaxQIA1EtEcbyxVkJMBDhwok5cgHjlDREPyjGV6LOrFoK3AfRujcZQU2R0LEoBdNme/xuN3HT7Z7yPShBOezhlPCLUGuka7FM3yIYmZzBSciGiRzrrpJSwZnychc8++7FwwtdM/NKiIOoFv54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773507733; c=relaxed/simple; bh=pKI3AjG1lVa23KqAUrCKI+IQe27+GwOawv6PKd+Q5N8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OvBJGkGIS0RZsNnHc9yJQhvnF8IqO36JRQWR14gGRKtk7EoGuruBEXesCKjzRTLS7o+E8a6R5GCEzqZQyx1+91uJ5TtDmhOr7VyYpS0H5f4sJZcas/PePn0dVnaKWNgC7oFv5gt7fOMl7LoJ/0Tzh1+WMMyxeuXPk3Q69UjYmTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i7VVccyg; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i7VVccyg" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7d74c1157a4so3258807a34.1 for ; Sat, 14 Mar 2026 10:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773507732; x=1774112532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LM37OfuWQSqpQhEds9aiEp1hWY724n1ZIFNOigUMwNc=; b=i7VVccygtZxgq2bgLlL76PB0wDdamDGgBdxs4KqrxF1eVFsTIvA5WtutoQbizVkIyF ew40h3CK/+NlCOO0Yomn1y27ADax2y6MvXIz9bwqipPuSTgDxZj7htRkpAYW7MzVZq2Y SpwR7Nj7Xi9mC2ywStEpaueocA6vkwHXsX+nEJyYXtBxpuJJQ/53Qt0JYV2MQtJ0JrWL kCBJor4bonrpD2PioOy9QSiq+rEyoZDTGS/BUjkOG43SdCpARWQEsZP1jVvSNTLdwt1n 3CNz31odthFpPVdR79rFP3H6bAEp/uGKkpeQ/43STCi92/iuoAyfjX3g9iM9nu6Qg8cp Ygfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773507732; x=1774112532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LM37OfuWQSqpQhEds9aiEp1hWY724n1ZIFNOigUMwNc=; b=U4P3W0Q3fJWL7bRkPd037owitWqVmGCSZQA8smdpQ/l6ALtkvUgP3zlUN7gQ5K/emR Nl2rsaUif0TMfqTDiXX2JTPG3Xlpx2654YzE/HlxvpN41Q1+rwgoJiGUPI3aRdlT7ZL/ Q37NDChOfRPtOSOKLE9cn73wBcc6TuKi6efUGeOX1ZqAiLHghDVQjndqiMQLGOl/i6Bw AQA+NibCGhVK9VjScANtyfrKAP1Tvn2OMuIW0vinzzjXA0Fi9U8mSKEVI8KshZtP8SJK N7NP95G/6MuRi7ldchvvLq2m5Bq29I10/rhkY2tsfk3jMiRyIaKOcH3bhxI2U4md7B4X H3Wg== X-Forwarded-Encrypted: i=1; AJvYcCX4lxg85F+DlN1YHAv2YrpvZFWhrbuy+lDyA/iQXEMyKKVkZxZHDlqpoCN4PKySEa4OyjryrCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3zV7POCrBuhQlfsnZe9SWrO0X8BA9KMKdVl3BIEW7K98bGjT4 8N2WqFQ00wDDvRr+AugL72nPJu0ad3ODV95bFwqHS7+OCLMySMmgUevl X-Gm-Gg: ATEYQzwNg81Q/zO/mysQqaRM4g1hvflIyqkhRWVpO6q3LLd2MENmaygHBtHBcEg4Kf/ Iz7AhvlMH0ce+HSs5TnHqCPHViC8OB/CndpRgxDBMyVPZar7xlztLe4q9nt8rujzv1ZucwBnvev vjNtbPpQRb0rwYuo5tKq5NIa6HES8O+97tMNRxUJq5d9lCBMXryBIEeQl/bbeoWJUNsWD2+/02j qg0eSL1eL6sXo+8FFlQtnyZZYai27BRefxLcH/AMs0W4ETkO5sC9jG+4KLVzIdUBkorrZvM7ym+ BTgJ0XmSlflxuyfVZNviD9EVzNs/vUbCNya3PpKxvnLhh+9ZrsmS4KvaistnMIzRZwTRRiq+Dqo TogsdhrJCnyz+mCad0XceHrqAnRGfHcRl9Mdar7/ZE0yVni6GMA+tHLbWyYC7dRwVjoL0VQ8k1a jJJydNZEYI0MAdDIj6FLzed75vNy2HsWo19u3ZgMtJ4jfX987YU5/1wEJHgK2Pqc+C84HsowkA5 oKi X-Received: by 2002:a05:6830:6607:b0:7d7:3937:97bb with SMTP id 46e09a7af769-7d78245c4famr5186888a34.9.1773507731706; Sat, 14 Mar 2026 10:02:11 -0700 (PDT) Received: from CS-396-Lab-Machine.. (c-24-12-10-127.hsd1.il.comcast.net. [24.12.10.127]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e2a17f1sm11610430fac.8.2026.03.14.10.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 10:02:11 -0700 (PDT) From: Tyllis Xu X-Google-Original-From: Tyllis Xu To: tyreld@linux.ibm.com Cc: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, brking@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, danisjiang@gmail.com, ychen@northwestern.edu, Tyllis Xu Subject: [PATCH] scsi: ibmvfc: fix OOB access in ibmvfc_discover_targets_done() Date: Sat, 14 Mar 2026 12:01:50 -0500 Message-ID: <20260314170151.548614-1-LivelyCarpet87@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A malicious or compromised VIO server can return a num_written value in the discover targets MAD response that exceeds max_targets. This value is stored directly in vhost->num_targets without validation, and is then used as the loop bound in ibmvfc_alloc_targets() to index into disc_buf[], which is only allocated for max_targets entries. Indices at or beyond max_targets access kernel memory outside the DMA-coherent allocation. The out-of-bounds data is subsequently embedded in Implicit Logout and PLOGI MADs that are sent back to the VIO server, leaking kernel memory. Fix by clamping num_written to max_targets before storing it. Fixes: 072b91f9c651 ("[SCSI] ibmvfc: IBM Power Virtual Fibre Channel Adapter Client Driver") Reported-by: Yuhao Jiang Cc: stable@vger.kernel.org Signed-off-by: Tyllis Xu --- drivers/scsi/ibmvscsi/ibmvfc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index a20fce04fe79..3dd2adda195e 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c @@ -4966,7 +4966,8 @@ static void ibmvfc_discover_targets_done(struct ibmvfc_event *evt) switch (mad_status) { case IBMVFC_MAD_SUCCESS: ibmvfc_dbg(vhost, "Discover Targets succeeded\n"); - vhost->num_targets = be32_to_cpu(rsp->num_written); + vhost->num_targets = min_t(u32, be32_to_cpu(rsp->num_written), + max_targets); ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_ALLOC_TGTS); break; case IBMVFC_MAD_FAILED: -- 2.43.0