From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AD9634F486; Tue, 17 Mar 2026 11:32:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773747171; cv=none; b=BuQTb6Ky3iQxRUDBdB9e5FKaTMGv+wcpwh1RZ9xqv/55x8r85tGY9JFtv11pqD7dSqm0j5aFpe8KYN1A70QiQ1ixxpDcMCOFaBQLtuysye2YxLcD5T524NEIqF4tuAnhHK1HDHXeDnGMfxPvf5XREfKnjgN6bhGnOsi9sDChAqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773747171; c=relaxed/simple; bh=j8G42BMIwkJi1ZWkspY+1Bbp3gHjsqAQ1779Dfn5r6s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=jWE4nrSfPvhUAcDAhKBnyzHofjGXjYo3Ps1CmmFZ2kgmE+a+e0nIRuKVelIigs+7yFUwJWLNxp0IvkwCxkhT3Oyjc0l2UZiYsQGe7jwAlTt+YTtyHeAKUPN3DFSeizQA//pfzpdHU2+zdoyfDZhSiwNNST9sV26xomUZgRHvGvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pBtgs+PF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pBtgs+PF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A370C4CEF7; Tue, 17 Mar 2026 11:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773747171; bh=j8G42BMIwkJi1ZWkspY+1Bbp3gHjsqAQ1779Dfn5r6s=; h=From:To:Cc:Subject:Date:From; b=pBtgs+PF+oovxpeJf8d7GuIZhYXd2qICl8+vMByTgfcaML8P/tAFL/ela0+6XzETH 3E0Mqof4RRV2UwtyFop5yCyWm67xI/7yR8jNL+MFhOT+pG3PcAllTgEMFJ/usdfMd4 w5UzDpwPSkVfF7JBRlX+HxcvwWRYed8Qi7wnWKitEjPms+kA4TuT0i/6X5HuV1h9O/ 2zz5EzQ2J85EHT/yTPotLkkCRANezGJ81ghLOIzfQmiwx6tkxWKNAWn0iTE1ONlBKp h0sFu9lMDJ3Ot8Z2ZQYVDvaSd9m5c0QrR3ydCZel0VAZqTTTmH6DVjJf8ELBbtE5vB g7/VaW1YOx7Zg== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Liucheng Lu , Takashi Iwai , Sasha Levin , perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.19-6.1] ALSA: hda/realtek: add HP Laptop 14s-dr5xxx mute LED quirk Date: Tue, 17 Mar 2026 07:32:32 -0400 Message-ID: <20260317113249.117771-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.19.8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Liucheng Lu [ Upstream commit 178dd118c0f07fd63a9ed74cfbd8c31ae50e33af ] HP Laptop 14s-dr5xxx with ALC236 codec does not handle the toggling of the mute LED. This patch adds a quirk entry for subsystem ID 0x8a1f using ALC236_FIXUP_HP_MUTE_LED_COEFBIT2 fixup, enabling correct mute LED behavior. Signed-off-by: Liucheng Lu Link: https://patch.msgid.link/PAVPR03MB9774F3FCE9CCD181C585281AE37BA@PAVPR03MB9774.eurprd03.prod.outlook.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: ## Analysis This is a textbook audio codec quirk addition — a single `SND_PCI_QUIRK` line added to the HDA Realtek quirk table for HP Laptop 14s-dr5xxx (subsystem ID `0x103c:0x8a1f`), using the existing `ALC236_FIXUP_HP_MUTE_LED_COEFBIT2` fixup. **What it fixes:** The mute LED on HP Laptop 14s-dr5xxx doesn't toggle correctly without this quirk. This is a real hardware issue affecting users of this specific laptop model. **Scope and risk:** One line added to a quirk table. The fixup `ALC236_FIXUP_HP_MUTE_LED_COEFBIT2` is already used by multiple other HP laptops in the same table (e.g., `0x89a0` "HP Laptop 15-dw4xxx", `0x8a20` "HP Laptop 15s-fq5xxx"). Zero risk of regression — it only matches the specific subsystem ID and applies an already-proven fixup chain. **Stable criteria:** - Obviously correct: Yes, trivial one-line quirk entry - Fixes a real bug: Yes, broken mute LED on specific hardware - Small and contained: Yes, single line - No new features: Correct, uses existing fixup - No new APIs: Correct This falls squarely into the "AUDIO CODEC QUIRKS" exception category explicitly listed as YES for stable. Verification: - Confirmed from the diff that `ALC236_FIXUP_HP_MUTE_LED_COEFBIT2` is already used by adjacent entries (lines for 0x89a0 and 0x8a20) in the same quirk table - Confirmed the change is a single line addition with no other code modifications - The commit was accepted by the HDA maintainer (Takashi Iwai) via the standard patch process **YES** sound/hda/codecs/realtek/alc269.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index f5719e630d28a..13d14c86569f9 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -6917,6 +6917,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX), SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT), SND_PCI_QUIRK(0x103c, 0x8a26, "HP Victus 16-d1xxx (MB 8A26)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT), -- 2.51.0