From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: "Ionut Nechita (Wind River)" <ionut.nechita@windriver.com>,
m.szyprowski@samsung.com, kbusch@kernel.org, axboe@kernel.dk,
hch@lst.de, sagi@grimberg.me, robin.murphy@arm.com,
martin.petersen@oracle.com, damien.lemoal@opensource.wdc.com,
ahuang12@lenovo.com, iommu@lists.linux.dev,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, ionut_n2001@yahoo.com,
sunlightlinux@gmail.com
Subject: Re: [PATCH v1 0/2] dma: fix dma_opt_mapping_size() returning bogus value when no backend hint exists
Date: Tue, 17 Mar 2026 15:36:51 +0100 [thread overview]
Message-ID: <20260317143651.GA5186@lst.de> (raw)
In-Reply-To: <8b7706a0-41be-44a2-8247-ebbc33fee937@oracle.com>
On Tue, Mar 17, 2026 at 09:11:59AM +0000, John Garry wrote:
> For SAS controllers, don't we limit shost->opt_sectors at
> shost->max_sectors, and then in sd_revalidate_disk() this value is ignored
> as sdkp->opt_xfer_blocks would be smaller, right?
That assumes opt_xfer_blocks is actually set. It's an optional and
relatively recent SCSI feature. So don't expect crappy SSDs or
RAID controllers faking up SCSI in shitty firmware to actually set
it.
next prev parent reply other threads:[~2026-03-17 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 20:39 [PATCH v1 0/2] dma: fix dma_opt_mapping_size() returning bogus value when no backend hint exists Ionut Nechita (Wind River)
2026-03-16 20:39 ` [PATCH v1 1/2] dma: return 0 from dma_opt_mapping_size() when no real " Ionut Nechita (Wind River)
2026-03-17 9:43 ` Robin Murphy
2026-03-17 14:19 ` Christoph Hellwig
2026-03-16 20:39 ` [PATCH v1 2/2] nvme-pci: handle dma_opt_mapping_size() returning 0 Ionut Nechita (Wind River)
2026-03-16 21:21 ` Damien Le Moal
2026-03-17 8:55 ` John Garry
2026-03-17 14:14 ` Christoph Hellwig
2026-03-17 9:11 ` [PATCH v1 0/2] dma: fix dma_opt_mapping_size() returning bogus value when no backend hint exists John Garry
2026-03-17 9:18 ` Damien Le Moal
2026-03-17 14:36 ` Christoph Hellwig [this message]
2026-03-17 15:18 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317143651.GA5186@lst.de \
--to=hch@lst.de \
--cc=ahuang12@lenovo.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=iommu@lists.linux.dev \
--cc=ionut.nechita@windriver.com \
--cc=ionut_n2001@yahoo.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=sunlightlinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox